[1.8] Getting the players GameMode

[The_SlayerMC]

Hello, I'm trying to get the players game mode is single player. But the only way i can figure it out is using this:

EntityPlayerMP playerMP = (EntityPlayerMP)event.player;
	if(playerMP.theItemInWorldManager.getGameType() != GameType.CREATIVE || playerMP.theItemInWorldManager.getGameType() != GameType.SPECTATOR) {

 

Is there any other way to do it?

[Anon10W1z]

Don't do that. The player will always be null.

[The_SlayerMC]

Then what should i do? I want access to all the game modes not just creative

[Anon10W1z]

http://www.minecraftforge.net/forum/index.php/topic,11560.msg59626.html#msg59626

 

EDIT: Minecraft.getMinecraft().playerController.getCurrentGameType();

[The_SlayerMC]

I also want to state that im using the tick event for this code, aswell as @SideOnly(Side.CLIENT) annotation because on servers it crashes without it...

I know it's not supposed to be used that but i don't think that client and EntityPlayerMP is compatible (Well duhhh)

[The_SlayerMC]

private EssenceItems item = new EssenceItems();
private Item boots = null, body = null, legs = null, helmet = null;

@SubscribeEvent
public void playerTick(PlayerTickEvent event) {
	ItemStack stackBoots = event.player.inventory.armorItemInSlot(0);
	ItemStack stackLegs = event.player.inventory.armorItemInSlot(1);
	ItemStack stackBody = event.player.inventory.armorItemInSlot(2);
	ItemStack stackHelmet = event.player.inventory.armorItemInSlot(3);
	if(stackBoots != null) boots = stackBoots.getItem();
	else boots = null;
	if(stackBody != null) body = stackBody.getItem();
	else body = null;
	if(stackLegs != null) legs = stackLegs.getItem();
	else legs = null;
	if(stackHelmet != null) helmet = stackHelmet.getItem();
	else helmet = null;

	EntityPlayerMP playerMP = (EntityPlayerMP)event.player;
	if(playerMP.theItemInWorldManager.getGameType() != GameType.CREATIVE || playerMP.theItemInWorldManager.getGameType() != GameType.SPECTATOR) {
		if(helmet == item.flairiumHelmet && body == item.flairiumChest && legs == item.flairiumLegs && boots == item.flairiumBoots){
			event.player.capabilities.allowFlying = true;
		} else {
			event.player.capabilities.allowFlying = false;
			event.player.capabilities.isFlying = false;
		}
	}
}

 

That gives me a crash that leads to this when trying to enter a server with my mod and also when i use the EntityPlayerMP code in sp:

 

 

[12:26:31] [Client thread/ERROR] [FML]: 0: NORMAL
[12:26:31] [Client thread/ERROR] [FML]: 1: ASM: net.essence.event.ArmorAbilityEvent@262d72a playerTick(Lnet/minecraftforge/fml/common/gameevent/TickEvent$PlayerTickEvent;)V
[12:26:31] [Client thread/ERROR] [FML]: 2: ASM: net.essence.event.PlayerEvent@621104df onTick(Lnet/minecraftforge/fml/common/gameevent/TickEvent$PlayerTickEvent;)V
[12:26:31] [Client thread/ERROR] [FML]: 3: ASM: net.essence.event.PlayerEvent@7a615950 onTick(Lnet/minecraftforge/fml/common/gameevent/TickEvent$PlayerTickEvent;)V
[12:26:31] [Client thread/ERROR] [FML]: 4: ASM: net.essence.client.BarTickHandler@1a68c0c onTick(Lnet/minecraftforge/fml/common/gameevent/TickEvent$PlayerTickEvent;)V

 

 

[coolAlias]

That's because PlayerTickEvent happens on BOTH sides - always type check before casting:

if (event.player instanceof EntityPlayerMP) {
EntityPlayerMP playerMP = (EntityPlayerMP) event.player;
// rest of code relying on playerMP still within condition
}

[The_SlayerMC]

Oh my god... that was so fucking stupid of me hahaha. Thanks, ill try it out.

[The_SlayerMC]

Okay, so how would i go for being in single player and checking the game mode?

[coolAlias]

Okay, so how would i go for being in single player and checking the game mode?

Exactly the same. Single player has the integrated server which uses EntityPlayerMP just like the dedicated server. Nowadays the vast majority of code does not need to change whether in single or multi player.

[The_SlayerMC]

Well using

if (event.player instanceof EntityPlayerMP) {
		EntityPlayerMP playerMP = (EntityPlayerMP)event.player;
		if(playerMP.theItemInWorldManager.getGameType() != GameType.CREATIVE || playerMP.theItemInWorldManager.getGameType() != GameType.SPECTATOR) {
			if(helmet == item.flairiumHelmet && body == item.flairiumChest && legs == item.flairiumLegs && boots == item.flairiumBoots) {
				event.player.capabilities.allowFlying = true;
			} else {
				event.player.capabilities.allowFlying = false;
				event.player.capabilities.isFlying = false;
			}
		}
	}

Doesn't let me fly when using the flairium armour set anymore. Doesn't matter what game mode I'm in

[coolAlias]

That's because the client side version of the player doesn't know he can fly - it wouldn't work in multiplayer, either. Send a packet to update the client player's capabilities when you change them (there is a vanilla packet for this).

[The_SlayerMC]

I've never really even used packets, it sounds noobish but i haven't ever had a need for it

[coolAlias]

I've never really even used packets, it sounds noobish but i haven't ever had a need for it

Well, lucky for you then that you don't even need to make your own:

((EntityPlayerMP) player).playerNetServerHandler.sendPacket(new S39PacketPlayerAbilities(player.capabilities));

[The_SlayerMC]

Okay! it worked!! Thanks a bunch. But how would i go around getting it to be compatable with Morph and mods like that?

[Draco18s]

Step 1) Find a way to store data about the player somewhere, probably on the player (left as an exercise to the reader)

Step 2) If the player is not wearing the equipment, disable the capability of flying and save "I have turned flying off" to the data in step 1

Step 3) Next tick, if "I have turned flying off" is true, set it to false, if capability of flying is still false, turn off isFlying

Step 4) Technically optional, save a "I attempted to disable flying" value in step 1 to true, and don't change it to false until your mod enables flying again (ignore checking if flying is not allowed while this value is flagged; it saves some CPU cycles)

 

That way if another mod is allowing flight, your mod only disables the capability for 1 tick and doesn't make the player fall (which gives another mod the opportunity to turn the capability back on) and you don't constantly re-check.

[Anon10W1z]

What the hell are you doing Anon10W1z?

The code he used was perfectly fine. Do not use Minecraft.getMinecraft().

He said this is singleplayer.

[coolAlias]

What the hell are you doing Anon10W1z?

The code he used was perfectly fine. Do not use Minecraft.getMinecraft().

He said this is singleplayer.

That would still only give you the client player, and would crash the mod if played on a server. There is absolutely no reason at all to use Minecraft.getMinecraft() in this case, single player or not.