Jump to content

[1.8] How do I prevent Mineshaft generation in specific chunks?


utoxin

Recommended Posts

I'm trying to build my UHC mod, and I have the code that generates the bedrock wall working nearly perfectly. But it seems like somehow some of the chunk population is running after my code, even though I'm running it in the PopulateChunkEvent.Post event handler.

 

Here's the file that's running my actual generation: http://bit.ly/1zdQDvE

 

I've triple-checked that I'm only replacing blocks that are in the current chunk, at least for the wall itself. It's possible that the 'starting area' platform is less well behaved, but that code is all getting replaced soon anyway. Lines 24-72 should be the relevant code. The problem is that lakes and mineshafts have a tendency to punch holes in the bedrock wall, as if they are generating after the wall, even though they should all be executing first.

 

Edit:

 

Well, I've now attempted to reject any terrain decoration in chunks that contain my wall, with no effect (so I'm probably doing it wrong), and giving my event handler the Lowest priority, so it should run last, with no effect.

 

I'm out of ideas, and going to bed for the night.

Developer of Failure UHC, Amateur Youtuber

http://www.youtube.com/kydancemw

Link to comment
Share on other sites

I've now run through this in debug mode, and as far as I can tell, I'm doing this perfectly, which just makes me more confused. Is it possible that feature generation in neighboring chunks is bleeding into one of the chunks I generate stuff in?

 

Edit:

 

Yup. That's what's happening. Time to ponder solutions. Any suggested ways of fixing this?

Developer of Failure UHC, Amateur Youtuber

http://www.youtube.com/kydancemw

Link to comment
Share on other sites

I ran into a similar issue, and though I'm not 100% sure, I believe that lakes at least DO generate across multiple chunks at once.

 

What I did is to deny lake generation if the chunk it is in or any immediate neighbor has my structure in it, and this seems to have solved the problem.

 

I say 'seems' because while it fixed it in the one seed in which I found it, I haven't been able to verify for a fact that it will work in all circumstances. Haven't had an issue reported since, though.

Link to comment
Share on other sites

Yeah, that's sort of what I'm looking into doing. But in my case, I need to worry about mineshafts too, so I may need to go further out than just one chunk. I know they can punch through, but I need to look at their generation to see how it works.

 

Thanks for the source links, they should be very helpful. :)

Developer of Failure UHC, Amateur Youtuber

http://www.youtube.com/kydancemw

Link to comment
Share on other sites

Well, coolAlias' fix solved the issue with lakes and lava lakes. But doesn't help with mineshafts. Is there a decent way to prevent mineshafts from generating through a specific chunk? I've scanned through the code and haven't seen anything that looked helpful, but I hope I missed it.

Developer of Failure UHC, Amateur Youtuber

http://www.youtube.com/kydancemw

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.