Jump to content

HashMapping issue has me stumped


Draco18s

Recommended Posts

So I'm having an issue with a wrapper class I wrote, so I can map a block+metadata to another piece of information data.  It works find in Eclipse, no problems, none.

 

Yet I've got reports from players (of a specific modpack, none the less, I haven't had reports from anyone else) of some console spam that only shows up if there is no match between the block and the info in the hashmap.  The console spam is just debug logging info trying to resolve the underlying problem.

 

Here's a section of that logging info, note the 4th listed item:

 

[15:43:27][com.draco18s.ores.block.ores.BlockHardOreBase:func_149726_b:201]: Hard Ore block, tile.ore_diamond has no flower data.  This is a bug!
[com.draco18s.ores.block.ores.BlockHardOreBase:func_149726_b:203]: Listing all mapped blocks:
[com.draco18s.ores.block.ores.BlockHardOreBase:func_149726_b:206]:     tile.ore_iron:-1 false
[com.draco18s.ores.block.ores.BlockHardOreBase:func_149726_b:206]:     tile.ore_gold:-1 false
[com.draco18s.ores.block.ores.BlockHardOreBase:func_149726_b:206]:     tile.beyondrealitycore:oreCopper:0 false
[com.draco18s.ores.block.ores.BlockHardOreBase:func_149726_b:206]:     tile.ore_diamond:-1 true
[com.draco18s.ores.block.ores.BlockHardOreBase:func_149726_b:206]:     tile.beyondrealitycore:oreTin:0 false
[com.draco18s.ores.block.ores.BlockHardOreBase:func_149726_b:206]:     tile.ore_redstone:0 false
[com.draco18s.ores.block.ores.BlockHardOreBase:func_149726_b:206]:     tile.ore_redstone:1 false

 

Here's the code that generates the logging:

		BlockWrapper bw = new BlockWrapper(this,-1);
	OreData dat = HardLibAPI.recipeManager.getOreList().get(bw);
	if(dat != null) {
		//do stuff
	}
	else {
		System.out.println("Hard Ore block, " + this.getUnlocalizedName() + " has no flower data.  This is a bug!");
		System.out.println("Listing all mapped blocks:");
		Map<BlockWrapper,OreFlowerData> map = HardLibAPI.recipeManager.getOreList();
		for(BlockWrapper b : map.keySet()) {
			System.out.println("    " + b.block.getUnlocalizedName() + ":" + b.meta + " " + bw.equals(b));
		}
	}

 

Here's the wrapper class:

public class BlockWrapper {
public Block block;
public int meta;
private int fHashCode;

/**
 * the block and metadata to match, -1 matches all
 **/
public BlockWrapper(Block block, int meta) {
	this.block = block;
	this.meta = meta;
}

@Override
public int hashCode() {
	if (fHashCode == 0) {
	      int result = HashUtils.SEED;
	      result = HashUtils.hash(result, Block.getIdFromBlock(block));
	      fHashCode = result;
	}
	return fHashCode;
    }

@Override
public boolean equals(Object aThat) {
	if(aThat instanceof BlockWrapper) {
		BlockWrapper other = (BlockWrapper)aThat;
		return other.block == this.block && (other.meta == -1 || this.meta == -1 || other.meta == this.meta);
	}
	return false;
}
}

 

I don't get what could possibly be going wrong to cause map.get(key) to be returning null here.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Block IDs are not consistent, hence your hash code will not be consistent. That is a BAD idea.

 

Even when the mods don't change? I thought it was at least stable under those conditions. And the hash is built during startup, IDs shouldn't change while the program is running and nothing about this data structure persists between runs (or even be relevant), it shouldn't even matter that the IDs changed due to a new mod install.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

IDs are not generated on startup, but per-world.

 

Whenever new world is generated - (or there are missing entries) dictionary is being created in world's data.

Dictionary binds names with newly generated IDs.

 

In world1 245 can be Copper_Ore

In world2 245 can be Tungsten_Rod

1.7.10 is no longer supported by forge, you are on your own.

Link to comment
Share on other sites

Ahh, that's what I didn't know.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.