Jump to content

Error when reobfuscating with version 6.3.0.372 and MC 1.4.4


AbeJ

Recommended Posts

It's a completely clean jar, downloaded by Forge. Here's the relevant part of the output:

 

== Reobfuscating server ==
> Cleaning reobf
> Generating md5s
> Packing jar
> Reobfuscating jar
'"java" -cp "runtime/bin/retroguard.jar:lib:lib/*:jars/minecraft_server.jar" RetroGuard -notch temp/s...' failed : 1

== ERRORS FOUND ==

Unrecoverable error during obfuscation, see log file for details.
ERROR: error in opening zip file
==================

FATAL ERROR
Traceback (most recent call last):
  File "runtime/reobfuscate.py", line 53, in reobfuscate
    reobfuscate_side(commands, SERVER, reobf_all=reobf_all)
  File "/Users/abe/mcp/runtime/mcp.py", line 158, in reobfuscate_side
    commands.applyrg(side, True)
  File "/Users/abe/mcp/runtime/commands.py", line 907, in applyrg
    self.runcmd(forkcmd)
  File "/Users/abe/mcp/runtime/commands.py", line 1111, in runcmd
    raise CalledProcessError(process.returncode, forkcmd, output)
CalledProcessError: Command '"java" -cp "runtime/bin/retroguard.jar:lib:lib/*:jars/minecraft_server.jar" RetroGuard -notch temp/server_ro.cfg' returned non-zero exit status 1

 

Any ideas? I'm running Python 2.7.2, but I don't think that's important in this case.

Link to comment
Share on other sites

Same problem here. Linux, checked permissions, they're the same for both files. Here's what I found on my server_ro.log file:

 


# If this log is to be used for incremental obfuscation / patch generation, 
# add any '.class', '.method', '.field' and '.attribute' restrictions here:


#-DO-NOT-EDIT-BELOW-THIS-LINE------------------DO-NOT-EDIT-BELOW-THIS-LINE--
#
# RetroGuard MCP v3.6.5
#
# Logfile created on Tue Nov 20 20:22:59 BRST 2012
#
# Jar file to be obfuscated:           server_recomp.jar
# Target Jar file for obfuscated code: server_reobf.jar
# RetroGuard Script file used:         retroguard_ro.cfg
#

# Unrecoverable error during obfuscation:
# Review input jar for duplicate classes (same classfile with two different filenames).
# java.util.zip.ZipException: error in opening zip file
# 	at java.util.zip.ZipFile.open(Native Method)
# 	at java.util.zip.ZipFile.<init>(ZipFile.java:131)
# 	at java.util.zip.ZipFile.<init>(ZipFile.java:148)
# 	at COM.rl.obf.GuardDB.<init>(GuardDB.java:113)
# 	at COM.rl.obf.RetroGuardImpl.run(RetroGuardImpl.java:172)
# 	at COM.rl.obf.RetroGuardImpl.obfuscate(RetroGuardImpl.java:131)
# 	at COM.rl.obf.RetroGuardImpl.obfuscate(RetroGuardImpl.java:113)
# 	at RetroGuard.main(RetroGuard.java:90)

 

Interesting, I tried to check this server_recomp.jar file(all permissions to read, is only 22B in size(?!) ) and got this:

$ jar -tf temp/server_recomp.jar 
java.util.zip.ZipException: error in opening zip file
at java.util.zip.ZipFile.open(Native Method)
at java.util.zip.ZipFile.<init>(ZipFile.java:131)
at java.util.zip.ZipFile.<init>(ZipFile.java:92)
at sun.tools.jar.Main.list(Main.java:997)
at sun.tools.jar.Main.run(Main.java:242)
at sun.tools.jar.Main.main(Main.java:1167)

 

From here, I'm lost.

 

ADDENDUM: It does obfuscate the client classes, so they're there in the reobf folder. The mod works. But... I'm not sure if even in minecraft 1.3+ that's what's supposed to happen.

Link to comment
Share on other sites

Well, as of 1.4.5 we are no longer decompiling the server jar at all.

You shouldn't care about the server side obf {it shouldn't even be trying to obf it..} as your mod SHOULD be universal, if you did it right.

Still interesting that it screws up without giving a real error.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Link to comment
Share on other sites

I haven't ran into this issue in the wild, a few people seem to of got it but I don't think it's anything in particular to do with Forge. As we can reobf things properly.

But ya, This shouldn't be remotely a issue in 1.4.5

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.