TextureAtlasSprite customLoader and Mipmap Levels

[Draco18s]

Is it vanilla or Forge that allows for custom sprite loaders?  Want to report to the right people, for now I am assuming Forge inserts that as part of its patch (because why the hell would vanilla assume custom loaders!).

 

The custom sprite

load

method is not passed a number of mipmap levels and

TextureMap.mipmapLevels

is a private field.  This value is passed to

loadSprite

, albeit indirectly as the length of a buffered image array.

 

This makes correctly instantiating the

framesTextureData

2D arrays difficult: the sprite MUST assume the maximum number of mipmaps possible for its own size (for 16x16 default resources, this is 4) which could lead to problems if the number that the system goes to generate exceeds this value (unlikely, but possible) and under lower mipmap settings just wastes RAM.  Or it forces the modder to use Reflection in order to get access to the private field.

 

Either this method would need to include that integer value or

TextureMap.mipmapLevels

needs a getter method via

IResourceManager

.

[LexManos]

'Is it something added by Forge.. I wonder where I could figure that out, maybe the public repository where it lists all the patches at Forge applies...'

Make a PR.