Jump to content

1.8 Right-Click on block to get items doesn't work


OrangeVillager61

Recommended Posts

Hello! I am trying to get it to when I right-click the block (a block from my mod) the blockstate is full it will change to empty and it will drop two items.

However when I right-click the block the items don't appear. :(

 

The code below:

 

@Override

public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn, EnumFacing side, float hitX, float hitY, float hitZ) {

if (state.getValue(TYPE) == EnumType.FULL){

worldIn.setBlockState(pos, (this.blockState.getBaseState().withProperty(TYPE, EnumType.EMPTY)));

EntityItem entityitem1 = new EntityItem(worldIn, hitX, hitY, hitZ, new ItemStack(Items.bucket, 1));

EntityItem entityitem2 = new EntityItem(worldIn, hitX, hitY, hitZ, new ItemStack(OraniaItems.bucket_of_brine, 1));

worldIn.spawnEntityInWorld(entityitem1);

worldIn.spawnEntityInWorld(entityitem2);

return true;

}

return false;

}

Link to comment
Share on other sites

Not sure if your just making a simple slip-up or don't know java well enough yet.

 

A single equals is for assigning a value, a double equals is for comparing.

 

(worldIn.isRemote = false)

^ This is trying to set the isRemote field to false, but you can't because its final.

 

if (worldIn.isRemote == false)

^ this is what you want

Or better yet:  if (!worldIn.isRemote)

It is the shortened form of: if (worldIn.isRemote != true)

The exclamation mark represents not, so the statement is read as 'if world.isRemote is not true' thus its false.

 

 

Link to comment
Share on other sites

(I put the entire onBlockActivated code)

 

@Override

public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn, EnumFacing side, float hitX, float hitY, float hitZ) {

// This is some other code go to the next //

if (state.getValue(TYPE) == EnumType.EMPTY){

ItemStack itemstack = playerIn.getCurrentEquippedItem();

if (itemstack.getItem() == Items.water_bucket){

worldIn.setBlockState(pos, (this.blockState.getBaseState().withProperty(TYPE, EnumType.FULL)));

if (!playerIn.capabilities.isCreativeMode) {

playerIn.destroyCurrentEquippedItem();

return true;

}

 

}

}

//This is the code I'm using

if (!worldIn.isRemote){

if (state.getValue(TYPE) == EnumType.FULL){

worldIn.setBlockState(pos, (this.blockState.getBaseState().withProperty(TYPE, EnumType.EMPTY)));

EntityItem entityitem1 = new EntityItem(worldIn, hitX, hitY, hitZ, new ItemStack(Items.bucket, 1));

EntityItem entityitem2 = new EntityItem(worldIn, hitX, hitY, hitZ, new ItemStack(OraniaItems.bucket_of_brine, 1));

worldIn.spawnEntityInWorld(entityitem1);

worldIn.spawnEntityInWorld(entityitem2);

return true;

}

}

return false;

}

Link to comment
Share on other sites

What I meant by This is some other code go to the next // is different code unrelated with my problem. I adjusted the code however it still does not work.

 

@Override

public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn, EnumFacing side, float hitX, float hitY, float hitZ) {

 

if (state.getValue(TYPE) == EnumType.EMPTY){

ItemStack itemstack = playerIn.getCurrentEquippedItem();

if (itemstack.getItem() == Items.water_bucket){

worldIn.setBlockState(pos, (this.blockState.getBaseState().withProperty(TYPE, EnumType.FULL)));

if (!playerIn.capabilities.isCreativeMode) {

playerIn.destroyCurrentEquippedItem();

return true;

}

return false;

}

}

if (!worldIn.isRemote){

if (state.getValue(TYPE) == EnumType.FULL){

worldIn.setBlockState(pos, (this.blockState.getBaseState().withProperty(TYPE, EnumType.EMPTY)));

EntityItem entityitem1 = new EntityItem(worldIn, hitX, hitY, hitZ, new ItemStack(Items.bucket, 1));

EntityItem entityitem2 = new EntityItem(worldIn, hitX, hitY, hitZ, new ItemStack(OraniaItems.bucket_of_brine, 1));

worldIn.spawnEntityInWorld(entityitem1);

worldIn.spawnEntityInWorld(entityitem2);

return true;

}

}

return true;

}

 

Link to comment
Share on other sites

The first part should also be inside the isRemote check.

Also, what I just noticed, why in the actual fuck are you using

hitX, hitY, hitZ

as the spawn coordinates of the item entity?

 

I am not very sure if this is actually a thing (because i am a 1.8 noob) but i think that BlockPos has got a .getX(), geY(), getZ().

You already have a BlockPos instance on your method so use pos.getX(), pos.getY() and pos.getZ() instead of hitX, hitY, hitZ.

 

If this is not a thing then ignore this comment. It is me being derpy on 1.8 forge.

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.