Jump to content

[1.8.9] Minecraft is crash at render register


Minebot17

Recommended Posts

I made all correctly. I checked all, but haven't found mistakes. What could be the problem?

P.S. Sorry for the mistakes in the text. I do not know much English

Log and crash: https://gist.github.com/anonymous/1de529c7a8977fefe5ec

 

Main mode class:

 

package com.minebot.mymod;

import com.minebot.mymod.Blocks.Entropy_Planks;
import net.minecraft.block.Block;
import net.minecraft.client.Minecraft;
import net.minecraft.client.renderer.entity.RenderItem;
import net.minecraft.client.resources.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.Instance;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.event.FMLPreInitializationEvent;
import net.minecraftforge.fml.relauncher.Side;

@Mod(modid = ModInfo.MODID, name = ModInfo.NAME, version = ModInfo.VERSION)

public class MyModBase
{
    public static Block entropyPlanks;

    @Instance(value = ModInfo.MODID)
    public static MyModBase instance;

    @EventHandler
    public void preInit(FMLPreInitializationEvent event)
    {
        entropyPlanks = new Entropy_Planks();
    }

    @EventHandler
    public void init(FMLPreInitializationEvent event)
    {
        //register renders
        if(event.getSide() == Side.CLIENT)
        {
            RenderItem renderItem = Minecraft.getMinecraft().getRenderItem();

            //blocks
            renderItem.getItemModelMesher().register(Item.getItemFromBlock(entropyPlanks), 0, new ModelResourceLocation(ModInfo.MODID + ":" + ((Entropy_Planks) entropyPlanks).getName(), "inventory"));
        }
    }

}

 

 

Block:

 

package com.minebot.mymod.Blocks;

import com.minebot.mymod.ModInfo;
import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraftforge.fml.common.registry.GameRegistry;

public class Entropy_Planks extends Block{
    private final String name = "Entropy_Planks";

    public Entropy_Planks() {
        super(Material.wood);
        setUnlocalizedName(ModInfo.MODID + "_" + name);
        setCreativeTab(CreativeTabs.tabBlock);
        GameRegistry.registerBlock(this, name);
    }

    public String getName(){return name;}
}

 

 

ModInfo:

 

package com.minebot.mymod;

public class ModInfo
{
    public final static String MODID = "MyMod";
    public final static String NAME = "My Mod";
    public final static String VERSION = "1.0.0";
}

 

 

And structure:

 

 

Link to comment
Share on other sites

Your

MyModBase.init

method actually handles

FMLPreInitializationEvent

instead of

FMLInitializationEvent

, so it's being called in the preInit phase rather than init.

 

The

RenderItem

instance is only created between preInit and init, so you can't use it in preInit.

 

I highly suggest using

ModelLoader.setCustomModelResourceLocation

/

ModelLoader.setCustomMeshDefinition

instead of the

ItemModelMesher#register

overloads.

 

You should also use the sided proxy system (i.e.

@SidedProxy

) instead of checking the event's side.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

I do not know whether the right, but does not work

Main mode class:

 

package com.minebot.mymod;

import com.minebot.mymod.Blocks.Entropy_Planks;
import net.minecraft.block.Block;
import net.minecraft.client.Minecraft;
import net.minecraft.client.renderer.entity.RenderItem;
import net.minecraft.client.resources.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.Instance;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.SidedProxy;
import net.minecraftforge.fml.common.event.FMLPreInitializationEvent;
import net.minecraftforge.fml.relauncher.Side;

@Mod(modid = ModInfo.MODID, name = ModInfo.NAME, version = ModInfo.VERSION)

public class MyModBase
{
    public static Block entropyPlanks;

    @Instance(value = ModInfo.MODID)
    public static MyModBase instance;

    @SidedProxy(clientSide = "com.minebot.mymod.ClientProxy",serverSide = "com.minebot.mymod.CommonProxy")
    public static CommonProxy proxy;

    @EventHandler
    public void preInit(FMLPreInitializationEvent event)
    {
        entropyPlanks = new Entropy_Planks();
    }

    @EventHandler
    public void init(FMLPreInitializationEvent event)
    {
        proxy.renderRegisterBlock(entropyPlanks);
    }

}

 

 

Proxy:

 

package com.minebot.mymod;

import net.minecraft.block.Block;

public class CommonProxy {
    public void renderRegisterBlock(Block block){}
}

package com.minebot.mymod;

import net.minecraft.block.Block;
import net.minecraft.client.Minecraft;
import net.minecraft.client.resources.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraftforge.client.model.ModelLoader;

public class ClientProxy extends CommonProxy{
    @Override
    public void renderRegisterBlock(Block block)
    {
        Item item = new Item().getItemFromBlock(block);
        ModelLoader.setCustomModelResourceLocation(item,0,new ModelResourceLocation("MyMod:Entropy_Planks", "inventory"));
    }
}

 

 

Link to comment
Share on other sites

  • Your
    init

    method is still handling

    FMLPreInitializationEvent


  • Your
    ClientProxy#renderRegisterBlock

    method is using a hardcoded model name, so every block you register with it will use the same model.

  • You're also creating a new
    Item

    to access the static method

    Item.getItemFromBlock

    , this makes no sense.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.