recipes

[Guest]

hello,

 

i cant seem to figure out this one. so....

 

here's m code for Crafting,

public class CraftingManager {

 

  public static void MCraft() {

      addCraftingRec();

      addSmeltingRec();

}

 

  private static void addCraftingRec() {

      //shaped

GameRegistry.addShapedRecipe(new ItemStack(mitems.appleb), new Object[]{"AP ", "BN ", "  ", 'A', Items.apple, 'P', mitems.ppen, 'B', mitems.bbowl, 'N', mitems.nvud});

     

GameRegistry.addShapedRecipe(new ItemStack(mitems.pbong), new Object[]{"LP ", "BN ", "  ", 'L', PlasticBottle.pbot, 'P', mitems.ppen, 'B', mitems.bbowl, 'N', mitems.nvud});

      //shapeless

     

GameRegistry.addShapelessRecipe(new ItemStack(mitems.nvud, 9), new Object[]{" X ", 'X', mitems.mvud});

     

GameRegistry.addShapelessRecipe(new ItemStack(mitems.bbowl, 3), new Object[]{" B ", 'B', Items.iron_ingot});

      }

     

      private static void addSmeltingRec(){

        GameRegistry.addSmelting(Items.apple, new ItemStack(BakedApple.bapple), 5.0F);

       

      }

}

 

and heres how i am trying to register it.

 

CraftingManager.MCraft();

 

tried that in server, client, main, and a lot of variations.

 

what am i doing wrong here?

 

thanks

[Choonster]

What's the issue here? Is it crashing? Is it simply not showing the recipe output when you put the ingredients in the crafting grid?

[Draco18s]

crashed.

 

Ya know what's great?

Crash logs.

 

$20 says that you tried to register the crafting recipes before you initialized the items.

[Dylem]

It should be in your CommonProxy, not ServerProxy

[Draco18s]

Your items are null.

 

$20 says that you tried to register the crafting recipes before you initialized the items.

[Draco18s]

You don't need the whole

new Object[] {}

syntax, as Java's varargs feature is syntactic sugar that does it for you.

 

But you still haven't addressed what I said was wrong.  Or shown otherwise.

 

Your items are null.

 

$20 says that you tried to register the crafting recipes before you initialized the items.

[Draco18s]

Where do you call

new

, where do you call

GameRegistry.registerItem

, when do these occur relative to

MCraft()

?

[UberAffe]

For future reference put code inside of

[//Code] tags, using one / instead of two

 

I don't actually see a problem with what you have posted but you should move all your registry calls into your common proxy or client proxy, it will make it much easier to read/troubleshoot and maintain. And add the code for your proxies, we can't see when you call the registerRenders.

[UberAffe]

I just noticed that you are registering your creative tab after you try to use that tab to register your items.

 

By convention you should have something like:

public class ClientProxy extends CommonProxy {
   @Override
   public void preInit(){
      super.preInit();
      //register KeyBindings
   }

  //register renderers and other such things in the appropriate initialization method
}

public class CommonProxy {
   public void preInit(){
      //register items/blocks
   }
}

@Mod(modid = Reference.MOD_ID, name = Reference.MOD_NAME, version = Reference.VERSION)
public class MarijuanaCraft  {
   
   
   @SidedProxy(clientSide = Reference.CLIENT_PROXY_CLASS, serverSide =   Reference.SERVER_PROXY_CLASS)
    public static CommonProxy proxy;

   @EventHandler
   public void preInit(FMLPreInitializationEvent event) {
      proxy.preInit();
   }

[Draco18s]

Ok, so now I need to see the

mitems

class, because none of the code you posted lately references it.

 

GameRegistry.addShapelessRecipe(new ItemStack(mitems.nvud, 9), new Object[]{" X ", 'X', mitems.mvud});

 

See how you make an item stack from

mitems.nvud

?  Where it nvud set to a value?  It certainly isn't happening in your

Bulb

(or other item) classes, which do the instantiation and registration (which, by the way, is terrible practice).

[UberAffe]

rendering is postInit()

 

so in your client proxy you could have something like this:

@Override
public void postInit(){
   registerRenderers();
}

private void registerRenderers(){
      MarijuanaBud.registerRenders();
      Light.registerRenders();
      MarijuanaPlant.registerRenders();
      MarijuanaSeed.registerRenders();
      Bong.registerRenders();
      TrashBlock.registerRenders();
      PlasticBottle.registerRenders();
      BakedApple.registerRenders();
      Shiv.registerRenders();
      ToothBrush.registerRenders();
      PlasticPen.registerRenders();
      //it would be better still if you replace these calls with something like this
      Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(Bulb.bulb, 0, new ModelResourceLocation(Reference.MOD_ID + ":" + Bulb.bulb.getUnlocalizedName(), "inventory"));
}

 

you would use something like this in your common proxy for the creative tab:

public void preInit(){
   mCreativeTab.initializeTabs();
   MarijuanaBud.MarijuanaCraft();
   Light.MarijuanaCraft();
   MarijuanaPlant.MarijuanaCraft();
   MarijuanaSeed.MarijuanaCraft();
   Bong.MarijuanaCraft();
   TrashBlock.MarijuanaCraft();
   PlasticBottle.MarijuanaCraft();
   PlasticPen.MarijuanaCraft();
   BakedApple.MarijuanaCraft();
   Shiv.MarijuanaCraft();
   ToothBrush.MarijuanaCraft();
   // I would also suggest that you rework these so that you have something like this
   GameRegistry.registerBlock(Bulb.bulb, Bulb.bulb.getUnlocalizedName());
}

[UberAffe]

seriously

/*code/errors here*/

[//code]

maybe even all inside a spoiler tag for the long ones

 

what do you have right now on this line CraftingManager.java:243

[Draco18s]

And which line is line 243?

 

Actually I don't care.

 

GameRegistry.addShapelessRecipe(new ItemStack(Bong.bbowl, 3), new Object(), " B ", 'B', Items.iron_ingot); 

 

new Object()

?  Seriously?

[Draco18s]

243 isn't your code, I was mistaken because I found the problem. Which you did not comment on:

 

GameRegistry.addShapelessRecipe(new ItemStack(Bong.bbowl, 3), new Object(), " B ", 'B', Items.iron_ingot); 

 

new Object()

?  Seriously?

[Guest]

i believe that is what started this whole thing.

 

thanks for the help, i edited it, and (how the hell do i know. i'm going by this and videos and websites trying to my own thing), now because of all that common proxy stuff my shit wont load at all.

[UberAffe]

didn't notice this at first

at com.drmdgg.marijuanacraft.CraftingManager.MarijuanaCraft(CraftingManager.java:16)
   at com.drmdgg.marijuanacraft.proxy.ClientProxy.preInit(ClientProxy.java:42)

it looks like you are registering the recipe in your client proxy, you need to register it in common proxy

 

[Draco18s]

He's not, actually.

 

He has a CommonProxy (which registers crafting) that the server proxy extends, and the client proxy extends the server proxy.

 

(The "common" part can be wholly removed and its code added elsewhere).

 

Recipes, item instantiation, item registration all of that should happen in the main mod class.  Some tutorial recently shoved it all into the proxy for no god damn reason and its made a mess of things ever since.

[UberAffe]

Maybe he doesn't need to put in proxy but that call stack doesn't go down to common proxy, doesn't that mean that it is only registering the recipe on the physical client?

[Draco18s]

Well.  Given that the ClientProxy he posted contains an empty @Override for the PreInit method (no call to super) that code would not produce that call stack.

[Guest]

okay, so i agree, i didnt have a common proxy before, and i liked it better that way.

 

its almost working now, all my textures are back, in game, and even my creative tab is working.

 

but these damned recipes are still not working. why is it so difficult or bake a damn apple in minecraft.

 

 

[Draco18s]

Its not.  You are registering your recipes wrong.

[Guest]

public class CommonProxy {

 

public void registerRenders() {

 

}

 

 

public void preInit(FMLPreInitializationEvent e) {

mCreativeTab.initializeTabs();

MarijuanaBud.MarijuanaCraft();

Light.MarijuanaCraft();

MarijuanaPlant.MarijuanaCraft();

MarijuanaSeed.MarijuanaCraft();

Bong.MarijuanaCraft();

TrashBlock.MarijuanaCraft();

PlasticBottle.MarijuanaCraft();

PlasticPen.MarijuanaCraft();

BakedApple.MarijuanaCraft();

Shiv.MarijuanaCraft();

ToothBrush.MarijuanaCraft();

}

 

    public void init(FMLInitializationEvent e) {

 

    }

 

    public void postInit(FMLPostInitializationEvent e) {

    CraftingManager.MarijuanaCraft();

    }

 

}

 

 

then where?

[Draco18s]

Let me quote it again.

 

 

GameRegistry.addShapelessRecipe(new ItemStack(Bong.bbowl, 3), new Object(), " B ", 'B', Items.iron_ingot); 

 

new Object()

?  Seriously?

[Guest]

that tells me nothing considering ive been doing this for less than a month and this is day 3 or 4 or working on crafting recipes with a full time job and a family to take care of first.

 

explain it a little clearer, like (since you have all my code) this goes here and that goes there.

 

are you telling me to remove it/replace it/move it??? what?

[captaincleric]

that tells me nothing considering ive been doing this for less than a month and this is day 3 or 4 or working on crafting recipes with a full time job and a family to take care of first.

 

explain it a little clearer, like (since you have all my code) this goes here and that goes there.

 

are you telling me to remove it/replace it/move it??? what?

 

GameRegistry.addShapelessRecipe(new ItemStack(Bong.bbowl, 3), new Object(), " B ", 'B', Items.iron_ingot); 

 

Try this:

GameRegistry.addShapelessRecipe(new ItemStack(Bong.bbowl, 3), " B ", 'B', Items.iron_ingot);

 

Notice the removal of the new Object().