[1.7.10] Really weird TileEntity lag issue [SOLVED]

[Tetawex]

I've programmed custom furnace. It works okay in-game as long as I dont place several furnaces right next to each other. In this case fps drops from ~500 to ~100(but it feels like~20-30). I have no clue whether this issue is client or server sided. Would appreciate any help.

TileEntityFoundry: http://pastebin.com/MQKG2GkK

Foundry(block): http://pastebin.com/fjUhfkdt

ContainerFoundry: http://pastebin.com/UWq6mqWY

[Ernio]

Code please? TE, Block, renderer (if there is one).

[Tetawex]

bump

[Ernio]

Only thing I can think of is that you are changing world/block/tileEntity per tick. That is quite a lot (but still not that much).

 

This shit:

Foundry.updateBlockState(isBurning(), worldObj, xCoord, yCoord, zCoord);

Aside from fact that method itself is quite badly written (that last if for example), the calling of this method is at least lame.

 

Proper way to handle it:

At start of Tile#update() you make local boolean flag = isBurning(), then you make all your logical changes which cause at some point that isBurning() will return other value than at start of method. Then at end of method you do if(flag != isBurning()) which means something just changed - and that is when you update block in world.

 

Tho I doubt this can be that big of a problem (but knowing MC, it can) - I could guess that it happens just when block are next to each other because of light update maybe? Who knows...

 

I seriously have no clue, and yeah - clean up your code.

[Tetawex]

The fix was really simple:

In Foudry class in updateBlockState():

 

Replaced this

if (burning)
	{
		world.setBlock(x, y, z, AllBlocks.block_foundry_active);
	} 
	else
	{
		world.setBlock(x, y, z, AllBlocks.block_foundry);
	}

 

With this

if (burning&&(!(world.getBlock(x, y, z)==AllBlocks.block_foundry_active)))
	{
		world.setBlock(x, y, z, AllBlocks.block_foundry_active);
	} 
	else if(!burning&&(!(world.getBlock(x, y, z)==AllBlocks.block_foundry)))
	{
		world.setBlock(x, y, z, AllBlocks.block_foundry);
	}

 

There was a lag because on each tick the block was respawned. Now it's gone.

P.S. Thanks for help anyway

[Draco18s]

I would simplify that:

 

bool state = (world.getBlock(x, y, z)==AllBlocks.block_foundry_active)
if(state != burning) {
    //set block
}