Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.9] GUI duplication


zlotnleo
 Share

Recommended Posts

Minecraft 1.9

Forge 12.16.0.1867

 

I noticed that GUI I'm drawing is displayed twice, when in Normal or Large GUI Scale, and works correctly in Small GUI Scale only, where is is displayed only once.

Screenshots:

 

CTntulf.png

7THl0lt.png

 

 

Code:

 

 

import net.minecraft.client.Minecraft;

import net.minecraft.client.gui.Gui;

import net.minecraft.client.gui.ScaledResolution;

import net.minecraft.entity.player.EntityPlayer;

 

public class Overlay extends Gui

{

    public Overlay(Minecraft mc, EntityPlayer player)

    {

        ScaledResolution res = new ScaledResolution(mc);

        int width = res.getScaledWidth();

        int height = res.getScaledHeight();

        String playerPitch = "Pitch: "+String.format("%.2f", -player.rotationPitch);

        int strw = mc.fontRendererObj.getStringWidth("Pitch: -90.00");

        int strh = mc.fontRendererObj.FONT_HEIGHT;

 

        Gui.drawRect(width-30, height - 30 - strh, width-10, height-10, 0xC0000000);

 

        mc.fontRendererObj.drawStringWithShadow(playerPitch, width-20-strw, height - 20 - strh, 0x00FFFFFF);

    }

}

 

 

 

Also, the rectangle is not being drawn where it should be, unless I really messed up the coordinates

Link to comment
Share on other sites

Here it is:

 

 

import net.minecraft.client.Minecraft;

import net.minecraft.client.gui.Gui;

import net.minecraft.client.gui.ScaledResolution;

import net.minecraft.entity.player.EntityPlayer;

import net.minecraftforge.client.event.RenderGameOverlayEvent;

import net.minecraftforge.event.entity.player.PlayerEvent;

import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

 

public class Events

{

    public boolean isFlying = false;

    public EntityPlayer player;

 

    @SubscribeEvent

    public void playerEvent(PlayerEvent.LivingUpdateEvent event)

    {

        if(event.getEntity() instanceof EntityPlayer)

        {

            //if(((EntityPlayer)event.getEntity()).isElytraFlying())

            {

                isFlying = true;

                player = (EntityPlayer)event.getEntity();

            }

            /*else

                isFlying = false;*/

        }

    }

 

    @SubscribeEvent

    public void drawHUD(RenderGameOverlayEvent event)

    {

        if(isFlying)

            new Overlay(Minecraft.getMinecraft(), player);

    }

}

 

 

Link to comment
Share on other sites

Oh dang, dude.

 

Okay, so:

 

1.1. It's non-optimal (pointless) to make 'new' objects when you don't need that.

* Make static field and make 'Overlay(Minecraft.getMinecraft(), player);' once.

 

1.2. I am not saying anything (but I am), but the constructor (and whole design) is pointless.

*Just make static method or in-event code that will get player and mc from Minecraft#thePlayer and Minecraft.getMinecraft().

 

2. Actual problem:

2.1. RenderGameOverlayEvent has TWO sub-events. Pre and Post (look into class).

* You need to use one event, preferably Post.

2.2. In RenderGameOverlayEvent there is event.type.

* Pick one EventType, otherwise code is called multiple times (about 15). I suggest using 'ALL'.

 

Why do you get multiple renders:

You should alredy come up with that reading 1 and 2. You are making new Overaly that renders stuff multiple times per frame.

1.7.10 is no longer supported by forge, you are on your own.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Could you explain what you mean by that, just to clarify I am trying to create a recipe type that handles potions and I'm pretty sure the standard recipe type cannot handle nbt data within the recipe. Do you mean use minecraft:crafting_shapeless as the type in the json file or am I misinterpreting 
    • Use the same recipe type as the crafting table. The recipe and serializer is the only thing that needs to be unique.
    • I have a custom recipe type that has successfully registered into minecraft, however I am trying to get it to work on the standard crafting table as it doesn't need a custom table for it.   { "type": "randomfhings:potion_edible", "ingredients": [ { "item" : "minecraft:glass", "data": "" }, { "item" : "minecraft:diamond" } ], "output": { "item": "randomfhings:ruby", "count": 3 } } This is a test recipe so far . package org.multicoder.randomfhings.recipe; import com.google.gson.JsonArray; import com.google.gson.JsonObject; import net.minecraft.core.NonNullList; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.resources.ResourceLocation; import net.minecraft.util.GsonHelper; import net.minecraft.world.inventory.CraftingContainer; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.crafting.*; import net.minecraft.world.level.Level; import org.multicoder.randomfhings.RandomFhings; import javax.annotation.Nullable; public class PotionRecipe implements Recipe<CraftingContainer> { private final ResourceLocation id; private final ItemStack output; private final NonNullList<Ingredient> input; public PotionRecipe(ResourceLocation id, ItemStack output, NonNullList<Ingredient> input) { this.id = id; this.output = output; this.input = input; } @Override public NonNullList<Ingredient> getIngredients() { return input; } @Override public boolean matches(CraftingContainer p_44002_, Level p_44003_) { return input.get(0).test(p_44002_.getItem(0)); } @Override public ItemStack assemble(CraftingContainer p_44001_) { return output.copy(); } @Override public boolean canCraftInDimensions(int p_43999_, int p_44000_) { return true; } @Override public ItemStack getResultItem() { return output; } @Override public ResourceLocation getId() { return id; } @Override public RecipeSerializer<?> getSerializer() { return Serializer.INSTANCE; } @Override public RecipeType<?> getType() { return Type.INSTANCE; } public static class Type implements RecipeType<PotionRecipe> { private Type() { } public static final Type INSTANCE = new Type(); public static final String ID = "potion_edible"; } public static class Serializer implements RecipeSerializer<PotionRecipe> { public static final Serializer INSTANCE = new Serializer(); public static final ResourceLocation ID = new ResourceLocation(RandomFhings.MOD_ID,"potion_edible"); @Override public PotionRecipe fromJson(ResourceLocation id, JsonObject json) { ItemStack output = ShapedRecipe.itemStackFromJson(GsonHelper.getAsJsonObject(json, "output")); JsonArray ingredients = GsonHelper.getAsJsonArray(json, "ingredients"); NonNullList<Ingredient> inputs = NonNullList.withSize(2, Ingredient.EMPTY); for (int i = 0; i < inputs.size(); i++) { inputs.set(i, Ingredient.fromJson(ingredients.get(i))); } return new PotionRecipe(id, output, inputs); } @Override public PotionRecipe fromNetwork(ResourceLocation id, FriendlyByteBuf buf) { NonNullList<Ingredient> inputs = NonNullList.withSize(buf.readInt(), Ingredient.EMPTY); for (int i = 0; i < inputs.size(); i++) { inputs.set(i, Ingredient.fromNetwork(buf)); } ItemStack output = buf.readItem(); return new PotionRecipe(id, output, inputs); } @Override public void toNetwork(FriendlyByteBuf buf, PotionRecipe recipe) { buf.writeInt(recipe.getIngredients().size()); for (Ingredient ing : recipe.getIngredients()) { ing.toNetwork(buf); } buf.writeItemStack(recipe.getResultItem(), false); } @Override public RecipeSerializer<?> setRegistryName(ResourceLocation name) { return INSTANCE; } @Nullable @Override public ResourceLocation getRegistryName() { return ID; } @Override public Class<RecipeSerializer<?>> getRegistryType() { return Serializer.castClass(RecipeSerializer.class); } @SuppressWarnings("unchecked") // Need this wrapper, because generics private static <G> Class<G> castClass(Class<?> cls) { return (Class<G>)cls; } } } This is my recipe type class and it is registered via a deferred register.
    • The version you are using is no longer supported on this forum. Please update to a modern version of Minecraft to receive support. Currently supported versions are 1.19.2 (Latest) and 1.18.2 (LTS).
    • The version you are using is no longer supported on this forum. Please update to a modern version of Minecraft to receive support. Currently supported versions are 1.19.2 (Latest) and 1.18.2 (LTS).
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.