[1.9]Liquid Surface Does not Render Underwater.

[Alexthe666]

Hello. I have a block that mimics water in 1.9. It looks like this:

 

 

 

 

 

Everything about it works just fine. However, normal water renders it's surface when under it.

 

 

 

 

 

However, mine does not do that.

 

 

 

 

 

Here is my code for the water block:

 

 

 

package com.github.alexthe666.archipelago.block;

import net.minecraft.block.material.Material;
import net.minecraft.block.state.IBlockState;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.math.AxisAlignedBB;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.IBlockAccess;
import net.minecraftforge.fluids.BlockFluidClassic;
import net.minecraftforge.fluids.Fluid;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class BlockTropicalWater extends BlockFluidClassic{

public BlockTropicalWater(Fluid fluid, Material material) {
	super(fluid, material);
}


    @SideOnly(Side.CLIENT)
    public boolean shouldSideBeRendered(IBlockState blockState, IBlockAccess blockAccess, BlockPos pos, EnumFacing side)
    {
    	 IBlockState neighbor = blockAccess.getBlockState(pos.offset(side));
         if (neighbor.getMaterial() == blockState.getMaterial()){
             return false;
         }else{
             return side == EnumFacing.UP ? true : super.shouldSideBeRendered(blockState, blockAccess, pos, side);
         }
    }
}

 

 

 

Here is it's blockstate file:

 

 

{
    "forge_marker": 1,
    "variants": {
        "fluid": {
            "model": "forge:fluid",
            "custom": { "fluid": "tropical_water" }
        }
    }
}

 

 

 

I already have my suspicions that this is cause by Forge Fluids not using BlockFluidRender.java, but I'm insure how to make the surface render using the blockstate format.

[Draco18s]

I'd kinda like to see more of your liquid from below.  When I had this problem in 1.7 I took a screenshot from a position where it was flowing and you could see some of the side/top faces and the missing underside faces.

 

Your last screenshot is really hard to to tell WTF I'm looking at.

[Alexthe666]

 

Screenshots of the same area.

[Draco18s]

Ah, those are clouds, got it.

 

Anyway, you're probably going to end up having to modify the renderer yourself.  When I had this problem in 1.7.10 I complained to Lex and he was like "No one uses it anyway." Ended up writing a Pull Request for it and it got merged.  I see that its gone and gotten lost again.