[1.9.4] Problem playing sound when player dies

[American2050]

I'm having problems playing a sound when the player dies.

 

The sound is registered correctly, the event is registered correctly and getting fired, but for some reason, the sound wont play.

 

I'm not sure what the problem could be here.

 

	@SubscribeEvent
  public void onPlayerDie(PlayerDropsEvent event) {

	World world = event.getEntity().getEntityWorld();
	EntityPlayer player = event.getEntityPlayer();
	BlockPos pos = player.getPosition();

	world.playSound(player, pos, ModSounds.PLAYER_DEAD, SoundCategory.BLOCKS, 1.0F, 1.0F);


}

 

I tried the sound firing in on other events and it works ok, but inside the PlayerDropsEvent it wont do anything.

 

PS: Also tried this, with no success

 

	@SubscribeEvent
  public void onPlayerDie(LivingDeathEvent event) {

	Entity entity = event.getEntity();

	if(entity instanceof EntityPlayer){			

		World world = event.getEntity().getEntityWorld();
		BlockPos pos = entity.getPosition();

	world.playSound((EntityPlayer)entity, pos, ModSounds.PLAYER_DEAD, SoundCategory.BLOCKS, 1.0F, 1.0F);

	}


}

[diesieben07]

For a start

PlayerDropsEvent

is not the correct way to detect player death, using

LivingDeathEvent

like you already tried.

 

As for your error: As you can read in the documentation the playSound method you are using will on the server only play the sound to every player BUT the player passed in. On the client it will just play it normally. But since LivingDeathEvent does not fire for the player on the client (it might fire for other players clientside, I am not sure about this) the client will never play the sound. Instead pass

null

for the player.

[American2050]

Thanks a lot man, it's working perfectly now.

 

Now my question is... Why it's wrong to track when a player dies using the PlayerDropsEvent?

 

Isn't it better to subscribe to an event that will triggers only when a player dies, and not use LivingDeathEvent that gets triggered every time something dies in the game?

 

In my head it makes sense using PlayerDropsEvent better over LivingDeathEvent but dunno...

[diesieben07]

Now my question is... Why it's wrong to track when a player dies using the PlayerDropsEvent?

Because PlayerDropsEvent fires when a player drops their items. Yes, currently that is only on death, but you should still only use an event for what it's made for.