Brewing Recipe Help [1.10.2]

[minh2908]

My system works fine but i can brew a resistance potion with a resistance potion. Any help?

Here is the class that extends IBrewingRecipe:

 

public class PotionRecipe implements IBrewingRecipe{

 

private ItemStack input;

private ItemStack ingredient;

private ItemStack output;

 

public PotionRecipe(ItemStack input, ItemStack ingredient, ItemStack output) {

this.input = input;

this.ingredient = ingredient;

this.output = output;

}

 

@Override

public boolean isInput(ItemStack input2) {

if(!input2.hasTagCompound())

return false;

return PotionUtils.getPotionFromItem(input2)==PotionUtils.getPotionFromItem(this.input);

}

 

@Override

public boolean isIngredient(ItemStack ingredient2) {

return ingredient2.getItem()==Items.REDSTONE  || ingredient2.getItem()==Items.GLOWSTONE_DUST || ingredient2.getItem()==Items.IRON_INGOT||ingredient2.getItem()==Items.FERMENTED_SPIDER_EYE;

}

 

@Override

public ItemStack getOutput(ItemStack input2, ItemStack ingredient2) {

 

if(ingredient2 != null && input2 != null && isIngredient(ingredient2))  {

ItemStack output2 = this.output.copy();

if (input2 != output2)

{

return output2;

}

return null;

}

else

return null;

}

 

}

 

How I register the recipes:

 

public void postInit(FMLPostInitializationEvent event)

  {BrewingRecipeRegistry.addRecipe(new PotionRecipe(PotionUtils.addPotionToItemStack(new ItemStack(Items.POTIONITEM,1), CustomPotionTypes.resistance), new ItemStack(Items.FERMENTED_SPIDER_EYE,1), PotionUtils.addPotionToItemStack(new ItemStack(Items.POTIONITEM,1), CustomPotionTypes.weakening)));

    BrewingRecipeRegistry.addRecipe(new PotionRecipe(PotionUtils.addPotionToItemStack(new ItemStack(Items.POTIONITEM,1), PotionTypes.AWKWARD), new ItemStack(Items.IRON_INGOT,1), PotionUtils.addPotionToItemStack(new ItemStack(Items.POTIONITEM,1), CustomPotionTypes.resistance)));

 

    }

 

[Animefan8888]

Why not use

BrewingRecipeRegistry.addRecipe(input, ingredient, output);

[minh2908]

It doesn't differentiate between different potions

[Animefan8888]

In get output you never check if input2 is input. And honestly forge why would you just check to see if the item is the same when you should be comparing ItemStacks.....

[Animefan8888]

Note these edits work for me.

 

           // This
   @Override
   public boolean isInput(ItemStack input2) {
      if(!input2.hasTagCompound())
         return false;
      return PotionType.getPotionTypeForName(input2.getTagCompound().getString("Potion")) == PotionType.getPotionTypeForName(input.getTagCompound().getString("Potion"));
   }
           // And this
   @Override
   public ItemStack getOutput(ItemStack input2, ItemStack ingredient2) {
	   if(ingredient2 != null && input2 != null && isIngredient(ingredient2))  {
		   ItemStack output2 = this.output.copy();
		   if (input2 != output2 && isInput(input2)) {
			   return output2;
		   } return null;
	   }  else
		   return null;
   }

 

[minh2908]

That doesn't seems to solve the problem. I'm pretty sure that the check that you edit didn't change anything.The isInput was my fault ,though . The problem with the system is that even though iron ingot brew the resistance one and fermented spider eye brews the resistance potion to the weakening one, the iron ingot still brew the resistance potion to itself.

[Animefan8888]

May I see the code you used to register the potions?

[minh2908]

I assume you mean the potiontypes:

 

public class CustomPotionTypes {

public static PotionType resistance;

public static PotionType weakening;

public static void init(){

resistance= GameRegistry.register(new PotionType(new PotionEffect(MobEffects.RESISTANCE, 1800)).setRegistryName("resistance"));

weakening= GameRegistry.register(new PotionType(new PotionEffect(CustomPotion.weakening, 1800)).setRegistryName("weakening"));

}}

 

In the Mod file:

public void preInit(FMLPreInitializationEvent event)

    {

    CustomPotionTypes.init();

   

            }

 

 

[Animefan8888]

Could you post your updated code for PotionRecipes?

[minh2908]

 

package minh2908.ores.init.potion;

 

import net.minecraft.init.Items;

import net.minecraft.item.ItemStack;

import net.minecraft.potion.PotionType;

import net.minecraftforge.common.brewing.IBrewingRecipe;

 

public class PotionRecipe implements IBrewingRecipe{

 

private ItemStack input;

private ItemStack ingredient;

private ItemStack output;

 

public PotionRecipe(ItemStack input, ItemStack ingredient, ItemStack output) {

this.input = input;

this.ingredient = ingredient;

this.output = output;

}

 

@Override

public boolean isInput(ItemStack input2) {

if(!input2.hasTagCompound())

return false;

return PotionType.getPotionTypeForName(input2.getTagCompound().getString("Potion")) == PotionType.getPotionTypeForName(input.getTagCompound().getString("Potion"));

  }

 

@Override

public boolean isIngredient(ItemStack ingredient2) {

return ingredient2.getItem()==Items.REDSTONE  || ingredient2.getItem()==Items.GLOWSTONE_DUST || ingredient2.getItem()==Items.IRON_INGOT||ingredient2.getItem()==Items.FERMENTED_SPIDER_EYE;

}

 

@Override

public ItemStack getOutput(ItemStack input2, ItemStack ingredient2) {

 

if(ingredient2 != null && input2 != null && isIngredient(ingredient2))  {

ItemStack output2 = this.output.copy();

if (input2 != output2 && isInput(input2))

{

return output2;

}

return null;

}

else

return null;

}

 

}

 

[Animefan8888]

May I see your entire Main Class?

[minh2908]

I've found the solution! Turns out the ingredient check was defective . Thanks for your help, though, especially on reminding me of the ingredient check.

[Animefan8888]

Post the change here please for future people that have this problem.