MCrafterzz Posted August 5, 2016 Share Posted August 5, 2016 I want players to teleport to there spawn point this is the code I've use (it crashes with a null Point exception): @Override public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) { if (entityIn instanceof EntityLivingBase) { EntityPlayer player = (EntityPlayer) entityIn; entityIn.setPosition(player.getBedSpawnLocation(worldIn, player.getBedLocation(), false).getX(), player.getBedSpawnLocation(worldIn, player.getBedLocation(), false).getY(), player.getBedSpawnLocation(worldIn, player.getBedLocation(), false).getZ()); entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f); worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(), entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0); } } Quote http://i.imgur.com/J4rrGt6.png[/img] [Creator of mcrafterzz mod] Link to comment Share on other sites More sharing options...
Animefan8888 Posted August 5, 2016 Share Posted August 5, 2016 You create an instance of EntityPlayer, but you check if the Entity is an instanceof EntityLivingBase... Quote VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect. Forge and vanilla BlockState generator. Link to comment Share on other sites More sharing options...
MCrafterzz Posted August 5, 2016 Author Share Posted August 5, 2016 Updated code: @Override public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) { if (entityIn instanceof EntityLivingBase) { if (entityIn instanceof EntityPlayer) { EntityPlayer player = (EntityPlayer) entityIn; BlockPos spawnPosition = player.getBedLocation(); entityIn.setPosition(spawnPosition.getX(), spawnPosition.getY(), spawnPosition.getZ()); entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f); worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(), entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0); } else { entityIn.setPosition(worldIn.getSpawnPoint().getX(), worldIn.getSpawnPoint().getY(), worldIn.getSpawnPoint().getZ()); } } } Quote http://i.imgur.com/J4rrGt6.png[/img] [Creator of mcrafterzz mod] Link to comment Share on other sites More sharing options...
Ernio Posted August 5, 2016 Share Posted August 5, 2016 You create an instance of EntityPlayer, but you check if the Entity is an instanceof EntityLivingBase... While this is true it wouldn't produce NPE, but CCE. Question is - what is null there? My bet is on #getBedSpawnLocation. Also - this method might be called on both sides - it is worth checking that and place proper server side-check if that is a case (maybe its null on client and present on server and client is crashing?). If you can't figure it out - please say at which line it crashes. Quote 1.7.10 is no longer supported by forge, you are on your own. Link to comment Share on other sites More sharing options...
MCrafterzz Posted August 5, 2016 Author Share Posted August 5, 2016 With the updated code that I just posted it no longer crashes. It teleports to a location that I think is right(?) for a fraction of a seconds but then it teleports back Quote http://i.imgur.com/J4rrGt6.png[/img] [Creator of mcrafterzz mod] Link to comment Share on other sites More sharing options...
MCrafterzz Posted August 5, 2016 Author Share Posted August 5, 2016 Changed to: @Override @SideOnly(Side.SERVER) public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) { if (entityIn instanceof EntityLivingBase) { if (entityIn instanceof EntityPlayer) { EntityPlayer player = (EntityPlayer) entityIn; BlockPos spawnPosition = player.getBedLocation(); entityIn.setPosition(spawnPosition.getX(), spawnPosition.getY(), spawnPosition.getZ()); entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f); worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(), entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0); } else { entityIn.setPosition(worldIn.getSpawnPoint().getX(), worldIn.getSpawnPoint().getY(), worldIn.getSpawnPoint().getZ()); } } } Quote http://i.imgur.com/J4rrGt6.png[/img] [Creator of mcrafterzz mod] Link to comment Share on other sites More sharing options...
Animefan8888 Posted August 5, 2016 Share Posted August 5, 2016 Don't use ASideOnly(SIde.SERVER) use !world.isRemote Quote VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect. Forge and vanilla BlockState generator. Link to comment Share on other sites More sharing options...
MCrafterzz Posted August 5, 2016 Author Share Posted August 5, 2016 Done, I will now take a look at the teleport command Quote http://i.imgur.com/J4rrGt6.png[/img] [Creator of mcrafterzz mod] Link to comment Share on other sites More sharing options...
MCrafterzz Posted August 5, 2016 Author Share Posted August 5, 2016 I guess this is the code that I need to look at: http://pastebin.com/ySKJqdyV But nearly nothing have real names so it's hard to understand what it's accually doing Quote http://i.imgur.com/J4rrGt6.png[/img] [Creator of mcrafterzz mod] Link to comment Share on other sites More sharing options...
MCrafterzz Posted August 5, 2016 Author Share Posted August 5, 2016 Why can't I use: entityIn.setPosition Why does it even excist if it doesn't work? Quote http://i.imgur.com/J4rrGt6.png[/img] [Creator of mcrafterzz mod] Link to comment Share on other sites More sharing options...
Animefan8888 Posted August 5, 2016 Share Posted August 5, 2016 Why not to use @SideOnly Sides in Minecraft check CommandTeleport for how to properly teleport things. What if this code is going to be run in a SinglePlayer world wouldn't it crash because the method doesn't exist Quote VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect. Forge and vanilla BlockState generator. Link to comment Share on other sites More sharing options...
Animefan8888 Posted August 5, 2016 Share Posted August 5, 2016 Are you talking about in the case of @SideOnly ? If so: no, because the method is never directly referred to, Minecraft only refers to the overridden method (the one in Block). It would simply not work in SinglePlayer. If not: Please clarify. Well you were correct so it won't crash, but it won't work. That just changes the reason to not use it. Unless the OP wants it to only work on a dedicated server. Quote VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect. Forge and vanilla BlockState generator. Link to comment Share on other sites More sharing options...
MCrafterzz Posted August 5, 2016 Author Share Posted August 5, 2016 So how should I do it then? Quote http://i.imgur.com/J4rrGt6.png[/img] [Creator of mcrafterzz mod] Link to comment Share on other sites More sharing options...
MCrafterzz Posted August 5, 2016 Author Share Posted August 5, 2016 This is how the codes looks like now: @Override public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) { if (!worldIn.isRemote) { if (entityIn instanceof EntityLivingBase) { if (entityIn instanceof EntityPlayer) { EntityPlayer player = (EntityPlayer) entityIn; BlockPos spawnPosition = player.getBedLocation(); entityIn.setPosition(spawnPosition.getX(), spawnPosition.getY(), spawnPosition.getZ()); entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f); worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(), entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0); } else { entityIn.setPosition(worldIn.getSpawnPoint().getX(), worldIn.getSpawnPoint().getY(), worldIn.getSpawnPoint().getZ()); entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f); worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(), entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0); } } } } Quote http://i.imgur.com/J4rrGt6.png[/img] [Creator of mcrafterzz mod] Link to comment Share on other sites More sharing options...
Animefan8888 Posted August 5, 2016 Share Posted August 5, 2016 Yes, @SideOnly should not be used (unless you really know what you are doing). Which is why I linked both an article called "Why not to use @SideOnly " and a tutorial about the concept of sides in Minecraft. Yes I understood what they do, but once I get some sleep and my brain is working "better" than it is currently I will read all of what you posted to understand it better. Thank you again diesieben. This is how the codes looks like now: @Override public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) { if (!worldIn.isRemote) { if (entityIn instanceof EntityLivingBase) { if (entityIn instanceof EntityPlayer) { EntityPlayer player = (EntityPlayer) entityIn; BlockPos spawnPosition = player.getBedLocation(); entityIn.setPosition(spawnPosition.getX(), spawnPosition.getY(), spawnPosition.getZ()); entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f); worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(), entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0); } else { entityIn.setPosition(worldIn.getSpawnPoint().getX(), worldIn.getSpawnPoint().getY(), worldIn.getSpawnPoint().getZ()); entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f); worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(), entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0); } } } } Can I assume it is still not working? Also if your code for the TeleportCommand is not "readable" then you should update forge to its most recent version and see if it is readable then. Quote VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect. Forge and vanilla BlockState generator. Link to comment Share on other sites More sharing options...
MCrafterzz Posted August 5, 2016 Author Share Posted August 5, 2016 Still looks the same with the latest forge version, http://www.minecraftforge.net/forum/Smileys/default/sad.gif Quote http://i.imgur.com/J4rrGt6.png[/img] [Creator of mcrafterzz mod] Link to comment Share on other sites More sharing options...
MCrafterzz Posted August 6, 2016 Author Share Posted August 6, 2016 I have removed one of the instanceof checks: @Override public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) { if (!worldIn.isRemote) { if (entityIn instanceof EntityPlayer) { EntityPlayer player = (EntityPlayer) entityIn; BlockPos spawnPosition = player.getBedLocation(); entityIn.setPosition(spawnPosition.getX(), spawnPosition.getY(), spawnPosition.getZ()); entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f); worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(), entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0); } else { entityIn.setPosition(worldIn.getSpawnPoint().getX(), worldIn.getSpawnPoint().getY(), worldIn.getSpawnPoint().getZ()); entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f); worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(), entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0); } } } But I still don't know how to use the commandteleport code Quote http://i.imgur.com/J4rrGt6.png[/img] [Creator of mcrafterzz mod] Link to comment Share on other sites More sharing options...
Animefan8888 Posted August 6, 2016 Share Posted August 6, 2016 So what is happening when this code is triggered? Quote VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect. Forge and vanilla BlockState generator. Link to comment Share on other sites More sharing options...
MCrafterzz Posted August 6, 2016 Author Share Posted August 6, 2016 It crashes because of a null point exception. Crash: http://pastebin.com/H05XxPqj Quote http://i.imgur.com/J4rrGt6.png[/img] [Creator of mcrafterzz mod] Link to comment Share on other sites More sharing options...
Animefan8888 Posted August 6, 2016 Share Posted August 6, 2016 Could you post your whole block class or tell me what line 32 is in that class. Quote VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect. Forge and vanilla BlockState generator. Link to comment Share on other sites More sharing options...
MCrafterzz Posted August 6, 2016 Author Share Posted August 6, 2016 Changed it to this: @Override public void onEntityCollidedWithBlock(World worldIn, BlockPos pos, IBlockState state, Entity entityIn) { if (!worldIn.isRemote) { if (entityIn instanceof EntityPlayer) { EntityPlayer player = (EntityPlayer) entityIn; BlockPos spawnPosition = player.getBedLocation(); ((EntityPlayerMP) entityIn).connection.setPlayerLocation(spawnPosition.getX(), spawnPosition.getY(), spawnPosition.getZ(), player.getRotationYawHead(), player.getRotationYawHead()); entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f); worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(), entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0); } else { ((EntityPlayerMP) entityIn).connection.setPlayerLocation(worldIn.getSpawnPoint().getX(), worldIn.getSpawnPoint().getY(), worldIn.getSpawnPoint().getZ(), entityIn.getRotationYawHead(), entityIn.getRotationYawHead()); entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f); worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(), entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0); } } } Testing now Quote http://i.imgur.com/J4rrGt6.png[/img] [Creator of mcrafterzz mod] Link to comment Share on other sites More sharing options...
MCrafterzz Posted August 6, 2016 Author Share Posted August 6, 2016 New error: http://pastebin.com/TTrPzcdC Line 39(errored line): ((EntityPlayerMP) entityIn).connection.setPlayerLocation(worldIn.getSpawnPoint().getX(), worldIn.getSpawnPoint().getY(), worldIn.getSpawnPoint().getZ(), entityIn.getRotationYawHead(), entityIn.getRotationYawHead()); Quote http://i.imgur.com/J4rrGt6.png[/img] [Creator of mcrafterzz mod] Link to comment Share on other sites More sharing options...
Animefan8888 Posted August 6, 2016 Share Posted August 6, 2016 Why are you casting the entity to an EntityPlayer if it is not an instanceof EntityPlayer ((EntityPlayerMP) entityIn).connection.setPlayerLocation(worldIn.getSpawnPoint().getX(), worldIn.getSpawnPoint().getY(), worldIn.getSpawnPoint().getZ(), entityIn.getRotationYawHead(), entityIn.getRotationYawHead()); entityIn.playSound(SoundEvents.ENTITY_ENDERPEARL_THROW, 0.5f, 0.5f); worldIn.spawnParticle(EnumParticleTypes.PORTAL, entityIn.getPosition().getX(), entityIn.getPosition().getY(), entityIn.getPosition().getZ(), 0, 0, 10, 0); } Quote VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect. Forge and vanilla BlockState generator. Link to comment Share on other sites More sharing options...
MCrafterzz Posted August 6, 2016 Author Share Posted August 6, 2016 Because that's how the teleport command works. I still don't know how I should teleport things. I want players to teleport to there spawn point(in the same dimension) and item and other entities to teleport to the worlds spawn (in the same dimension) Quote http://i.imgur.com/J4rrGt6.png[/img] [Creator of mcrafterzz mod] Link to comment Share on other sites More sharing options...
Animefan8888 Posted August 6, 2016 Share Posted August 6, 2016 So the way you have it set for the player will work however as far as I can tell onEntityCollidedWithBlock doesn't get called for Item Entities. Quote VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect. Forge and vanilla BlockState generator. Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.