Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[SOLVED] [1.8.9] Issues with my Container


Nxs0000
 Share

Recommended Posts

Hey,

 

I recently stared working on a TileEntity vitrine that display an item/itemBlock on it when it does contain one.

Basically the TileEntity contains 2 properties:

        
private ItemStack contained;
private EntityItem image;

the "image" is created from the "contained" with the it's property stackSize set to 1.

 

Now i wanted to add a Gui that would allow me to change the contained easily, so i created both the GuiContainer class and the Container one (and registered in the GuiHandler class)

To do all that i just followed bedrockminer's tutorials, changing what needed to be changed, but now i have some wierd issues: (all tested in a single player world)

- when i open the Container, the first Item in my Hotbar gets change into the item that is contained in the TileEntity, even though the item is still in it and clicking on the item in the contained slot take the one in my hotbar.

- when i close the Gui, this first item don't gets back to what it was before openning, and, when i open my inventory (in survival) i can see that some on the items from my hotbar got copied to the armor slots and crafting slots.

- I have to relog to get my inventory back right, as before i even openned the Container.

 

Here is my VitrineContainer construtor. The class is extending Container, have a property theVitr where I store the VitrineTileEntity.

public VitrineContainer(VitrineTileEntity vitr, IInventory player) {

	this.theVitr = vitr;
        	theVitr.openInventory(((InventoryPlayer)player).player);

                //Player  inventory
	for(int x = 0; x<9; x++){
		this.addSlotToContainer(new Slot(player, x, 8+x*18, 49+58));
	}

	for(int y = 0; y<3; y++){
		for(int x = 0; x<9; x++){
			this.addSlotToContainer(new Slot(player, 9+x+y*9, 8+x*18, 49 +18*y));
		}
	}

	this.addSlotToContainer(new Slot(vitr, 0, 8, 18)); // TileEntity's slot, top left of the Gui
}

 

I don't think the error could come from other classes since I barely created the Gui class just to draw a 1-row chest, and my VitrineBlock and VitrineTileEntity work fine and don't have much to do with the Container, exept for the TileEntity that extends IInventory so I completed the newly genereted methods to return the correct objects (slot 0 returning the contained ItemStack).

 

Maybe it only is an issue of synchronizing Server and Client since reloging correct the Inventory mess.

 

Before: 1470836268-2016-08-10-15-06-02.png

Open the Container: 1470836271-2016-08-10-15-06-06.png

Clicking on the contained Item: 1470836275-2016-08-10-15-07-54.png

Opening the inventory after closing the Container: 1470836273-2016-08-10-15-06-16.png

 

What is/could be wrong ? Thank you for any help

Link to comment
Share on other sites

I dont know if that is the problem, but I would recommend you to add the slots in this order:

1. Slot(s) of the TileEntity

2. Player Inventory

3. Player Hotbar

Since the Container uses a List of Slots it may be the problem

 

Also, what does

theVitr.openInventory

do?

Link to comment
Share on other sites

the openInventory call a method from the TileEntity that needed to be override, for now i left it empty.

 

I tried what you said:

Before: 1470841336-2016-08-10-16-55-47.png

After: 1470841338-2016-08-10-16-56-08.png

 

This really is weird: The inventory looks messed up but the item are just showed in the wrong place: for exemple, when i click on the second slot from the first row i get the 59 blaze powder... Plus, even so the slot for the Container displays the wool, clicking on it does nothing.

It seem to be a display issue now

Link to comment
Share on other sites

yea, it seems

 

I open the Cotainer by right-clicking on the Vitrine Block, then using this in "onBlockActivated"

if (!worldIn.isRemote) {
      playerIn.openGui(Main.instance, GuiHandler.getID(15), worldIn, pos.getX(), pos.getY(), pos.getZ()); //15 correspond to my Vitrine
}

 

GuiHandler

@Override
public Object getServerGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {
	if(ID == 15)
		return new VitrineContainer((VitrineTileEntity) world.getTileEntity(new BlockPos(x,y,z)) , player.inventory);
    return null;
}

@Override
public Object getClientGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {
    if(ID == 15)
    	return new GuiVitrine((VitrineTileEntity) world.getTileEntity(new BlockPos(x,y,z)) , player.inventory);
    return null;
}

 

Link to comment
Share on other sites

that could be the drawScreen, that doesn't display the item right since it doesn't understand my slots? Since i left if that way :

@Override
public void drawScreen(int mouseX, int mouseY, float partialTicks)
{
    super.drawScreen(mouseX, mouseY, partialTicks);
}

Link to comment
Share on other sites

ok... fml... I'm dumb

Thanks for the help guys! i juste messed up from the start >.<

 

The real issue was that I did @Override the initGui() to add my stuff and forgot to call the super back...

This caused the inventory to appear weird, which i tried to correct by changing the order in which the slots are registered.

 

Thanks for your time everyone,

Have a nice day !

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • How can I create a crop block that is 2 blocks tall? I already have the basic crop code, now I only need to make the crop 2 blocks tall. Any help would be greatly appreciated.
    • Im trying to make an Pixelmon Addon, but it doesn't compile, throws errors. There are no errors in the code and I have all Dependencies jar inside of my Project Structure scoped "Compile". I'm using IntelliJ IDEA 2018.2.1 I get this: error: package com.pixelmonmod.pixelmon.api.events does not exist import com.pixelmonmod.pixelmon.api.events.AggressionEvent; ^ 23 errors :compileJava FAILED   Here is my build.gradle buildscript { repositories { // These repositories are only for Gradle plugins, put any other repositories in the repository block further below maven { url = 'https://maven.minecraftforge.net' } mavenCentral() } dependencies { classpath group: 'net.minecraftforge.gradle', name: 'ForgeGradle', version: '5.1.+', changing: true } } apply plugin: 'net.minecraftforge.gradle' group = 'PixelmonEvents' version = '1.0-SNAPSHOT' java { archivesBaseName = 'PixelmonEvents' toolchain.languageVersion = JavaLanguageVersion.of(8) } minecraft { // The mappings can be changed at any time and must be in the following format. // Channel: Version: // snapshot YYYYMMDD Snapshot are built nightly. // stable # Stables are built at the discretion of the MCP team. // official MCVersion Official field/method names from Mojang mapping files // // You must be aware of the Mojang license when using the 'official' mappings. // See more information here: https://github.com/MinecraftForge/MCPConfig/blob/master/Mojang.md // // Use non-default mappings at your own risk. They may not always work. // Simply re-run your setup task after changing the mappings to update your workspace. mappings channel: 'stable', version: '39-1.12' // accessTransformer = file('src/main/resources/META-INF/accesstransformer.cfg') // Default run configurations. // These can be tweaked, removed, or duplicated as needed. runs { client { workingDirectory project.file('run') // Recommended logging data for a userdev environment // The markers can be added/removed as needed separated by commas. // "SCAN": For mods scan. // "REGISTRIES": For firing of registry events. // "REGISTRYDUMP": For getting the contents of all registries. property 'forge.logging.markers', 'REGISTRIES' // Recommended logging level for the console // You can set various levels here. // Please read: https://stackoverflow.com/questions/2031163/when-to-use-the-different-log-levels property 'forge.logging.console.level', 'debug' mods { pixelmonevents { source sourceSets.main } } } server { workingDirectory project.file('run') // Recommended logging data for a userdev environment // The markers can be added/removed as needed separated by commas. // "SCAN": For mods scan. // "REGISTRIES": For firing of registry events. // "REGISTRYDUMP": For getting the contents of all registries. property 'forge.logging.markers', 'REGISTRIES' // Recommended logging level for the console // You can set various levels here. // Please read: https://stackoverflow.com/questions/2031163/when-to-use-the-different-log-levels property 'forge.logging.console.level', 'debug' mods { pixelmonevents { source sourceSets.main } } } } } // Include resources generated by data generators. sourceSets.main.resources { srcDir 'src/generated/resources' } //repositories { // Put repositories for dependencies here // ForgeGradle automatically adds the Forge maven and Maven Central for you // If you have mod jar dependencies in ./libs, you can declare them as a repository like so: //flatDir { //dir 'libs' //} //} dependencies { // Specify the version of Minecraft to use. If this is any group other than 'net.minecraft' it is assumed // that the dep is a ForgeGradle 'patcher' dependency, and its patches will be applied. // The userdev artifact is a special name and will get all sorts of transformations applied to it. minecraft 'net.minecraftforge:forge:1.12.2-14.23.5.2860' compile files('libs/Pixelmon-1.12.2-8.3.6-universal.jar', 'Magma.jar', 'Skript.jar') // Real mod deobf dependency examples - these get remapped to your current mappings // compileOnly fg.deobf("mezz.jei:jei-${mc_version}:${jei_version}:api") // Adds JEI API as a compile dependency // runtimeOnly fg.deobf("mezz.jei:jei-${mc_version}:${jei_version}") // Adds the full JEI mod as a runtime dependency // implementation fg.deobf("com.tterrag.registrate:Registrate:MC${mc_version}-${registrate_version}") // Adds registrate as a dependency // Examples using mod jars from ./libs // implementation fg.deobf("blank:coolmod-${mc_version}:${coolmod_version}") // For more info... // http://www.gradle.org/docs/current/userguide/artifact_dependencies_tutorial.html // http://www.gradle.org/docs/current/userguide/dependency_management.html } // Example for how to get properties into the manifest for reading at runtime. jar { manifest { attributes([ "Specification-Title" : "pixelmonevents", //"Specification-Vendor": "pixelmonevents authors", "Specification-Version" : "1", // We are version 1 of ourselves "Implementation-Title" : project.name, "Implementation-Version" : project.jar.archiveVersion, //"Implementation-Vendor": "pixelmonevents authors", "Implementation-Timestamp": new Date().format("yyyy-MM-dd'T'HH:mm:ssZ") ]) } } jar.finalizedBy('reobfJar')  
    • What exactly did you download?
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.