Jump to content

[1.10.2][SOLVED] Modifying a vanilla method


yooksi

Recommended Posts

What would be the easiest way of successfully modifying a vanilla method? I would like all calls coming to method A to be diverted to method B (which would be a custom method). If I could modify the method at runtime I would inject some code that just makes a call to method B, don't know if it works like that in reality. After searching online about this I've found out this is called reflection and that it's a very advanced procedure. However I've seen some mods around that have done exactly that, but I am having problems getting a grasp on how they did it. As always, any help would really be appreciated, thanks!

I still haven't published a mod because I can never get that in-dev version just right to warrant a public release. And yes, after two years of mod development I am still learning to speak Java.

 

Follow me on GitHub: https://github.com/yooksi

Contact me on Twitter: https://twitter.com/yooksi

Read my Minecraft blog: https://yooksidoesminecraft.blogspot.de/

Link to comment
Share on other sites

What would be the easiest way of successfully modifying a vanilla method? I would like all calls coming to method A to be diverted to method B (which would be a custom method). If I could modify the method at runtime I would inject some code that just makes a call to method B, don't know if it works like that in reality. After searching online about this I've found out this is called reflection and that it's a very advanced procedure. However I've seen some mods around that have done exactly that, but I am having problems getting a grasp on how they did it. As always, any help would really be appreciated, thanks!

Modifying a vanilla method is not supported by forge or this forum as that requires editing base classes which is a coremod.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

I don't think he's asking how to edit the base code so to speak.

 

It would depend on which behaviours you intended to implement/"override" really. Using @SubscribeEvent and writing custom event handlers to "add" or "tweak" some existing Minecraft behaviour could give the illusion of overriding base methods, but is far simpler than trying to reflect the code.

  • Like 1
Link to comment
Share on other sites

I would like all calls coming to method A to be diverted to method B...

*IF* method 'A' happens to have a Forge hook in it, then you can see what event it spawns and write an event handler (method 'B') whose result can cause the remainder of method 'A' to be skipped.

 

If not, then you probably can't get there from here.

 

Which method do you want to hijack?

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Link to comment
Share on other sites

And why

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Modifying a vanilla method is not supported by forge or this forum as that requires editing base classes which is a coremod.

I do not wish to create a coremod, I would like to modify the content of the vanilla method during application runtime. There is a forum thread about a similar idea here, and it recommends using Access Transformers. Maybe what I am doing is considered creating a coremod, but this is not my intention.

 

There is no single way to achieve this. Modifying the actual code of vanilla classes is not possible as was said above.

Please describe what you want to achieve (describe the behavior, not how you intend to code it!).

I would like to replicate what the developer called atomicstrykers did here. He was able to redirect all calls coming from World.getRawLight to his own custom method, and like that was able to control all the light values in World. The reason I am interested in this is because I would like to create a moving light source that moves with the player, like an item torch emitting light when held for example. What makes me worry about this is the optimization side, so would the way he did it be a better approach then manually setting the light values and sending them to world for update?

I still haven't published a mod because I can never get that in-dev version just right to warrant a public release. And yes, after two years of mod development I am still learning to speak Java.

 

Follow me on GitHub: https://github.com/yooksi

Contact me on Twitter: https://twitter.com/yooksi

Read my Minecraft blog: https://yooksidoesminecraft.blogspot.de/

Link to comment
Share on other sites

Modifying a vanilla method is not supported by forge or this forum as that requires editing base classes which is a coremod.

I do not wish to create a coremod, I would like to modify the content of the vanilla method during application runtime. There is a forum thread about a similar idea here, and it recommends using Access Transformers. Maybe what I am doing is considered creating a coremod, but this is not my intention.

 

Access Transformers are....

  • A coremod
  • Completely unnecessary as you can use Reflection
  • Don't modify code, only the access level (public, private, protected).

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

I don't think an effect similar to DynamicLights is possible without a coremod at this time, so go ahead and investigate where exactly you need forge hooks inserted (as little as possible) and then submit a pull request. If the hooks make sense, it will go in.

Thanks for the advice, I will take a look at Forge's code and see where I could insert one.

 

Modifying a vanilla method is not supported by forge or this forum as that requires editing base classes which is a coremod.

I do not wish to create a coremod, I would like to modify the content of the vanilla method during application runtime. There is a forum thread about a similar idea here, and it recommends using Access Transformers. Maybe what I am doing is considered creating a coremod, but this is not my intention.

 

Access Transformers are....

  • A coremod
  • Completely unnecessary as you can use Reflection
  • Don't modify code, only the access level (public, private, protected).

Is it possible to do what I want to do with reflection then?

I still haven't published a mod because I can never get that in-dev version just right to warrant a public release. And yes, after two years of mod development I am still learning to speak Java.

 

Follow me on GitHub: https://github.com/yooksi

Contact me on Twitter: https://twitter.com/yooksi

Read my Minecraft blog: https://yooksidoesminecraft.blogspot.de/

Link to comment
Share on other sites

Is it possible to do what I want to do with reflection then?

 

Unlikely.  But I don't know what it is you are trying to do.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

In some cases when method has no forge hooks, or other clear way of taking over calls, there is a an option that might* work if:

-Method is NOT static.

-Method is NOT private.

-Method is NOT final.

-Class is NOT final.

-You have / can gain access to classes' all instances.

 

When all of these (maybe not the * one, more about it in a second) are the case for you, you can create a class extending class that has the method and override it. Then what you have to do is replace all instances of class in question with your instance. It's easy if class is used as singleton, might be a bit harder if there are multiple instaces of it (but at that point, you always have a forge hook that allows accessing all/part of these instances).

Remember a few things though:

-Inner classes are not a problem, you'll just have to repeat process with its' external classes.

-If the instance(s) is/are stored in a private or final field, that's not a problem either. You have a way around both with reflection,

-If you have to default to vanilla(?) in overriden method, store instance that you replace and call it's method. It's very important, as other wise if other mods also use same replacement way...

 

*-If there are multiple mods using this way for the same thing, and one of them does not do it properly, it will break all other mods.

 

 

 

Also, just FYI, in case it will go to this point (like it did for me), using AOP (aspect oriented programming) java based language will not work (MC environment does not allow easy integration of such, if it is not integrated by forge).

Or at least, it did not work for me as much as i tried to hook in Aspect J (you CAN hook it with a coremod, but at this point, there's no point).

Link to comment
Share on other sites

In some cases when method has no forge hooks, or other clear way of taking over calls, there is a an option that might* work if:

-Method is NOT static.

-Method is NOT private.

-Method is NOT final.

-Class is NOT final.

-You have / can gain access to classes' all instances.

 

When all of these (maybe not the * one, more about it in a second) are the case for you, you can create a class extending class that has the method and override it. Then what you have to do is replace all instances of class in question with your instance. It's easy if class is used as singleton, might be a bit harder if there are multiple instaces of it (but at that point, you always have a forge hook that allows accessing all/part of these instances).

Remember a few things though:

-Inner classes are not a problem, you'll just have to repeat process with its' external classes.

-If the instance(s) is/are stored in a private or final field, that's not a problem either. You have a way around both with reflection,

-If you have to default to vanilla(?) in overriden method, store instance that you replace and call it's method. It's very important, as other wise if other mods also use same replacement way...

 

*-If there are multiple mods using this way for the same thing, and one of them does not do it properly, it will break all other mods.

 

 

 

Also, just FYI, in case it will go to this point (like it did for me), using AOP (aspect oriented programming) java based language will not work (MC environment does not allow easy integration of such, if it is not integrated by forge).

Or at least, it did not work for me as much as i tried to hook in Aspect J (you CAN hook it with a coremod, but at this point, there's no point).

Replacing the instances is a difficult yet sometimes the only viable solution. Thanks for suggesting it.

I still haven't published a mod because I can never get that in-dev version just right to warrant a public release. And yes, after two years of mod development I am still learning to speak Java.

 

Follow me on GitHub: https://github.com/yooksi

Contact me on Twitter: https://twitter.com/yooksi

Read my Minecraft blog: https://yooksidoesminecraft.blogspot.de/

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.