Jump to content

[1.8.9] More effective replacement for thread.sleep?


CoalOres

Recommended Posts

You don't know how to?

Yes we do, but it's your mod, and we are not going to write your mod for you.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

You don't know how to?

Yes we do, but it's your mod, and we are not going to write your mod for you.

I've attempted to copy the data in the txt file to an arrayList but it is just resulting in a "The type of expression must be an array type but it is resolved to List<String>".

 

This is the only way I can think of keeping track:

 

 @SubscribeEvent
 public void onClientTick(TickEvent.ClientTickEvent event) {
	 if (cont == true){
		 if(this.count < 5)
		 {
			 this.count++;
		 }
		 else {

	        this.count = 0;
	       
	            String path = "config/whitelist.txt";
	            String line;
	       
	            try {
	                FileReader file = new FileReader(path);
	                BufferedReader buffered = new BufferedReader(file);
	               
	                while ((line = buffered.readLine()) != null) {
	                    list.add(line);
	                    
	                }
	                int i = 0;
	                

	               if(list[i] != null){
	                		
	                		Minecraft.getMinecraft().thePlayer.sendChatMessage("/party invite " + line);
	                		i ++;

	                }
	               else{
	            	   buffered.close();
	            	   com.megaparties.Events.cont = false;
	               }

	                
	            }
	            catch (IOException e) {
	                e.printStackTrace();
	            }
		 }
	 }



}

 

There error is on the  if(list != null)

Link to comment
Share on other sites

Because that is not how you get the i'th element of a List.

This is basic java.

We are not here to help you learn basic java.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Try it and you'll find out.

 

My New Code:

 

 @SubscribeEvent
 public void onClientTick(TickEvent.ClientTickEvent event) {
	 if (cont == true){
		 if(this.count < 5)
		 {
			 this.count++;
		 }
		 else {

	        this.count = 0;
	       
	            String path = "config/whitelist.txt";
	            String line;
	       
	            try {
	                FileReader file = new FileReader(path);
	                BufferedReader buffered = new BufferedReader(file);
	               
	                while ((line = buffered.readLine()) != null) {
	                    list.add(line);
	                    
	                }
	                int i = 0;
	                

	               if(list.get(i) != null){
	                		
	                		Minecraft.getMinecraft().thePlayer.sendChatMessage("/party invite " + line);
	                		i ++;

	                }
	               else{
	            	   buffered.close();
	            	   com.megaparties.Events.cont = false;
	               }

	                
	            }
	            catch (IOException e) {
	                e.printStackTrace();
	            }
		 }
	 }

 

I can already see that it isn't going to work because i is set back to 0 every time it loops over.

Link to comment
Share on other sites

Then you have to save the integer outside of the method.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

Then you have to save the integer outside of the method.

Ok, I've done that, it works, save for the fact that the loop never ends... i never equals null and so it doesn't close. I can't put it at 0 because 0 still has a value, I need to detect when it has gone through the whole list.

Link to comment
Share on other sites

Don't do the reading of the whitelist every 5 ticks. Do it in a method that's getting called only once on startup (postInit or something else). Reading every tick is unnecessary.

 

Also,

if(cont == true)

is the same as

if(cont)

... (Basic Java)

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

Don't do the reading of the whitelist every 5 ticks. Do it in a method that's getting called only once on startup (postInit or something else). Reading every tick is unnecessary.

 

Also,

if(cont == true)

is the same as

if(cont)

... (Basic Java)

 

I don't think that would quite work. You see I also have commands which write to the file and clear it whenever you activate them, so it needs to be re-read. I probably misunderstood that.

 

Isn't there anything simpler I could do? Like

 

	               if(i <= list.size()){
	                		
	                		Minecraft.getMinecraft().thePlayer.sendChatMessage("/party invite " + list.get(i));
	                		i ++;

	                }

 

I tried that and it still didn't work.

Link to comment
Share on other sites

You really make me think you don't know Java... Do you?

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

You really make me think you don't know Java... Do you?

 

I am pretty sure that the answer to that for any post involving "thread.sleep" is "no."

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

I have discovered the source of the problem, now I am getting an array index out of bounds exception:

 

 

Command:

package com.megaparties;

import java.io.BufferedReader;
import java.io.FileReader;
import java.io.IOException;

import net.minecraft.command.CommandBase;
import net.minecraft.command.CommandException;
import net.minecraft.command.ICommandSender;

public class wparty extends  CommandBase {


    


    public String getCommandName() {
        return "wparty";
    }

    public String getCommandUsage(ICommandSender sender) {
        return "wparty";
    }

    public boolean canCommandSenderUseCommand(ICommandSender icommandsender) {
        return true;
    }

    public void processCommand(ICommandSender sender, String[] args) throws CommandException {
    	
    	com.megaparties.Events.cont = true;
    	   String path = "config/whitelist.txt";
           String line;
      
           try {
               FileReader file = new FileReader(path);
               BufferedReader buffered = new BufferedReader(file);
              
              
               while ((line = buffered.readLine()) != null) {
                   com.megaparties.Events.list.add(line);
                   
               
               }
               buffered.close();
           }
               catch (IOException e) {
                e.printStackTrace();
            }
            
        
        
    }


}

 

Event:

 

 @SubscribeEvent
 public void onClientTick(TickEvent.ClientTickEvent event) {
	 if (cont){
		 if(this.count < 5)
		 {
			 this.count++;
		 }
		 else {

	        this.count = 0;
	       
	            String path = "config/whitelist.txt";
	            String line;
	       
	           
            if(i < list.size()){

						Minecraft.getMinecraft().thePlayer.sendChatMessage("/party invite " + list.get(i));
						i ++;
						System.out.println(i);
						System.out.println(list.size());


				}
            else{
				  
				   com.megaparties.Events.cont = false;
				   
				   i = 0;
            }
		 }
	 }

Link to comment
Share on other sites

I have discovered the source of the problem, now I am getting an array index out of bounds exception:

 

 

Command:

package com.megaparties;

import java.io.BufferedReader;
import java.io.FileReader;
import java.io.IOException;

import net.minecraft.command.CommandBase;
import net.minecraft.command.CommandException;
import net.minecraft.command.ICommandSender;

public class wparty extends  CommandBase {


    


    public String getCommandName() {
        return "wparty";
    }

    public String getCommandUsage(ICommandSender sender) {
        return "wparty";
    }

    public boolean canCommandSenderUseCommand(ICommandSender icommandsender) {
        return true;
    }

    public void processCommand(ICommandSender sender, String[] args) throws CommandException {
    	
    	com.megaparties.Events.cont = true;
    	   String path = "config/whitelist.txt";
           String line;
      
           try {
               FileReader file = new FileReader(path);
               BufferedReader buffered = new BufferedReader(file);
              
              
               while ((line = buffered.readLine()) != null) {
                   com.megaparties.Events.list.add(line);
                   
               
               }
               buffered.close();
           }
               catch (IOException e) {
                e.printStackTrace();
            }
            
        
        
    }


}

 

Event:

 

 @SubscribeEvent
 public void onClientTick(TickEvent.ClientTickEvent event) {
	 if (cont){
		 if(this.count < 5)
		 {
			 this.count++;
		 }
		 else {

	        this.count = 0;
	       
	            String path = "config/whitelist.txt";
	            String line;
	       
	           
            if(i < list.size()){

						Minecraft.getMinecraft().thePlayer.sendChatMessage("/party invite " + list.get(i));
						i ++;
						System.out.println(i);
						System.out.println(list.size());


				}
            else{
				  
				   com.megaparties.Events.cont = false;
				   
				   i = 0;
            }
		 }
	 }

How do we help without seeing the stack trace (the log)?

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

  • 2 years later...

Please don't Necro old threads.

This is my Forum Signature, I am currently attempting to transform it into a small guide for fixing easier issues using spoiler blocks to keep things tidy.

 

As the most common issue I feel I should put this outside the main bulk:

The only official source for Forge is https://files.minecraftforge.net, and the only site I trust for getting mods is CurseForge.

If you use any site other than these, please take a look at the StopModReposts project and install their browser extension, I would also advise running a virus scan.

 

For players asking for assistance with Forge please expand the spoiler below and read the appropriate section(s) in its/their entirety.

Spoiler

Logs (Most issues require logs to diagnose):

Spoiler

Please post logs using one of the following sites (Thank you Lumber Wizard for the list):

https://gist.github.com/100MB Requires member (Free)

https://pastebin.com/: 512KB as guest, 10MB as Pro ($$$)

https://hastebin.com/: 400KB

Do NOT use sites like Mediafire, Dropbox, OneDrive, Google Drive, or a site that has a countdown before offering downloads.

 

What to provide:

...for Crashes and Runtime issues:

Minecraft 1.14.4 and newer:

Post debug.log

Older versions:

Please update...

 

...for Installer Issues:

Post your installer log, found in the same place you ran the installer

This log will be called either installer.log or named the same as the installer but with .log on the end

Note for Windows users:

Windows hides file extensions by default so the installer may appear without the .jar extension then when the .log is added the log will appear with the .jar extension

 

Where to get it:

Mojang Launcher: When using the Mojang launcher debug.log is found in .minecraft\logs.

 

Curse/Overwolf: If you are using the Curse Launcher, their configurations break Forge's log settings, fortunately there is an easier workaround than I originally thought, this works even with Curse's installation of the Minecraft launcher as long as it is not launched THROUGH Twitch:

Spoiler
  1. Make sure you have the correct version of Forge installed (some packs are heavily dependent on one specific build of Forge)
  2. Make a launcher profile targeting this version of Forge.
  3. Set the launcher profile's GameDir property to the pack's instance folder (not the instances folder, the folder that has the pack's name on it).
  4. Now launch the pack through that profile and follow the "Mojang Launcher" instructions above.

Video:

Spoiler

 

 

 

or alternately, 

 

Fallback ("No logs are generated"):

If you don't see logs generated in the usual place, provide the launcher_log.txt from .minecraft

 

Server Not Starting:

Spoiler

If your server does not start or a command window appears and immediately goes away, run the jar manually and provide the output.

 

Reporting Illegal/Inappropriate Adfocus Ads:

Spoiler

Get a screenshot of the URL bar or copy/paste the whole URL into a thread on the General Discussion board with a description of the Ad.

Lex will need the Ad ID contained in that URL to report it to Adfocus' support team.

 

Posting your mod as a GitHub Repo:

Spoiler

When you have an issue with your mod the most helpful thing you can do when asking for help is to provide your code to those helping you. The most convenient way to do this is via GitHub or another source control hub.

When setting up a GitHub Repo it might seem easy to just upload everything, however this method has the potential for mistakes that could lead to trouble later on, it is recommended to use a Git client or to get comfortable with the Git command line. The following instructions will use the Git Command Line and as such they assume you already have it installed and that you have created a repository.

 

  1. Open a command prompt (CMD, Powershell, Terminal, etc).
  2. Navigate to the folder you extracted Forge’s MDK to (the one that had all the licenses in).
  3. Run the following commands:
    1. git init
    2. git remote add origin [Your Repository's URL]
      • In the case of GitHub it should look like: https://GitHub.com/[Your Username]/[Repo Name].git
    3. git fetch
    4. git checkout --track origin/master
    5. git stage *
    6. git commit -m "[Your commit message]"
    7. git push
  4. Navigate to GitHub and you should now see most of the files.
    • note that it is intentional that some are not synced with GitHub and this is done with the (hidden) .gitignore file that Forge’s MDK has provided (hence the strictness on which folder git init is run from)
  5. Now you can share your GitHub link with those who you are asking for help.

[Workaround line, please ignore]

 

Link to comment
Share on other sites

Guest
This topic is now closed to further replies.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.