Jump to content

[1.10.2] Question about syncing tile entity data


Silly511

Recommended Posts

That depends:

Does the client ever need to know this information?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Then sync the data.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Override getUpdatePacket and getUpdateTag()

 

getUpdatePacket will return a new package with the contents returned from getUpdateTag, where you write all the TE's information in it.  You can get away with just using the same nbt that's saved to disk, as long as there isn't a ton of data the client doesn't need.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

I tried that but it doesn't work. Heres my code:

public class TileCrystalFurnace extends TileEntity implements ITickable {

private static ArrayList<Block> hotBlocks = new ArrayList();

static {
	hotBlocks.add(Blocks.LAVA);
	hotBlocks.add(Blocks.FLOWING_LAVA);
	hotBlocks.add(Block.getBlockFromName("magma"));
}

private ItemStackHandler inventory = new ItemStackHandler(2) {
	@Override
	protected void onContentsChanged(int slot) {
		TileCrystalFurnace.this.markDirty();
	}

	@Override
	protected int getStackLimit(int slot, ItemStack stack) {
		if (slot == 0) {
			if (stack.getItem() == Items.DIAMOND) return super.getStackLimit(slot, stack);
		} else if (slot == 1) {
			if (stack.getItem() == Item.getItemFromBlock(Blocks.GLASS)) return super.getStackLimit(slot, stack);
		}
		return 0;
	}

};

private FluidTank crystalTank = new FluidTank(Fluid.BUCKET_VOLUME * 2) {
	@Override
	protected void onContentsChanged() {
		TileCrystalFurnace.this.markDirty();
	}
};

public boolean isHeated;
public boolean isMelting;
public int meltTime = 0;

public TileCrystalFurnace() {
	crystalTank.setCanFill(false);
}

@Override
public void update() {
	isHeated = worldObj.getBlockState(pos.add(0, -1, 0)) != null && hotBlocks.contains(worldObj.getBlockState(pos.add(0, -1, 0)).getBlock());

	if (worldObj.isRemote) return;

	if (isHeated && !isMelting && inventory.extractItem(0, 1, true) != null && inventory.extractItem(1, 3, true) != null && inventory.extractItem(1, 3, true).stackSize == 3 && crystalTank.fillInternal(new FluidStack(EnchantedAura.liquidCrystal, 500), false) == 500) {
		inventory.extractItem(0, 1, false);
		inventory.extractItem(1, 3, false);
		isMelting = true;
		meltTime = 400;
		this.markDirty();
	}

	if (isMelting && meltTime == 0) {
		isMelting = false;
		crystalTank.fillInternal(new FluidStack(EnchantedAura.liquidCrystal, 500), true);
		this.markDirty();
	}

	if (isMelting && isHeated) {
		meltTime--;
		this.markDirty();
	}

}

@Override
public void readFromNBT(NBTTagCompound compound) {
	super.readFromNBT(compound);

	inventory.deserializeNBT(compound.getCompoundTag("inventory"));
	crystalTank.readFromNBT(compound.getCompoundTag("crystalTank"));

	meltTime = compound.getInteger("meltTime");
	isMelting = compound.getBoolean("isMelting");
}

@Override
public NBTTagCompound writeToNBT(NBTTagCompound compound) {
	compound.setTag("inventory", inventory.serializeNBT());
	compound.setTag("crystalTank", crystalTank.writeToNBT(new NBTTagCompound()));

	compound.setInteger("meltTime", meltTime);
	compound.setBoolean("isMelting", isMelting);

	return super.writeToNBT(compound);
}

@Override
public boolean hasCapability(Capability<?> capability, EnumFacing facing) {
	if (capability == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY || capability == CapabilityFluidHandler.FLUID_HANDLER_CAPABILITY)
		return true;
	return super.hasCapability(capability, facing);
}

@Override
public <T> T getCapability(Capability<T> capability, EnumFacing facing) {
	if (capability == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY)
		return (T) inventory;
	else if (capability == CapabilityFluidHandler.FLUID_HANDLER_CAPABILITY)
		return (T) crystalTank;
	return super.getCapability(capability, facing);
}

@Override
public final NBTTagCompound getUpdateTag() {
	return this.writeToNBT(new NBTTagCompound());
}

@Override
public SPacketUpdateTileEntity getUpdatePacket() {
	return new SPacketUpdateTileEntity(this.getPos(), 1, this.getUpdateTag());
}

}

 

My GUI never shows the progress bar moving, or liquid entering the tank. It does show the items disappearing however thats probably because the container syncs items.

Link to comment
Share on other sites

1) Mark dirty says "this needs to be saved to disk" not "send this to the client."

2) I believe the method you want is now called

worldObj.markAndNotifyBlock(pos, chunk, iblockstate, newState, flags);

3) The client isn't updating its own values on its end because you did

if (worldObj.isRemote) return;

(you can safely remove that for the most part)

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

2) I believe the method you want is now called worldObj.markAndNotifyBlock(pos, chunk, iblockstate, newState, flags);

 

If the only reason for marking an update is to sync tile entity data to the client for rendering purposes, then worldObj.notifyBlockUpdate(pos, oldState, newState, flags) looks to be a better option.  markAndNotifyBlock() works - it calls notifyBlockUpdate() - but it also notifies the block's neighbours of a blockstate change, and may cause some comparator recalculation - extra unnecessary server load if you're just syncing TE data.

 

Link to comment
Share on other sites

Thanks desht.

 

I have trouble finding that method because the 1.7 name was "markBlockForUpdate" or similar, so I type "mark..." and autocompletion gives me results that don't include that one.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.