Jump to content

MC 1.10+ returning an item with metadata


winnetrie

Recommended Posts

I'm trying to get an item from a stack but with the metadata.

If i do this:

ItemStack stack= new ItemStack(ModBlocks.bricksstairwhite,1,3);
Item item= stack.getItem();

 

It does not give me the item with metadata 3, but instead give me always the 0.

Here an example why i need this:

@Override
public Item getTabIconItem() {
	ItemStack stack= new ItemStack(ModBlocks.bricksstairwhite,1,3);
	Item item= stack.getItem();

	return item;
}

And here another example why i need this:

	List<IRecipe> recipes = CraftingManager.getInstance().getRecipeList();
    	Iterator<IRecipe> Leash = recipes.iterator();
    			         
    		while (Leash.hasNext()) {
    			ItemStack is = Leash.next().getRecipeOutput();
    			
    			if (is != null && is.getItem() == Item.getItemFromBlock(Blocks.SANDSTONE_STAIRS))
    				Leash.remove();
    			if (is != null && is.getItem() == Item.getItemFromBlock(Blocks.RED_SANDSTONE_STAIRS))
    				Leash.remove();
    			if (is != null && is.getItem() == Item.getItemFromBlock(Blocks.BRICK_BLOCK))
    				Leash.remove();
    			if (is != null && is.getItem() == Item.getItemFromBlock(Blocks.STONEBRICK))
    				Leash.remove();
    			if (is != null && is.getItem() == Item.getItemFromBlock(Blocks.STONE_BRICK_STAIRS))
    				Leash.remove();
    			ItemStack stack = new ItemStack(Blocks.STONE_SLAB,1,5);
    			Item item = stack.getItem();
    			if (is != null && is.getItem() == item){
    				Leash.remove();
    			}
    		};

I want in the recipe remover only removing that subblock, but it removes them all.

So how do i get the right item for it?

Link to comment
Share on other sites

if (is != null && is.getItem() == Items.APPLE && is.getMetadata() == 1) {
     // Do stuff
}

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

I love how this code:

    			ItemStack stack = new ItemStack(Blocks.STONE_SLAB,1,5);
    			Item item = stack.getItem();
    			if (is != null && is.getItem() == item){
    				Leash.remove();
    			}

Sets up a variant item stack, then ignores the shit out of it.

 

Also, dude, seriously, wrap all of this in a single if(is != null) check. Simplify your life.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

if (is != null && is.getItem() == Items.APPLE && is.getMetadata() == 1) {
     // Do stuff
}

 

Oh right, it looks like i did it wrong before.

 

@Draco

You mean because i make variables for it while it isn't needed? I know this, i change it later. I do it for testing purpose only.

 

Also for the creative tabs i still can't get it working.

 

This is what i have now:

public class TemStairsTab extends CreativeTabs {

public TemStairsTab(String label) {
	super(label);
	//this.setBackgroundImageName("teleport.png");
}
@Override
public Item getTabIconItem() {
	ItemStack stack= new ItemStack(ModBlocks.bricksstairwhite);
	Item item = stack.getItem();
	return item;
}
@Override
@SideOnly(Side.CLIENT)
    public int getIconItemDamage(){	
        return 3;
    }
}

I looked into the creativetabs class and found this getIconItemDamage() method wich i hoped it would do what i needed, but insetad i now have a black/purple square icon in my creative tab.

Link to comment
Share on other sites

I made it cleaner now (i think  :D)

 

	List<IRecipe> recipes = CraftingManager.getInstance().getRecipeList();
    	Iterator<IRecipe> Leash = recipes.iterator();
    			         
    		while (Leash.hasNext()) {
    			ItemStack is = Leash.next().getRecipeOutput();
    			if (is !=null){
    				if (is.getItem() == Item.getItemFromBlock(Blocks.SANDSTONE_STAIRS))
    					Leash.remove();
    				if (is.getItem() == Item.getItemFromBlock(Blocks.RED_SANDSTONE_STAIRS))
    					Leash.remove();
    				if (is.getItem() == Item.getItemFromBlock(Blocks.BRICK_BLOCK))
    					Leash.remove();
    				if (is.getItem() == Item.getItemFromBlock(Blocks.STONEBRICK))
    					Leash.remove();
    				if (is.getItem() == Item.getItemFromBlock(Blocks.STONE_BRICK_STAIRS))
    					Leash.remove();
    				if (is.getItem() == Item.getItemFromBlock(Blocks.STONE_SLAB) && is.getMetadata()==5){
    					Leash.remove();
    				}
    			}
    		};

 

and:

public class TemStairsTab extends CreativeTabs {

public TemStairsTab(String label) {
	super(label);
	//this.setBackgroundImageName("teleport.png");
}
@Override
public Item getTabIconItem() {
	return new ItemStack(ModBlocks.bricksstairwhite).getItem();
}
@Override
@SideOnly(Side.CLIENT)
    public int getIconItemDamage(){	
        return 3;
    }
}

Link to comment
Share on other sites

@Draco

You mean because i make variables for it while it isn't needed? I know this, i change it later. I do it for testing purpose only.

 

No, I mean you create an item stack with an item and metadata value, then discard the stack for the item.

 

This:

ItemStack stack = new ItemStack(Blocks.STONE_SLAB,1,5);
Item item = stack.getItem();

And this:

Item item = Item.getItemForBlock(Blocks.STONE_SLAB);

Are identical.

As would:

ItemStack stack = new ItemStack(Blocks.STONE_SLAB,1,14);
Item item = stack.getItem();

And:

ItemStack stack = new ItemStack(Blocks.STONE_SLAB,1,0);
Item item = stack.getItem();

As well as:

ItemStack stack = new ItemStack(Blocks.STONE_SLAB,1,123456789);
Item item = stack.getItem();

 

Your updated code handles it correctly, of course.  Even if it was "just for testing" it should have been apparent that an Item (which has no concept of metadata) isn't magically different after wrapping it into, then extracting it from, an ItemStack.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

No, I mean you create an item stack with an item and metadata value, then discard the stack for the item.

 

Oh yes, true. I do understand now. Sorry... :P

 

Edit:

Sometimes i wonder why things aren't working and after a while i realize i have been stupid lol! this happens to often

Ofc this isn't working:

public class TemStairsTab extends CreativeTabs {

public TemStairsTab(String label) {
	super(label);
	//this.setBackgroundImageName("teleport.png");
}
@Override
public Item getTabIconItem() {
	ItemStack stack= new ItemStack(ModBlocks.bricksstairwhite);
	Item item = stack.getItem();
	return item;
}
@Override
@SideOnly(Side.CLIENT)
    public int getIconItemDamage(){	
        return 3;
    }
}

Why? because ModBlocks.bricksstairwhite has no subtypes....

That's why it is called bricksstairwhite

 

Just tried this method getIconItemDamage() with the other tabs and it's all working fine!

 

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I created my own modpack just for mainly entities right now and im having issues with only a handful of the mobs. is there a way someone could help go over my work and check whats wrong? its a file 
    • Hi, I have a problem with my minecraft: I'm in forge 1.20.1 and I have several mods installed, (link to photo below) and after a while, at random, the game freezes, I can't play or move but I can still hear the game in the background, there's just the image that remains, (problematic when I fight a fire dragon :() ) can you help me? my mods:   zmedievalmusic-1.20.1-2.1 treeharvester-1.20.1-8.7 tctcore-1.0-1.20.1 specialmobs-1.20.1-3.1.3 simpleOres2-1.20.1-6.0.0.2 OldCombatMod_1.20x.jar oculus-mc1.20.1-1.7.0 medieval_buildings-forge-1.0.2 matmos-5.2-forge-1.20.1 journeymap-1.20.1-5.9.18-forge jei-1.20.1-forge-15.8.0.11 iceandfire-2.1.13-1.20.1-beta-4 healthindicatortxf-1.20.1-1.2.2-forge geckolib-forge-1.20.1-4.4.7 embeddium-0.3.25+mc1.20.1 dynamiclights-1.20.1-1.2 cupboard-1.20.1-2.7 crust-1.20.1-2.3.3 collective-1.20.1-7.71 citadel-2.4.9-1.20.1 bucketlib-1.20.1-2.3.0.5 born_in_chaos_(Forge)1.20.1_1.3.1 betterfpsdist-4.4   forge 1.20.1 (47.3.5) i fink it's because of ice and fire mod, but i want it thank to help me! i hope you are well Translated with DeepL.com (free version)
    • Long story short, my girlfriend found a mod for Minecraft she wanted but it was for Pocket Edition. So I took it on myself to try and port it over and it has gone fairly well until the point I had to work with particles. Basically, I had it working using animateTick but I was checking if the block name contained a certain value to specify the lantern's color and as such choose which particle to spawn. I was initially trying to do this via the constructor, but this value hasn't been initialized that early and I can't seem to find some event or method to override which ideally happens when the block is loaded/placed. Performing upwards to 16 string comparisons per tick isn't exactly efficient so I want to try and optimize this. By the time animateTick starts executing, the name is properly initialized and I can use that to set my property accordingly. But this is where I'm starting to run into a weird issue. This is my current code; public void animateTick(BlockState state, Level level, BlockPos pos, RandomSource randomSource) { // It's not fully initialized yet... I guess? if (this.getName().toString().contains("air")) return; if (!state.getValue(COLOR_SET)) { // This method doesn't work at all, neither states are updated var blockState = level.getBlockState(pos); blockState.setValue(LANTERNCOLOR, this.getBlockColor()); blockState.setValue(COLOR_SET, true); level.setBlockAndUpdate(pos, blockState); } double d0 = (double)pos.getX() + randomSource.nextDouble(); double d1 = (double)pos.getY() + randomSource.nextDouble(); double d2 = (double)pos.getZ() + randomSource.nextDouble(); // No idea how to better do this without adding 5 000 new files if (level.getBlockState(pos).getValue(LANTERNCOLOR) == DyeColor.WHITE.getId()) level.addParticle(PaperLanterns.LANTERN_GLOW_WHITE.get(), d0, d1, d2, 0.0D, ThreadLocalRandom.current().nextDouble(-0.10D, 0.0D), 0.0D); if (level.getBlockState(pos).getValue(LANTERNCOLOR) == DyeColor.BLUE.getId()) level.addParticle(PaperLanterns.LANTERN_GLOW_BLUE.get(), d0, d1, d2, 0.0D, ThreadLocalRandom.current().nextDouble(-0.10D, 0.0D), 0.0D); } COLOR_SET is a BooleanProperty meant to ensure this is only executed once, for performance reasons. LANTERNCOLOR is currently an IntegerProperty (it used to be an EnumProperty, but been changing stuff around trying to fix the issue) which specified the color. My issue is that I can only set one of these states, for example like this; if (!state.getValue(COLOR_SET)) { // LANTERNCOLOR is set successfully, but not COLORSET level.setBlockAndUpdate(pos, state.setValue(LANTERNCOLOR, this.getBlockColor())); level.setBlockAndUpdate(pos, state.setValue(COLOR_SET, true)); } // OR if (!state.getValue(COLOR_SET)) { // COLOR_SET is set successfully, but not LANTERNCOLOR level.setBlockAndUpdate(pos, state.setValue(COLOR_SET, true)); level.setBlockAndUpdate(pos, state.setValue(LANTERNCOLOR, this.getBlockColor())); } So I can only seemingly set one state at a time, I now know that my issue wasn't in my usage of EnumProperty so once I solve this I will be going back to that and using a switch-case. But I would love some pointers as to why I can only set one of these states. Is it because once you set it and update it, that instance of the block is now considered dirty and as such accepts no more state changes or something? I know the code's a bit all over the place with how I retrieve the states. I'm still learning and have been testing a bunch trying to get this to work, but have now found the issue but no idea how to solve it 😅 If there's a better way of setting this LANTERNCOLOR property and ensuring it's only executed once, that would be even better. The sole purpose of this is to choose which particle to spawn, since the particle colors are hardcoded.
    • Hi, I have a problem with my minecraft: I'm in forge 1.20.1 and I have several mods installed, (link to photo below) and after a while, at random, the game freezes, I can't play or move but I can still hear the game in the background, there's just the image that remains, (problematic when I fight a fire dragon :() ) can you help me? my mods: file:///C:/Users/meria/Pictures/Capture.PNG forge 1.20.1 (47.3.5) i fink it's because of ice and fire mod, but i want it thank to help me! i hope you are well Translated with DeepL.com (free version)
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.