Jump to content

MC1.10+ Custom bookshelf


winnetrie

Recommended Posts

I created bookshelfs for the other woodtypes. I have 1 problem!

When i break them they return 3 books wich is normal and that's also what i want them to do. So that's fine!

Yet they do drop as a book with metedata. You see them ingame as huge black/pink cubes.

How can i prevent this?

Here is the code :

 

public class BlockModBookshelf extends BlockBookshelf implements IMetaBlockName{
public static final PropertyEnum TYPE = PropertyEnum.create("type", BlockModBookshelf.EnumType.class);
public BlockModBookshelf(){
	super();
        setHardness(1.50F);
        //setResistance(7F);
        setSoundType(SoundType.WOOD);
        this.setDefaultState(this.blockState.getBaseState().withProperty(TYPE, EnumType.SPRUCE));
        setUnlocalizedName(References.temBlocks.BOOKSHELF.getUnlocalizedName());
	setRegistryName(References.temBlocks.BOOKSHELF.getRegistryName());
	setCreativeTab(Tem.blockstab);


}

@Override
public float getEnchantPowerBonus(World world, BlockPos pos){
	Block block = world.getBlockState(pos).getBlock();
        return this == block || block instanceof BlockBookshelf ? 1 : 0;
    }

@Override
protected BlockStateContainer createBlockState() {
    return new BlockStateContainer(this, new IProperty[] { TYPE });
}
@Override
public IBlockState getStateFromMeta(int meta) {	
    return getDefaultState().withProperty(TYPE, EnumType.values()[meta]);
}

@Override
public int getMetaFromState(IBlockState state) {
    return ((Enum<EnumType>) state.getValue(TYPE)).ordinal();
}
@Override
public int damageDropped(IBlockState state) {
    return getMetaFromState(state);
}
@Override
public void getSubBlocks(Item itemIn, CreativeTabs tab, List list) {
	for (EnumType t : EnumType.values())
    list.add(new ItemStack(itemIn, 1, t.ordinal()));  
}

@Override
public String getSpecialName(ItemStack stack) {
	return EnumType.values()[stack.getItemDamage()].name().toLowerCase();
}
@Override
public int quantityDropped(Random random)
    {
        return 3;
    }
    @Override
    @Nullable
    public Item getItemDropped(IBlockState state, Random rand, int fortune){
    	
        return Items.BOOK;
    }

public enum EnumType implements IStringSerializable{

	SPRUCE(0, "spruce"), BIRCH(1, "birch"), JUNGLE(2, "jungle"), ACACIA(3, "acacia"), DARKOAK(4,"darkoak");

    private int ID;
    private String name;
   
    private EnumType(int ID, String name) {
        this.ID = ID;
        this.name = name;
            
    }
    @Override
    public String getName() {
        return name;
    }
    public int getID() {
        return ID;
    }
    @Override
    public String toString() {
        return getName();
    }
}

}

 

 

this is the methis that return the metadata for the drop.

Removing this from the class solves it, but then in creative mode you don't get the right block if you

click with the middlemouse button.

@Override
public int damageDropped(IBlockState state) {
    return getMetaFromState(state);
}

 

Link to comment
Share on other sites

Remove the

Block#damageDropped

override and override

Block#getPickBlock

to return the appropriate

ItemStack

of your bookshelf.

jup fixed it now:

@Override
public ItemStack getPickBlock(IBlockState state, RayTraceResult target, World world, BlockPos pos, EntityPlayer player)
    {
	Block block = world.getBlockState(pos).getBlock();
	int meta = ((Enum<EnumType>) world.getBlockState(pos).getValue(TYPE)).ordinal();
        return new ItemStack(block,1,meta);
}

This method comes standard with return getItem(world, pos, state)

But that's deprecated and doesn't work in this case.

So i came with this idea. What you think? Good or bad? It's working.

Link to comment
Share on other sites

There's no need to get the

IBlockState

from the world, you receive it as an argument.

 

You can also just use

this

as the

Block

instead of getting it from the

IBlockState

.

 

You should never need to cast the value returned by

IBlockState#getValue

, it should already return the appropriate type.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

There's no need to get the

IBlockState

from the world, you receive it as an argument.

 

You can also just use

this

as the

Block

instead of getting it from the

IBlockState

.

 

You should never need to cast the value returned by

IBlockState#getValue

, it should already return the appropriate type.

I added a cast to it because eclipse tells me do to so. If i don't it it marked as "wrong".

i now changed my code to this:

@Override
public ItemStack getPickBlock(IBlockState state, RayTraceResult target, World world, BlockPos pos, EntityPlayer player)
    {
	Block block = state.getBlock();
	int meta = block.getMetaFromState(state);
        return new ItemStack(block,1,meta);
}

Strange i haven't seent his before but this looks a lot better now.

I also decided to get the meta from the state. Perhaps it makes more sense.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Baba  Serege [[+27-73 590 8989]] has experience of 27 years in helping and guiding many people from all over the world. His psychic abilities may help you answer and resolve many unanswered questions. He specialize in helping women and men from all walks of life.. 1) – Bring back lost lover. even if lost for a long time. 2) – My lover is abusing alcohol, partying and cheating on me I urgently need help” 3) – Divorce or court issues. 4) – Is your love falling apart? 5) – Do you want your love to grow stronger? 6) – Is your partner losing interest in you? 7) – Do you want to catch your partner cheating on you? – We help to keep your partner faithful and loyal to you. 9) – We recover love and happiness when relationship breaks down. 10) – Making your partner loves you alone. 11) – We create loyalty and everlasting love between couples. 12) – Get a divorce settlement quickly from your ex-partner. 13) – We create everlasting love between couples. 14) – We help you look for the best suitable partner. 15) – We bring back lost lover even if lost for a long time. 16) – We strengthen bonds in all love relationship and marriages 17) – Are you an herbalist who wants to get more powers? 18) – Buy a house or car of your dream. 19) – Unfinished jobs by other doctors come to me. 20) – I help those seeking employment. 21) – Pensioners free treatment. 22) – Win business tenders and contracts. 23) – Do you need to recover your lost property? 24) – Promotion at work and better pay. 25) – Do you want to be protected from bad spirits and nightmares? 26) – Financial problems. 27) – Why you can’t keep money or lovers? 28) – Why you have a lot of enemies? 29) – Why you are fired regularly on jobs? 30) – Speed up money claim spell, delayed payments, pension and accident funds 31) – I help students pass their exams/interviews. 33) – Removal of bad luck and debts. 34) – Are struggling to sleep because of a spiritual wife or husband. 35- ) Recover stolen property
    • OLXTOTO adalah situs bandar togel online resmi terbesar dan terpercaya di Indonesia. Bergabunglah dengan OLXTOTO dan nikmati pengalaman bermain togel yang aman dan terjamin. Koleksi toto 4D dan togel toto terlengkap di OLXTOTO membuat para member memiliki pilihan taruhan yang lebih banyak. Sebagai situs togel terpercaya, OLXTOTO menjaga keamanan dan kenyamanan para membernya dengan sistem keamanan terbaik dan enkripsi data. Transaksi yang cepat, aman, dan terpercaya merupakan jaminan dari OLXTOTO. Nikmati layanan situs toto terbaik dari OLXTOTO dengan tampilan yang user-friendly dan mudah digunakan. Layanan pelanggan tersedia 24/7 untuk membantu para member. Bergabunglah dengan OLXTOTO sekarang untuk merasakan pengalaman bermain togel yang menyenangkan dan menguntungkan.
    • Baba  Serege [[+27-73 590 8989]] has experience of 27 years in helping and guiding many people from all over the world. His psychic abilities may help you answer and resolve many unanswered questions. He specialize in helping women and men from all walks of life.. 1) – Bring back lost lover. even if lost for a long time. 2) – My lover is abusing alcohol, partying and cheating on me I urgently need help” 3) – Divorce or court issues. 4) – Is your love falling apart? 5) – Do you want your love to grow stronger? 6) – Is your partner losing interest in you? 7) – Do you want to catch your partner cheating on you? – We help to keep your partner faithful and loyal to you. 9) – We recover love and happiness when relationship breaks down. 10) – Making your partner loves you alone. 11) – We create loyalty and everlasting love between couples. 12) – Get a divorce settlement quickly from your ex-partner. 13) – We create everlasting love between couples. 14) – We help you look for the best suitable partner. 15) – We bring back lost lover even if lost for a long time. 16) – We strengthen bonds in all love relationship and marriages 17) – Are you an herbalist who wants to get more powers? 18) – Buy a house or car of your dream. 19) – Unfinished jobs by other doctors come to me. 20) – I help those seeking employment. 21) – Pensioners free treatment. 22) – Win business tenders and contracts. 23) – Do you need to recover your lost property? 24) – Promotion at work and better pay. 25) – Do you want to be protected from bad spirits and nightmares? 26) – Financial problems. 27) – Why you can’t keep money or lovers? 28) – Why you have a lot of enemies? 29) – Why you are fired regularly on jobs? 30) – Speed up money claim spell, delayed payments, pension and accident funds 31) – I help students pass their exams/interviews. 33) – Removal of bad luck and debts. 34) – Are struggling to sleep because of a spiritual wife or husband. 35- ) Recover stolen property
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.