[1.8.9] Sitting On Custom Chair Issue.

[Phonixe]

Hello, so i've been trying to create a custom chair that i can sit on, after many attempts I created it but there seems to be an issue when I try to sit on it. Whenever i right click the chair, it teleports me into it and then pushes me out and nothing happens afterwards. However if I log off and log back in I find myself sitting on the chair.

 

Here's the code for the chair block

 

public class Phoerite_Chair extends Block {

 

public static PropertyDirection FACING = PropertyDirection.create("facing", EnumFacing.Plane.HORIZONTAL);

 

public Phoerite_Chair(Material materialIn) {

super(materialIn);

this.setDefaultState(this.blockState.getBaseState().withProperty(FACING, EnumFacing.NORTH));

super.setBlockBounds( 0.0F, 0F, 0.0F, 1.0F, 1.35F, 1.0F);

}

 

@Override

public boolean isOpaqueCube() {

return false;

}

 

@Override

public EnumWorldBlockLayer getBlockLayer() {

return EnumWorldBlockLayer.CUTOUT;

}

 

@Override

public void onBlockPlacedBy(World worldIn, BlockPos pos, IBlockState state, EntityLivingBase placer,

ItemStack stack) {

 

        if (!worldIn.isRemote)

        {

worldIn.spawnEntityInWorld(new EntityArrow(worldIn, (double)pos.getX() + 0.5D, (double)pos.getY() + 0.5D, (double)pos.getZ() + 0.5D));

        }

super.onBlockPlacedBy(worldIn, pos, state, placer, stack);

}

@Override

public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn,EnumFacing side, float hitX, float hitY, float hitZ) {

 

if (!worldIn.isRemote)

{

playerIn.mountEntity(new EntityArrow(worldIn, (double)pos.getX() + 0.5D, (double)pos.getY() + 0.5D, (double)pos.getZ() + 0.5D));

}

return super.onBlockActivated(worldIn, pos, state, playerIn, side, hitX, hitY, hitZ);

}

 

@Override

public void onBlockDestroyedByPlayer(World worldIn, BlockPos pos, IBlockState state) {

        Entity entity;

        entity = new EntityArrow(worldIn, (double)pos.getX() + 0.5D, (double)pos.getY() + 0.5D, (double)pos.getZ() + 0.5D);

        if (!worldIn.isRemote)

        {

        entity.setDead();

        }

super.onBlockDestroyedByPlayer(worldIn, pos, state);

}

 

@Override

public IBlockState onBlockPlaced(World worldIn, BlockPos pos, EnumFacing facing, float hitX, float hitY, float hitZ, int meta, EntityLivingBase placer) {

IBlockState state = super.onBlockPlaced(worldIn, pos, facing, hitX, hitY, hitZ, meta, placer);

return state.withProperty(FACING, placer.getHorizontalFacing());

}

 

   

    @Override

    public int getMetaFromState(IBlockState state) {

   

    return ((EnumFacing) state.getValue(FACING)).getHorizontalIndex();

    }

   

    @Override

    public IBlockState getStateFromMeta(int meta) {

   

    return this.getDefaultState().withProperty(FACING, EnumFacing.getHorizontal(meta));

    }

   

    @Override

    protected BlockState createBlockState() {

    return new BlockState(this, new IProperty[] {FACING});

    }

}

 

 

[XFactHD]

First of all, you need a custom entity as it needs to have a hitbox of size 0 to not be pushed out of the block. Secondly, you are spawning a NEW entity every time you want to interact with it. This means that you are creating more and more entities but never actually removing them. Instead you need to create a TileEntity and store the entity's UUID in it and retrieve the from the world with the help of that UUID every time you need to interact with the entity.

[Phonixe]

Sorry, but how could I store the entity UUID? I'm not quite sure how to do this as i'm still a newbie..

[Draco18s]

Entities have a UUID field.

Get it.

Save it into a field of your TE.

[Phonixe]

Alright thanks! But how do I use this UUID to interact with the entity?

 

[Phonixe]

Thanks again! But there still seems to be an issue... None of the interractions with the entity work.

Here is the current chair block code :

public class Phoerite_Chair extends Block {

public static PropertyDirection FACING = PropertyDirection.create("facing", EnumFacing.Plane.HORIZONTAL);

public Phoerite_Chair(Material materialIn) {
	super(materialIn);
	this.setDefaultState(this.blockState.getBaseState().withProperty(FACING, EnumFacing.NORTH));
	super.setBlockBounds( 0.0F, 0F, 0.0F, 1.0F, 1.35F, 1.0F);
}

@Override
public boolean isOpaqueCube() {
	return false;
}

@Override
public EnumWorldBlockLayer getBlockLayer() {
	return EnumWorldBlockLayer.CUTOUT;
}

@Override
public void onBlockPlacedBy(World worldIn, BlockPos pos, IBlockState state, EntityLivingBase placer, ItemStack stack) {
        if (!worldIn.isRemote)
        {
        WorldServer worldserver = (WorldServer) worldIn;	
	worldIn.spawnEntityInWorld(worldserver.getEntityFromUuid(TileEntityChair.ChairUUID));
        }

	super.onBlockPlacedBy(worldIn, pos, state, placer, stack);
}
@Override
public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn,EnumFacing side, float hitX, float hitY, float hitZ) {

	if (!worldIn.isRemote)
	{
		WorldServer worldserver = (WorldServer) worldIn;
		playerIn.mountEntity(worldserver.getEntityFromUuid(TileEntityChair.ChairUUID));
	}
		return super.onBlockActivated(worldIn, pos, state, playerIn, side, hitX, hitY, hitZ);
}

@Override
public void onBlockDestroyedByPlayer(World worldIn, BlockPos pos, IBlockState state) {

        if (!worldIn.isRemote)
        {
        	WorldServer worldserver = (WorldServer) worldIn;
        	worldserver.getEntityFromUuid(TileEntityChair.ChairUUID).setDead();
        }
	super.onBlockDestroyedByPlayer(worldIn, pos, state);
}

@Override
public IBlockState onBlockPlaced(World worldIn, BlockPos pos, EnumFacing facing, float hitX, float hitY, float hitZ, int meta, EntityLivingBase placer) {
	IBlockState state = super.onBlockPlaced(worldIn, pos, facing, hitX, hitY, hitZ, meta, placer);
	return state.withProperty(FACING, placer.getHorizontalFacing());
}

    @Override
    public int getMetaFromState(IBlockState state) {
    	
    	return ((EnumFacing) state.getValue(FACING)).getHorizontalIndex();
    }
    
    @Override
    public IBlockState getStateFromMeta(int meta) {
    	
    	return this.getDefaultState().withProperty(FACING, EnumFacing.getHorizontal(meta));
    }
    
    @Override
    protected BlockState createBlockState() {
    	return new BlockState(this, new IProperty[] {FACING});
    }
}

[Phonixe]

I'm setting the UUID Field inside the TE, It is now no longer static but it seems like there is still the same issue, so i'm guessing i'm doing something wrong with setting the UUID field.

 

Here is one of the interractions with the entity :

@Override
public void onBlockPlacedBy(World worldIn, BlockPos pos, IBlockState state, EntityLivingBase placer, ItemStack stack) {
        if (!worldIn.isRemote)
        {
        TileEntityChair id = new TileEntityChair();
        WorldServer worldserver = (WorldServer) worldIn;
	worldIn.spawnEntityInWorld(worldserver.getEntityFromUuid(id.ChairUUID));
        }

	super.onBlockPlacedBy(worldIn, pos, state, placer, stack);
}

 

And this is the TE :

public class TileEntityChair extends TileEntity {

public UUID ChairUUID;

public void TileEntityChairID(UUID id)
    {
        id = new EntityChair(worldObj).getPersistentID();
        ChairUUID = id;
       
    }

}

[larsgerrits]

Why the hell do you create a new

TileEntity

and a new

Entity

? Get the existing ones from the world.

 

Also:

You can cache this value in your TE in a field, too, if you want, but you'll have to use a

WeakReference

to avoid memory leaks.

[Phonixe]

Get the existing ones from the world.

Sorry, I don't think i know how to do that..

[Draco18s]

world.getTileEntity for one....

You were told already how to do the other...

[Phonixe]

Okay, this is embarassing but it still doesn't work  ._.

 

Here's the TE:

public class TileEntityChair extends TileEntity {

public UUID ChairUUID;

public void TileEntityChairID(UUID uuid, World world, int id)
    {
	EntityChair entity = (EntityChair) world.getEntityByID(id);
        uuid = entity.getPersistentID();
        ChairUUID = uuid;
    }

And here's one of the interractions :

@Override
public void onBlockPlacedBy(World worldIn, BlockPos pos, IBlockState state, EntityLivingBase placer, ItemStack stack) {
        if (!worldIn.isRemote)
        {
        TileEntityChair id = (TileEntityChair) worldIn.getTileEntity(pos);
        WorldServer worldserver = (WorldServer) worldIn;
	worldIn.spawnEntityInWorld(worldserver.getEntityFromUuid(id.ChairUUID));
        }

	super.onBlockPlacedBy(worldIn, pos, state, placer, stack);
}

[XFactHD]

You need to create the entity when the block is placed, save its uuid to the tile entity by getting that from the world and retrieve the entity with the uuid from the world when a player sits down or when you need to kill the entity when the block is destroyed.

[Phonixe]

u_u

 

Interractions:

@Override
public void onBlockPlacedBy(World worldIn, BlockPos pos, IBlockState state, EntityLivingBase placer, ItemStack stack) {
        if (!worldIn.isRemote)
        {
        Entity entity = new EntityChair(worldIn, (double)pos.getX() + 0.5D, (double)pos.getY() + 0.5D, (double)pos.getZ() + 0.5D);
	worldIn.spawnEntityInWorld(entity);
        }

	super.onBlockPlacedBy(worldIn, pos, state, placer, stack);
}
@Override
public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn,EnumFacing side, float hitX, float hitY, float hitZ) {
	if (!worldIn.isRemote)
	{
		TileEntityChair id = (TileEntityChair) worldIn.getTileEntity(pos);
		WorldServer worldserver = (WorldServer) worldIn;
		playerIn.mountEntity(worldserver.getEntityFromUuid(id.ChairUUID));
	}
		return super.onBlockActivated(worldIn, pos, state, playerIn, side, hitX, hitY, hitZ);
}

@Override
public void onBlockDestroyedByPlayer(World worldIn, BlockPos pos, IBlockState state) {

        if (!worldIn.isRemote)
        {
        	TileEntityChair id = (TileEntityChair) worldIn.getTileEntity(pos);
        	WorldServer worldserver = (WorldServer) worldIn;
        	worldserver.getEntityFromUuid(id.ChairUUID).setDead();
        }
	super.onBlockDestroyedByPlayer(worldIn, pos, state);
}

 

TE:

public class TileEntityChair extends TileEntity {

public UUID ChairUUID;

public void TileEntityChairID(UUID uuid, World world, int id)
    {
	EntityChair entity = (EntityChair) world.getEntityByID(id);
        uuid = entity.getPersistentID();
        ChairUUID = uuid;
    }

}

[XFactHD]

After you spawned the entity, you need to put its uuid into the tile entity. And why the hell do you have that uuid stuff in the constructor?

[Draco18s]

Your TE's constructor must take 0 parameters or it will be unable to be recreated when the game is loaded from disk.

[Phonixe]

That isn't the constructor though is it?

[Phonixe]

Many thanks!! It works like a charm!!