[1.10.2] Modifying the enchantment levels based on the the player

[gibraltar]

I'd like to modify the enchantment levels offered in each slot (not the enchantments themselves), based on the player (NBT tags, or items they are carrying, etc.). After looking through the ContainerEnchantment and EnchantmentHelper classes, it appears the only way to do that currently would be with IClassTransformer. But that's a no-no.

 

So, is there a different way to do this that I'm missing? If not, how would I go about adding an event to forge to make this possible? I'd be happy if the normal calculation occured, and I could just modify the levels before the actual enchantments are calculated based on the level.

[Animefan8888]

I'd like to modify the enchantment levels offered in each slot (not the enchantments themselves), based on the player (NBT tags, or items they are carrying, etc.). After looking through the ContainerEnchantment and EnchantmentHelper classes, it appears the only way to do that currently would be with IClassTransformer. But that's a no-no.

 

So, is there a different way to do this that I'm missing? If not, how would I go about adding an event to forge to make this possible? I'd be happy if the normal calculation occured, and I could just modify the levels before the actual enchantments are calculated based on the level.

Two things come to my mind that must be done. Substitute the enchantments so they can have higher levels. And the second override ContainerEnchantment using ContainerEvent.Open by calling your open event.

 

Edit: To add a event to forge you need to go to there github (search for it) and then submit a pull request you should be able to find how to do that on their github.

[gibraltar]

The reason I'm asking about events is because I've already gone down the route of overriding the ContainerEnchantment class. To do what I'm trying to accomplish, I'd almost need to copy all of the code over (not super maintainable going forward), because I need to make minor changes inside the onCraftMatrixChanged method. And not at the beginning or end of it, or I could just call the base implementation. They have to fit in between the loop that calculates the enchant levels and the loop that uses those to get the actual enchantments. Unfortunately, it calls private methods and uses private fields, which won't be available. Making the whole thing quite hacky, if I can even get it to work.

 

 

[Animefan8888]

Post code, and private fields can be accessed through reflection; methods on the other hand should not be edited at all. Thus, the overriding the container by extending the container, you can submit a Pull Request on their github to add an event provide code and I think a patch file.

[Draco18s]

The problem is not that the method he wants to override is private, but that that method invokes other methods which are private.  So to duplicate the base (public) function he needs to duplicate several private methods as well.

 

I'd suggest a forge PR that makes those methods and fields protected.

[gibraltar]

Thanks for the suggestions, guys. I dove into the Forge code yesterday and came up with a PR that adds the event I want: https://github.com/MinecraftForge/MinecraftForge/pull/3373. Hopefully, it will make it into the product soon. Feels good to give a little back (and also scratch my own itch).

[Draco18s]

Looks good, but for one thing that I made a comment about.