Draco18s Posted November 25, 2016 Share Posted November 25, 2016 So something occurred to me recently. ItemHandlers need to be exposed for both input and output. In order to prevent an item from being inserted into an "output" slot, setting up a custom ItemHandler class to always return the item inserted into it seems to make sense. Expose for extraction, forbid insertion, seems reasonable. However. Now that means that a machine itself can't put items into its own output slot (other than by using setStackInSlot() which requires that it calculate the stack size manually). There's got to be a better way than this...what am I missing? Quote Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice. Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked. DO NOT PM ME WITH PROBLEMS. No help will be given. Link to comment Share on other sites More sharing options...
Animefan8888 Posted November 25, 2016 Share Posted November 25, 2016 So something occurred to me recently. ItemHandlers need to be exposed for both input and output. In order to prevent an item from being inserted into an "output" slot, setting up a custom ItemHandler class to always return the item inserted into it seems to make sense. Expose for extraction, forbid insertion, seems reasonable. However. Now that means that a machine itself can't put items into its own output slot (other than by using setStackInSlot() which requires that it calculate the stack size manually). There's got to be a better way than this...what am I missing? I kinda cheated when doing this, but for a furnace (something that has a specific output slot(s) I made it have an internal ID for properly inserting and if it was the normal id then I had it do nothing. @Override public ItemStack insertItem(int slot, ItemStack stack, boolean simulate) { if (slot == 2) return stack; if (slot == 3) slot--; if (canInsert(stack, slot)) { if (stacks[slot] == null) { if (!simulate) stacks[slot] = stack; return null; } if (stacks[slot].getItem() == stack.getItem() && stacks[slot].getMaxStackSize() >= stacks[slot].stackSize + stack.stackSize) { if (!simulate) stacks[slot].stackSize += stack.stackSize; return null; } else if (stacks[slot].getItem() == stack.getItem()){ int difference = stack.stackSize - (stacks[slot].getMaxStackSize() - (stacks[slot].stackSize + stack.stackSize)); if (!simulate) stacks[slot].stackSize += difference; stack.stackSize -= difference; } } return stack; } Feel free to optimize and give feedback (first time with IItemHandler). Quote VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect. Forge and vanilla BlockState generator. Link to comment Share on other sites More sharing options...
Draco18s Posted November 25, 2016 Author Share Posted November 25, 2016 Should just be able to call super.insertItem() at that point, no? Quote Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice. Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked. DO NOT PM ME WITH PROBLEMS. No help will be given. Link to comment Share on other sites More sharing options...
Animefan8888 Posted November 25, 2016 Share Posted November 25, 2016 Should just be able to call super.insertItem() at that point, no? This was straight from the interface ie new IItemHandlerModifiable() { // Methods }; Edit: But yes you should be able to. Quote VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect. Forge and vanilla BlockState generator. Link to comment Share on other sites More sharing options...
Draco18s Posted November 25, 2016 Author Share Posted November 25, 2016 This was straight from the interface ie Ah, gotcha. Quote Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice. Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked. DO NOT PM ME WITH PROBLEMS. No help will be given. Link to comment Share on other sites More sharing options...
desht Posted November 25, 2016 Share Posted November 25, 2016 How about having two ItemHandler objects: a private one (not exposed via capabilities), and a public one (exposed so that hoppers etc. can extract). The private item handler just allows items to be inserted normally, and that's what your machine would use to put items into it; a simple ItemStackHandler might suffice. The public handler would be a custom IItemHandler implementation which delegates everything to the private handler, with the exception of inserting items, which you make a no-op. And in your GUI, connect any Slots as needed to the public item handler to prevent manual insertion of items. Quote Link to comment Share on other sites More sharing options...
Draco18s Posted November 25, 2016 Author Share Posted November 25, 2016 Hmm. That sounds pretty reasonable, actually. Quote Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice. Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked. DO NOT PM ME WITH PROBLEMS. No help will be given. Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.