Jump to content

[1.10.2] FileNotFoundEx for native ResourceLoc, when using ResourcePack only


Matryoshika

Recommended Posts

Hello!

I'm making a mod that allows one to create blocks (so far) completely from json files. Very basic, nothing fancy, but valid blocks.

Models & blockstates are also handled "outside" the mod, in the config folder.

I've implemented IResourcePack, and throwing it into the List<IResourcePack> inside the Minecraft.class, during preInit. Everything works just fine, except that between Block registration (the new RegistryEvent way) & preInit, the ModelLoaderRegistry calls for "modid:models/item/<name>.json" which of course, due to the nature of this whole mod, will return a FileNotFoundException. This spams the client-side console, and that, in essence, is my issue. Unnecessary information in logs, especially when it is "fixed" just moments afterward, is detrimental.

 

What would one need to do, to stop the model from registering so soon? Or can I stop the ModelLoader from calling

modid:models/item/<block>

altogether, as that is handled separately by the ResourcePack?

Source-code can be found here: https://github.com/Matryoshika/Fabrica

 

Solved

Had to manually call

Minecraft#refreshResources()

to reload the IResourcePacks, before the ModelLoaderRegistry tries to load my models.

Also previously known as eAndPi.

"Pi, is there a station coming up where we can board your train of thought?" -Kronnn

Published Mods: Underworld

Handy links: Vic_'s Forge events Own WIP Tutorials.

Link to comment
Share on other sites

@SuppressWarnings? I have never made a mod like this, but it is a cool idea.

What?

How....

Do you know how Minecraft rendering works? Cause that answer infers the opposite...

 

Basic runthrough: for every registered block (& item, but skipping that) the ModelLoaderRegistry calls

getModel()

, which goes through all ModelLoaders (Obj, B3d, DynBucket are forge added ones, then there's custom modelloaders as well of course.) Last resort is the vanilla modelloader. This calls

SimpleReloadableResourceManager#getResource()

which, when eventually here, calls

FallbackResourceManager#getResource()

, which is what is printing the

FileNotFoundException

.

 

All of these classes, are vanilla Minecraft or Forge coded. Literally outside of my domain.

 

 

Hmmm...  Now that I think about it, I should be able to intercept it in FallbackResourceManager. It is getting all IResourcePack and iterating over them. Seems that I am registering my own IResourcePack a wee bit too late. Gonna see if I can add it earlier in the process.

Also previously known as eAndPi.

"Pi, is there a station coming up where we can board your train of thought?" -Kronnn

Published Mods: Underworld

Handy links: Vic_'s Forge events Own WIP Tutorials.

Link to comment
Share on other sites

I was thinking of adding @SuppressWarnings before your resource registration, but it was just a guess of what might work. I see you got it working, so I am eager to download your mod when it is finished!!

 

SuppressWarnings is like ignoring that light on your dash telling you to change the oil:

The car is going to catch fire and you're just ignoring it.

 

The only reason to use SuppressWarnings is when you know that there's a particular non-critical warning being thrown and that it's not actually a problem.  It doesn't fix the problem it just says "I don't wish to be informed."

 

FileNotFound is not a warning, it's an error.  The file isn't there, it wasn't loaded.  Ignoring it won't suddenly make the file load.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

because the errors are going to get fixed right afterward

 

This makes no sense.  The error is not thrown until after all the loaders have failed to load the file.  If the file is loaded at all then no error is thrown.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.