Jump to content

How can I create a display pillar block?


cj3636

Recommended Posts

Context:

I have a 'pillar' sort of block.

The player can right click it with an item/block and the item will placed for display on top of the block.

The player can then remove the item by right clicking again with an empty hand.

This works almost exactly like the jukebox only with the additional rendering of EntityItem on top of the block.

 

The problem:

Two or more Pillar blocks do not uniquely hold items.

An item can be placed on the first pillar...

once an item is placed on the second pillar, the first item is deleted (it stays rendered, but cannot be recovered) and the second item becomes the only one in existence. This continues for each additional pillar.

I have tried everything to fix this issue and can not seem to figure it out.

 

The tile entity is properly registered in the Common Proxy.

 

The Block:

public class ArcanePillarBlock extends BlockContainer {
    public static final PropertyBool HAS_DISPLAY = PropertyBool.create("has_display");

    public ArcanePillarBlock(String unlocalizedName, Material material, float hardness, float resistance) {
        super(material);
        this.setDefaultState(this.blockState.getBaseState().withProperty(HAS_DISPLAY, Boolean.valueOf(false)));
        this.setCreativeTab(Ref.CTAB);
        this.setUnlocalizedName(unlocalizedName);
        this.setRegistryName(unlocalizedName);
        this.setHardness(hardness);
        this.setResistance(resistance);
    }

    @Override
    public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn, EnumHand hand, @Nullable ItemStack heldItem, EnumFacing side, float hitX, float hitY, float hitZ) {
        if (state.getValue(HAS_DISPLAY).booleanValue()) {
            dropRecord(worldIn, pos, state, playerIn.getPosition());
        } else if (heldItem != null) {
            insertRecord(worldIn, pos, state, heldItem);
            if (!playerIn.capabilities.isCreativeMode) {
                heldItem.stackSize--;
            }
        }
        return true;
    }

    public void insertRecord(World worldIn, BlockPos pos, IBlockState state, ItemStack heldItem) {
        if (!worldIn.isRemote) {
            TileEntity tileentity = worldIn.getTileEntity(pos);

            if (tileentity instanceof ArcanePillarTileEntity) {
                ArcanePillarTileEntity arcaneTileEntity = (ArcanePillarTileEntity) tileentity;
                worldIn.setBlockState(pos, state.withProperty(HAS_DISPLAY, Boolean.valueOf(true)), 2);
                arcaneTileEntity.setDisplay(heldItem.copy());
            }
        }
    }

    private void dropRecord(World worldIn, BlockPos pos, IBlockState state, BlockPos spawnPos) {
        if (!worldIn.isRemote) {
            TileEntity tileentity = worldIn.getTileEntity(pos);

            if (tileentity instanceof ArcanePillarTileEntity) {
                ArcanePillarTileEntity arcaneTileEntity = (ArcanePillarTileEntity) tileentity;
                ItemStack itemstack = arcaneTileEntity.getDisplay();

                if (itemstack != null) {
                    arcaneTileEntity.setDisplay((ItemStack) null);
                    arcaneTileEntity.endDisplay();
                    ItemStack itemstack1 = itemstack.copy();
                    itemstack1.stackSize = 1;
                    EntityItem entityitem = new EntityItem(worldIn, spawnPos.getX(), spawnPos.getY(), spawnPos.getZ(), itemstack1);
                    entityitem.setDefaultPickupDelay();
                    worldIn.setBlockState(pos, state.withProperty(HAS_DISPLAY, Boolean.valueOf(false)), 2);
                    worldIn.spawnEntityInWorld(entityitem);
                }
            }
        }
    }

    @Override
    public void breakBlock(World worldIn, BlockPos pos, IBlockState state) {
        dropRecord(worldIn, pos, state, pos);
        super.breakBlock(worldIn, pos, state);
    }

    @Override
    public IBlockState getStateFromMeta(int meta) {
        return this.getDefaultState().withProperty(HAS_DISPLAY, Boolean.valueOf(meta > 0));
    }

    @Override
    public int getMetaFromState(IBlockState state) {
        return ((Boolean) state.getValue(HAS_DISPLAY)).booleanValue() ? 1 : 0;
    }

    @Override
    protected BlockStateContainer createBlockState() {
        return new BlockStateContainer(this, new IProperty[]{HAS_DISPLAY});
    }

    @Override
    public TileEntity createNewTileEntity(World worldIn, int meta) {
        return new ArcanePillarTileEntity();
    }

    @Override
    public EnumBlockRenderType getRenderType(IBlockState state) {
        return EnumBlockRenderType.MODEL;
    }

    @Override
    public boolean isOpaqueCube(IBlockState state) {
        return false;
    }

    @Override
    public boolean isFullCube(IBlockState state) {
        return false;
    }

    @Override
    @SideOnly(Side.CLIENT)
    public BlockRenderLayer getBlockLayer() {
        return BlockRenderLayer.TRANSLUCENT;
    }

    @Override
    @SideOnly(Side.CLIENT)
    public boolean shouldSideBeRendered(IBlockState blockState, IBlockAccess blockAccess, BlockPos pos, EnumFacing side) {
        return true;
    }

The Tile Entity:

public class ArcanePillarTileEntity extends TileEntity {
    private static ItemStack displayItem;
    private static EntityItem displayEntity;

    public void readFromNBT(NBTTagCompound compound) {
        super.readFromNBT(compound);

        if (compound.hasKey("DisplayItem", 10)) {
            this.setDisplay(ItemStack.loadItemStackFromNBT(compound.getCompoundTag("DisplayItem")));
        } else if (compound.getInteger("DisplayItem") > 0) {
            this.setDisplay(new ItemStack(Item.getItemById(compound.getInteger("Item"))));
        }
    }

    public NBTTagCompound writeToNBT(NBTTagCompound compound) {
        super.writeToNBT(compound);

        if (getDisplay() != null) {
            compound.setTag("DisplayItem", getDisplay().writeToNBT(new NBTTagCompound()));
        }

        return compound;
    }

    @Nullable
    public ItemStack getDisplay() {
        System.out.println(this);
        return this.displayItem;
    }

    public void setDisplay(@Nullable ItemStack itemStack) {
        this.displayItem = itemStack;
        if (itemStack != null) {
            ItemStack tempStack = new ItemStack(this.displayItem.getItem(), 1);
            this.displayEntity = new EntityItem(worldObj, pos.getX() + .5, pos.getY() + 1, pos.getZ() + .5, tempStack);
            this.displayEntity.setInfinitePickupDelay();
            this.displayEntity.setNoDespawn();
            this.displayEntity.setVelocity(0D, 0D, 0D);
            if (!worldObj.isRemote) {
                worldObj.spawnEntityInWorld(displayEntity);
            }
        }
        this.markDirty();
    }

    public void endDisplay() {
        this.displayEntity.setDead();
        this.displayItem = null;
        this.markDirty();
    }
}

Does anyone know of either a solution to my issue or possibly a better way to make an item display block?

Thanks for any help you can offer!

My GitHub with the rest of my code.

Link to comment
Share on other sites

Your ItemStack variables in your TileEntity are static, which means they are shared between every instance of the TileEntity.

Edited by larsgerrits

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

Just now, cj3636 said:

The pillar does not work at all when the variables are not set to static.

Then you're doing something wrong.  Mine isn't static.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
    • It is an issue with quark - update it to this build: https://www.curseforge.com/minecraft/mc-mods/quark/files/3642325
    • Remove Instant Massive Structures Mod from your server     Add new crash-reports with sites like https://paste.ee/  
    • Update your drivers: https://www.amd.com/en/support/graphics/amd-radeon-r9-series/amd-radeon-r9-200-series/amd-radeon-r9-280x
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.