IMessage not being sent

[Socratic_Phoenix]

I'm working on a mod that needs to send a seed (don't worry!! not the world seed!) from the server (or server thread) to the client (or client thread). I followed the tutorial in the forge docs on networking, but my packet isn't being sent properly, or received properly or something.

 

I register the channel like this:

package com.gmail.socraticphoenix.forge.randore.packet;

import net.minecraftforge.fml.common.network.NetworkRegistry;
import net.minecraftforge.fml.common.network.simpleimpl.SimpleNetworkWrapper;

public class RandoreNetworking {
    public static final SimpleNetworkWrapper INSTANCE = NetworkRegistry.INSTANCE.newSimpleChannel("randores");

}

 

This is my packet:

package com.gmail.socraticphoenix.forge.randore.packet;

import io.netty.buffer.ByteBuf;
import net.minecraftforge.fml.common.network.simpleimpl.IMessage;

public class RandorePacket implements IMessage {
    private long seed;

    public RandorePacket(long seed) {
        this.seed = seed;
    }

    public long getSeed() {
        return this.seed;
    }

    public void setSeed(long seed) {
        this.seed = seed;
    }

    @Override
    public void fromBytes(ByteBuf buf) {
        this.setSeed(buf.readLong());
    }

    @Override
    public void toBytes(ByteBuf buf) {
        buf.writeLong(this.getSeed());
    }
}

This is my handler:

package com.gmail.socraticphoenix.forge.randore.packet;

import com.gmail.socraticphoenix.forge.randore.Randores;
import net.minecraft.client.Minecraft;
import net.minecraftforge.fml.common.network.simpleimpl.IMessage;
import net.minecraftforge.fml.common.network.simpleimpl.IMessageHandler;
import net.minecraftforge.fml.common.network.simpleimpl.MessageContext;

public class RandorePacketHandler implements IMessageHandler<RandorePacket, IMessage> {

    @Override
    public IMessage onMessage(final RandorePacket message, MessageContext ctx) {
        Minecraft.getMinecraft().addScheduledTask(new Runnable() {
            @Override
            public void run() {
                Randores.getInstance().getLogger().info("Received seed information: " + message.getSeed());
            }
        });
        return null;
    }

}

I attempt to send the message like this:

RandoreNetworking.INSTANCE.sendToAll(new RandorePacket(world.getSeed()));

I have verified that this code is reached AND that it is called from the server thread. I am using the world seed for testing purposes.

 

I register the message like this:

RandoreNetworking.INSTANCE.registerMessage(RandorePacketHandler.class, RandorePacket.class, 0, Side.CLIENT);

I register this in the constructor. Perhaps that's the problem? (I'll try in init and pre init as well).

 

Thanks for any help!

[Awesome_Spider]

Where did you register your packet?

 

Edit: Oh wait, I see it now.

Edited February 14, 2017 by Awesome_Spider

[diesieben07]

IMessage classes must have a no-arg constructor.

[Awesome_Spider]

Can you show the code for the class where the packet is registered (not just the method you used for this)?

 

Edit: Sorry, I didn't see your post.

Edited February 14, 2017 by Awesome_Spider

[loordgek]

32 minutes ago, Socratic_Phoenix said:

package com.gmail.socraticphoenix.forge.randore.packet; import net.minecraftforge.fml.common.network.NetworkRegistry; import net.minecraftforge.fml.common.network.simpleimpl.SimpleNetworkWrapper; public class RandoreNetworking { public static final SimpleNetworkWrapper INSTANCE = NetworkRegistry.INSTANCE.newSimpleChannel("randores"); }

you never register the message

 

example

 

    private static final SimpleNetworkWrapper INSTANCE = NetworkRegistry.INSTANCE.newSimpleChannel(Reference.MODINFO.MOD_NAME);

    public static void initNetwork(){
        INSTANCE.registerMessage(GuiSyncPacket.class, GuiSyncPacket.class, ++NetID, Side.CLIENT);
    }

and call initNetwork in preinit

[Socratic_Phoenix]

25 minutes ago, loordgek said:

you never register the message

1 hour ago, Socratic_Phoenix said:

I register the message like this:

RandoreNetworking.INSTANCE.registerMessage(RandorePacketHandler.class, RandorePacket.class, 0, Side.CLIENT);

I register this in the constructor. Perhaps that's the problem? (I'll try in init and pre init as well).

Yes I do...

 

25 minutes ago, loordgek said:

and call initNetwork in preinit

Ok thanks!

56 minutes ago, diesieben07 said:

IMessage classes must have a no-arg constructor.

Ok thanks! But.... why?

[diesieben07]

5 minutes ago, Socratic_Phoenix said:

Ok thanks! But.... why?

So FML can create a new instance of the class when the message is received.

[Socratic_Phoenix]

Just now, diesieben07 said:

So FML can create a new instance of the class when the message is received.

That makes sense (grumbles about it being possible to map fields to the constructor)...

 

It does persist the fields though?

[Awesome_Spider]

Ya, sorry, I realized that later.

[Socratic_Phoenix]

Thanks everyone! It's working now!

[diesieben07]

55 minutes ago, Socratic_Phoenix said:

It does persist the fields though?

No, it only calls toBytes and fromBytes.

[Socratic_Phoenix]

17 minutes ago, diesieben07 said:

No, it only calls toBytes and fromBytes.

Of course, silly me!