Jump to content

[Solved] Water plant


MFMods

Recommended Posts

i'm making a few water plants.

 

checklist (for others that want to do the same):

* material set to water

* add LEVEL property (mandatory), you can just ignore it (i have variants too, that one gets saved)

* in client proxy, call ModelLoader.setCustomStateMapper to ignore the level property (one line there makes you not worry about level in the blockstate file; solution by choonster)


problem: plants look fine when deeper underwater (when there is at least one water source block above it).

but when the plant is right below surface, i don't have the surface part (see image).

 

for the model i used the "cross" model.

 

does anyone know what to do?

some other modders solved worked around the issue by insisting on one or more water blocks above and breaking the plant if water is for example picked up by a bucket.

i would prefer to allow plants to grow right below surface if possible.

2017-03-12_13.48.08.jpg

Edited by MFMods
adding solved tag to title
Link to comment
Share on other sites

1 hour ago, MFMods said:

for the model i used the "cross" model.

Well, the 'cross' model doesn't contain a water surface element, so of course it won't be there. You'll need to create a custom model for your plants to give the appearance of the water surface above the plant part. I have a similar water plant which I render using a multi-layer model, if you want to see how I do it: block class, blockstates, cutout model part, translucent model part.

 

render3.png

Link to comment
Share on other sites

hmm, that would solve my problem; more than one actually.

though i might have to bother with states regarding block above. oh well...

 

it's not a perfect solution - you should have used "minecraft:blocks/water_still" instead of your own png because of resource packs. also, i'm concerned as to how it would look in a biome with tinted water (we'll know tomorrow).

 

thanks a lot, friend!  you most likely lost many hours on that block.

 

btw, a rice plant that looks like actual rice? i salute thee. (i know, it sounds obvious that it should look like rice, but these days, rice blocks that i find in mods look like peas or kale).

  • Like 1
Link to comment
Share on other sites

to conclude the thread (for those who need the same thing):

 

jay's model works (mostly) - thanks again, man.

 

as to what else needs to be done, that kinda depends on modder's plans for the plant:

* biome tinting does not work... for now, i don't care (i wasn't going to allow either worlgen or seed  planting in swamps either way), but if mystcraft gets updated to 1.10+, then i would really care. so, if anyone knows what to do, by all means, share...

* bottom ("down") part of the top surface is needed so that we can properly see through the plant upwards diagonally (add a line to the model file).

* sides (water texture) are needed if you want plants too look ok in a big glass tank. if you don't care about glass, you can just omit sides and in can-block-stay method disallow it to stay next to non-solid surface blocks (ie. anyting except water material, full cubes and farmland/paths).

Link to comment
Share on other sites

3 minutes ago, MFMods said:

* biome tinting does not work... for now, i don't care (i wasn't going to allow either worlgen or seed  planting in swamps either way), but if mystcraft gets updated to 1.10+, then i would really care. so, if anyone knows what to do, by all means, share...

 

Set the tint index for each model face you want to be coloured at runtime and register an IBlockColor for the Block that returns the appropriate colour for each tint index depending on the location.

 

Look at BlockColors for vanilla examples.

  • Like 1

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

  • 4 months later...

Hey, I'm trying to do a similar thing in my own mod, how do I set the LEVEL property you describe in the first post?

At the moment my game crashes whenever I place the block, because it thinks its water due to the material and has nothing set for that.

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
    • It is an issue with quark - update it to this build: https://www.curseforge.com/minecraft/mc-mods/quark/files/3642325
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.