Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.11.2] Overridden methods being called twice


ctbe
 Share

Recommended Posts

I have an item tool that extends ItemPickaxe. Every method I override gets called twice. No matter which method it is. For example

override def onBlockDestroyed (stack: ItemStack, worldIn: World, state: IBlockState, pos: BlockPos, entityLiving: EntityLivingBase): Boolean = {
    System.out.println ("Block destroyed")
    return true;
  }

 

It doesn't matter if I return true or false. Neither it matters if I call super. It always gets called twice. This is Scala, but it also happens if I use Java. I take it the language doesn't matter. If I do

override def onItemUse(player: EntityPlayer, worldIn: World, pos: BlockPos, hand: EnumHand, facing: EnumFacing, hitX: Float, hitY: Float, hitZ: Float): EnumActionResult = {
      System.out.println ("Item used")
      return EnumActionResult.SUCCESS
  }

 

It also happens. Regardless of returning EnumActionResult.SUCCESS or EnumActionResult.FAIL or calling super.onItemUse(player, worldIn, pos, hand, facing, hitX, hitY, hitZ). I get double code execution.

 

All overridden methods are called twice. Is there any fix for this?

 

 

Edited by ctbe
Language code syntax highlighter change
Link to comment
Share on other sites

Thanks.

 

If I do

override def onBlockDestroyed(stack: ItemStack, worldIn: World, state: IBlockState, pos: BlockPos, entityLiving: EntityLivingBase): Boolean = {
	if (worldIn.isRemote) {
		System.out.println("Block destroyed")
		return true
	}
    return false
  }

 

Then it gets executed only once. Fixing my original problem. But now I have another doubt. Does this means that if someone installs my mod on a server, that println in this specific code or whatever is inside will not execute? I ask because according to https://mcforge.readthedocs.io/en/latest/concepts/sides/

Quote

It follows that the physical server will always contain false in this field...

 

And the definition of physical server is

Quote

Often known as the dedicated server, the physical server is the entire program that runs whenever you launch any sort of minecraft_server.jar that does not bring up a playable GUI.

 

I'm not sure if I should post a new thread for this other question that arose connected to my original problem since my original problem is solved.

Link to comment
Share on other sites

8 minutes ago, ctbe said:

Does this means that if someone installs my mod on a server, that println in this specific code or whatever is inside will not execute?

Yes, because you are checking for a client world here. A client world can only exist on an actual client. A server world can exist in a logical server, which is either an integrated one (single player) or a dedicated one.

Link to comment
Share on other sites

Quote

/**
 * True if the world is a 'slave' client; changes will not be saved or propagated from this world. For example,
 * server worlds have this set to false, client worlds have this set to true.
 */

the javadoc for isRemote

if you want it on the server side you need to do it like so    if (!worldIn.isRemote)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • When i launch forge-1.16.5-36.2.23.jar eula.txt doesnt come but in older version like 1.12.2 it comes idk why. do you guys know how i can fix this ?
    • MegaMiner is just my playground mod. Here's the entire MegaMinerEvents class. It's just a static event receiver.   package nu.rydin.explodingarrows.common.events; import net.minecraft.core.BlockPos; import net.minecraft.nbt.CompoundTag; import net.minecraft.nbt.Tag; import net.minecraft.world.entity.player.Player; import net.minecraft.world.level.Level; import net.minecraft.world.level.LevelAccessor; import net.minecraft.world.level.block.Block; import net.minecraft.world.level.block.state.BlockState; import net.minecraftforge.event.TickEvent; import net.minecraftforge.event.world.BlockEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.fml.common.Mod; import nu.rydin.explodingarrows.common.Main; import nu.rydin.explodingarrows.common.enchantments.ModEnchantments; import java.util.LinkedList; @Mod.EventBusSubscriber(modid = Main.MOD_ID, bus = Mod.EventBusSubscriber.Bus.FORGE) public class MegaMinerEvents { private static final class BlockToBreak { private final BlockPos pos; private final Player player; public BlockToBreak(final BlockPos pos, final Player player) { this.pos = pos; this.player = player; } } private static final LinkedList<BlockToBreak> queue = new LinkedList<>(); @SubscribeEvent public static void onBreakBlock(final BlockEvent.BreakEvent e) { final LevelAccessor world = e.getWorld(); if (world.isClientSide()) { return; } for (final Tag t : e.getPlayer().getMainHandItem().getEnchantmentTags()) { final CompoundTag ct = (CompoundTag) t; if (ct.getString("id") .equals(ModEnchantments.MEGA_MINER.get().getRegistryName().toString())) { MegaMinerEvents.mineNeighborhood(e.getPos(), e.getPlayer(), e.getState().getBlock()); } } } @SubscribeEvent public static void onTick(final TickEvent.ServerTickEvent e) { if (MegaMinerEvents.queue.isEmpty()) { return; } final BlockToBreak b = MegaMinerEvents.queue.removeFirst(); final Level world = b.player.level; final BlockState bs = world.getBlockState(b.pos); bs.getBlock().playerDestroy(world, b.player, b.pos, bs, null, b.player.getMainHandItem()); world.removeBlock(b.pos, true); // MegaMinerEvents.mineNeighborhood(b.pos, b.player, bs.getBlock()); System.out.println(MegaMinerEvents.queue.size()); } private static void mineNeighborhood( final BlockPos pos, final Player player, final Block blockType) { final float x0 = pos.getX(); final float y0 = pos.getY(); final float z0 = pos.getZ(); for (float z = z0 - 1.0F; z <= z0 + 1; z += 1.0) { for (float y = y0 - 1.0F; y <= y0 + 1; y += 1.0) { for (float x = x0 - 1.0F; x <= x0 + 1; x += 1.0) { final BlockState b = player.getLevel().getBlockState(pos); if (b.is(blockType)) { MegaMinerEvents.queue.addLast(new BlockToBreak(pos, player)); } } } } } }  
    • i am playing modded and NOT ON A SERVER but everytime i join a world my game crashes and the error message is: Exception in server tick loop  
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.