Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[SOLVED] [1.12] Missing block textures


zennyrpg
 Share

Recommended Posts

So I'm upgrading from 1.10.2 and I'm getting the missing purple/black texture for all my blocks.  I've tried to follow all the guides/ examples for registering blocks/ items, but I'm clearly missing some key part?  I created an example mod to distill my problem down.  Could someone point out why the textures are missing from this block?

 

ExampleMod.java

@Mod(modid = ExampleMod.MODID, version = ExampleMod.VERSION)
@Mod.EventBusSubscriber
public class ExampleMod
{
    public static final String MODID = "examplemod";
    public static final String VERSION = "1.0";
	public static ExampleBlock exampleBlock;
  
    
    @EventHandler
    public void preInit(FMLPreInitializationEvent event) 
    {
    	exampleBlock = new ExampleBlock();
    	exampleBlock.setRegistryName(MODID, "exampleblock");
    }
    
    @SubscribeEvent
    public void registerBlocks(RegistryEvent.Register<Block> event) {
        event.getRegistry().register(exampleBlock);
    }
    
    @SubscribeEvent
	public static void registerItems(RegistryEvent.Register<Item> event)
	{
    	event.getRegistry().register(new ItemBlock(exampleBlock).setRegistryName(exampleBlock.getRegistryName()));
	}

    @SubscribeEvent
    public void registerModels(ModelRegistryEvent event) {
    	ModelLoader.setCustomModelResourceLocation(Item.getItemFromBlock(exampleBlock), 0, new ModelResourceLocation(exampleBlock.getRegistryName(),"inventory"));
    }
}

 

ExampleBlock.java

public class ExampleBlock extends BlockClay {

	protected ExampleBlock() {
		super();
		this.setUnlocalizedName("exampleblock");
	}
}

 

assets/examplemod/blockstates/exampleblock.json

{
    "variants": {
        "normal": { "model": "examplemod:exampleblock" }
    }
}

 

assets/examplemod/models/block/exampleblock.json

{
    "parent": "block/cube_all",
    "textures": {
        "all": "examplemod:blocks/exampleblock"
    }
}

 

assets/examplemod/models/item/exampleblock.json

{
    "parent": "examplemod:block/exampleblock",
    "display": {
        "thirdperson": {
            "rotation": [ 10, -45, 170 ],
            "translation": [ 0, 1.5, -2.75 ],
            "scale": [ 0.375, 0.375, 0.375 ]
        }
    }
}

 

I have the texture saved at assets/examplemod/textures/blocks/exampleblock.png 

Edited by zennyrpg
Link to comment
Share on other sites

I'm pretty sure you actually need a block .json in the item models folder, so that can go.

The ModelResourceLocation "new ModelResourceLocation(block.getUnlocalizedName().substring(5))" works for me.

Before you get any farther, let me warn you: Any declarations involving ModelLoader must be done on the client side, or else they will crash the server. Look at this file here (and maybe the whole repostiory) and see if you can mold your mod to reflect its structure.

https://github.com/Choonster-Minecraft-Mods/TestMod3/blob/1.12/src/main/java/choonster/testmod3/client/model/ModModelManager.java?utf8=✓

Link to comment
Share on other sites

@jonesto95

Deleting  assets/examplemod/models/item/exampleblock.json didn't fix this.  I'm not sure if i need that file, but its not what is causing this problem.

 

I looked at the link and its way too complicated for what i'm trying to do.  I'm not trying to write a whole generic model loading system.  I just want one block to show up skinned, which is why I made this toy project.  As far as I can tell, I'm already doing everything I need to do.

I'm

1) registering the block in registerBlocks

2) registering the item in registerItems

3) registering the item's model in registerModels

This is all according to http://mcforge.readthedocs.io/en/latest/concepts/registries/

 

Do you know what step I could be missing?

Edited by zennyrpg
Link to comment
Share on other sites

ModelLoader.setCustomModelResourceLocation(..., new ModelResourceLocation(...,"inventory"))

You have told Minecraft to look for an "inventory" variant.

{
    "variants": {
        "normal": { "model": "examplemod:exampleblock" }
    }
}

You have specified a "normal" variant.

 

You have not specified a default model.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

@Draco18s Thanks.  It actually works as is, weirdly?  But I think you are right that that is the proper way to specify the json so I'll experiment with changing it.

 

----

 

So I figured out what was wrong.  Apparently, @Mod.EventBusSubscriber subscribes the class to registerBlocks(RegistryEvent.Register<Block> event) and registerItems(RegistryEvent.Register<Item> event) but not registerModels(ModelRegistryEvent event).  So registerModels was not being called.  I had to MinecraftForge.EVENT_BUS.register(this) in preInit to get registerModels to fire.

 

Of course this should be broken up into separate classes and all that jazz for a real mod, but the toy implementation works now.

Link to comment
Share on other sites

I want to redo my ultraflexible registration system to use the new events, but it's going to be tough.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

3 hours ago, zennyrpg said:

So I figured out what was wrong.  Apparently, @Mod.EventBusSubscriber subscribes the class to registerBlocks(RegistryEvent.Register<Block> event) and registerItems(RegistryEvent.Register<Item> event) but not registerModels(ModelRegistryEvent event).  So registerModels was not being called.  I had to MinecraftForge.EVENT_BUS.register(this) in preInit to get registerModels to fire.

 

@Mod.EventBusSubscriber will register the Class object with the Forge event bus, which means that any static @SubscribeEvent methods will be registered.

 

Registering an instance of the class with the Forge event bus will register any non-static @SubscribeEvent methods.

 

I suspect your ModelRegistryEvent handler method wasn't static, so it wasn't being registered by @Mod.EventBusSubscriber.

 

Forge's documentation explains events in more detail here.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.