Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.12] Item Variants : NullPointerException at getUnlocalizedName


Dylem
 Share

Recommended Posts

Hello, I tried to make variants for an item and I get a NullPointerException from this function (which is taken from ItemDye class) :

 

@Override
public String getUnlocalizedName(ItemStack stack) {

  int i = stack.getMetadata();
  return super.getUnlocalizedName() + "." + EnumVariant.byMetadata(i).getName();
}

 

However, when I remove the function, my 3 variants have the same unlocalized name so it doesn't load textures or names.

 

Crash logs : https://pastebin.com/WcPiNHMb

Full project code on github : https://github.com/dylem/DylemTestMod

Link to comment
Share on other sites

4 minutes ago, Dylem said:

Hello, I tried to make variants for an item and I get a NullPointerException from this function (which is taken from ItemDye class) :

 


@Override
public String getUnlocalizedName(ItemStack stack) {

  int i = stack.getMetadata();
  return super.getUnlocalizedName() + "." + EnumVariant.byMetadata(i).getName();
}

 

However, when I remove the function, my 3 variants have the same unlocalized name so it doesn't load textures or names.

 

Crash logs : https://pastebin.com/WcPiNHMb

Full project code on github : https://github.com/dylem/DylemTestMod

You never put any values in your EnumVariant.META_LOOKUP. You very well could use the EnumVariant#values()

  • Like 1

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

The logging of missing models was broken in Forge 1.12-14.21.0.2363 (commit dc043ac) and fixed in Forge 1.12-14.21.1.2390 (commit ede05a2). Update Forge and run Minecraft again to see the model errors.

Edited by Choonster
Fixed broken link.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

3 hours ago, Choonster said:

The logging of missing models was broken in Forge 1.12-14.21.0.2363 (commit dc043ac) and fixed in Forge 1.12-14.21.1.2390 (commit ede05a2). Update Forge and run Minecraft again to see the model errors.

Thanks, I get the error now. Here it is : https://pastebin.com/0yRa9HMw

Apparently it says it doesn't find the file item_variants.json.

I thought I only needed the jsons for the variants ? I'm a bit confused. Do I need to set the first variant as the "base" and redirect to the other variants from its json ?

Link to comment
Share on other sites

As you can see in the log it cannot find the variant you specified. You specified "item_variants_c" as the variant, which you cannot satisfy with just an item model file, those always use "inventory" as the variant. You must use a blockstate json to specify a different variant.

Link to comment
Share on other sites

I made a blockstate but still get the same errors of missing models.

 

@Choonster how do you have no models for your variants in your testmod3 mod and still get it working with blockstates only ? I tried to do the same and get an incredible ammount of errors...

 

Edited by Dylem
Link to comment
Share on other sites

7 minutes ago, Dylem said:

I made a blockstate but still get the same errors of missing models.

 

@Choonster how do you have no models for your variants in your testmod3 mod and still get it working with blockstates only ? I tried to do the same and get an incredible ammount of errors...

 

 

Forge will automatically try to load the model you've specified for an Item from a blockstates file when it can't find an item model with that name. I have a more detailed description of the model loading process and how ModelResourceLocations are mapped to models here.

 

Are you sure you have a blockstates file called assets/test_mod/blockstates/item_variants.json with the variants test_mod:item_variants_atest_mod:item_variants_b and test_mod:item_variants_c? Variants don't usually have a domain, they're just a single string.

 

Post your blockstates file and its path.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

30 minutes ago, Choonster said:

 

Forge will automatically try to load the model you've specified for an Item from a blockstates file when it can't find an item model with that name. I have a more detailed description of the model loading process and how ModelResourceLocations are mapped to models here.

 

Are you sure you have a blockstates file called assets/test_mod/blockstates/item_variants.json with the variants test_mod:item_variants_atest_mod:item_variants_b and test_mod:item_variants_c? Variants don't usually have a domain, they're just a single string.

 

Post your blockstates file and its path.

private void registerItemModelForMeta(final Item item, final int metadata, final ModelResourceLocation modelResourceLocation) {
	    	
	System.out.println(modelResourceLocation.toString());
	ModelLoader.setCustomModelResourceLocation(item, metadata, modelResourceLocation);
}

That prints :

[15:04:37] [main/INFO] [STDOUT]: [net.dylem.test_mod.init.ModItems$ModelHandler:registerItemModelForMeta:146]: test_mod:item_variants#test_mod:item_variants=a
[15:04:37] [main/INFO] [STDOUT]: [net.dylem.test_mod.init.ModItems$ModelHandler:registerItemModelForMeta:146]: test_mod:item_variants#test_mod:item_variants=b
[15:04:37] [main/INFO] [STDOUT]: [net.dylem.test_mod.init.ModItems$ModelHandler:registerItemModelForMeta:146]: test_mod:item_variants#test_mod:item_variants=c

 

Here is the json :

{
    "forge_marker": 1,
    "defaults": {
        "model": "item/generated"
    },
    "variants": {
        "variant": {
            "a": {
                "textures": {
                    "layer0": "test_mod:items/variants.a"
                }
            },
            "b": {
                "textures": {
                    "layer0": "test_mod:items/variants.b"
                }
            },
            "c": {
                "textures": {
                    "layer0": "test_mod:items/variants.c"
                }
            }
        }
    }
}

From what you did in your mod, that should work, shouldn't it ?

Link to comment
Share on other sites

Your JSON specifies 3 variants: "variant=a", "variant=b" and "variant=c". You tell Minecraft to load "test_mod:item_variants=a", "test_mod:item_variants=b" and "test_mod:item_variants=c".

Not sure what you expected but a "hey, I cannot find what you told me to load".

 

Always keep in mind: Variant strings are not specially parsed. They are simple strings. They either match exactly, or they don't.

Edited by diesieben07
Link to comment
Share on other sites

31 minutes ago, diesieben07 said:

Your JSON specifies 3 variants: "variant=a", "variant=b" and "variant=c". You tell Minecraft to load "test_mod:item_variants=a", "test_mod:item_variants=b" and "test_mod:item_variants=c".

Not sure what you expected but a "hey, I cannot find what you told me to load".

 

Always keep in mind: Variant strings are not specially parsed. They are simple strings. They either match exactly, or they don't.

Choonster did exactly what I did and it works for him, that's why I'm confused.

I tried to replace "variant" by "test_mod:item_variants", or just "item_variants" and it doesn't work either.

 

{
    "forge_marker": 1,
    "defaults": {
        "model": "test_mod:item/generated"
    },
    "variants": {
        "test_mod:item_variants": {
            "a": {
                "textures": {
                    "layer0": "test_mod:items/variants.a"
                }
            },
            "b": {
                "textures": {
                    "layer0": "test_mod:items/variants.b"
                }
            },
            "c": {
                "textures": {
                    "layer0": "test_mod:items/variants.c"
                }
            }
        }
    }
}

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Thanks for your reply! I have done it using data generation now. It works well for world generation, and I have realised that I don't care about saplings, so it works well. For anyone looking to do something similar, I include files to show what I did. They are just a bit hacky and incomplete now, but they can probably easily be generalised.   import static net.anju.larus.data.ResourceLocationUtil.prefix; import static net.anju.larus.data.ResourceLocationUtil.slash; @MethodsReturnNonnullByDefault @ParametersAreNonnullByDefault public abstract class LarusFeatureProvider<T> implements DataProvider { private static final Gson GSON = new GsonBuilder().setPrettyPrinting().disableHtmlEscaping().create(); protected final Set<FeatureEntry> featureEntries = new HashSet<>(); private final DataGenerator generator; protected LarusFeatureProvider(DataGenerator generator, Registry<T> registry) { this.generator = generator; for (Map.Entry<ResourceKey<T>, T> entry : registry.entrySet()) { ResourceKey<T> key = entry.getKey(); T feature = entry.getValue(); JsonElement jsonElement = getJson(feature); if (jsonElement != null) { FeatureEntry featureEntry = new FeatureEntry(prefix(key.location(), key.getRegistryName()), jsonElement); featureEntries.add(featureEntry); } } } private void addFeatures() { for (FeatureEntry featureEntry : featureEntries) { modifyFeatureEntry(featureEntry); } } protected abstract void modifyFeatureEntry(FeatureEntry featureEntry); @Override public void run(HashCache cache) { addFeatures(); writeFiles(cache, this.generator.getOutputFolder(), featureEntries); } // Actually write out the tables in the output folder private static void writeFiles(HashCache cache, Path outputFolder, Set<FeatureEntry> featureEntries) { for (FeatureEntry featureEntry : featureEntries) { if (featureEntry.isModified()) { ResourceLocation key = featureEntry.resourceLocation; JsonElement jsonElement = featureEntry.jsonElement; Path path = getPath(outputFolder, key); try { DataProvider.save(GSON, cache, jsonElement, path); } catch (IOException e) { LarusMod.LOGGER.error("Couldn't write data {}", key, e); } } } } @Override public String getName() { return "Larus features"; } @Nullable public JsonElement getJson(T feature) { if (feature instanceof ConfiguredFeature<?, ?> configuredFeature) { Optional<JsonElement> optional = ConfiguredFeature.DIRECT_CODEC.encodeStart(JsonOps.INSTANCE, configuredFeature).result(); return optional.orElse(null); } return null; } public static Path getPath(Path outputFolder, ResourceLocation key) { return outputFolder.resolve("data/" + slash(key) + ".json"); } protected static class FeatureEntry { boolean modified = false; private final ResourceLocation resourceLocation; private final JsonElement jsonElement; private FeatureEntry(ResourceLocation resourceLocation, JsonElement jsonElement) { this.resourceLocation = resourceLocation; this.jsonElement = jsonElement; } public JsonElement getJsonElement() { return jsonElement; } protected void markModified() { this.modified = true; } private boolean isModified() { return this.modified; } } } public class LarusLeavesFeatureProvider extends LarusFeatureProvider<ConfiguredFeature<?, ?>> { public LarusLeavesFeatureProvider(DataGenerator generator) { super(generator, BuiltinRegistries.CONFIGURED_FEATURE); } @Override protected void modifyFeatureEntry(FeatureEntry featureEntry) { JsonElement jsonElement = featureEntry.getJsonElement(); if (jsonElement.isJsonObject()) { JsonObject jsonObject = jsonElement.getAsJsonObject(); if (jsonObject.has("config")) { JsonObject config = jsonObject.get("config").getAsJsonObject(); if (config.has("foliage_provider")) { JsonObject mcFoliage = config.get("foliage_provider").getAsJsonObject(); JsonObject larusFoliage = larusFoliage(mcFoliage); if (larusFoliage != null) { config.add("foliage_provider", larusFoliage); featureEntry.markModified(); } } } } } @Nullable protected JsonObject larusFoliage(JsonObject mcFoliage) { JsonElement type = mcFoliage.get("type"); if (type.getAsString().equals("minecraft:simple_state_provider")) { JsonObject state = mcFoliage.get("state").getAsJsonObject(); // Change leaves String mcLeaves = state.get("Name").getAsString(); LarusLeavesBlock larusLeavesBlock = larusLeavesBlock(mcLeaves); if (larusLeavesBlock == null || larusLeavesBlock.getRegistryName() == null) return null; String larusLeaves = larusLeavesBlock.getRegistryName().toString(); state.add("Name", new JsonPrimitive(larusLeaves)); // Transform properties JsonObject mcProperties = state.get("Properties").getAsJsonObject(); transformProperties(mcProperties, larusLeavesBlock); } else { LarusMod.LOGGER.warn("Unexpected type for MC foliage " + mcFoliage); } return mcFoliage; } protected void transformProperties(JsonObject properties, LarusLeavesBlock larusLeavesBlock) { if (larusLeavesBlock instanceof LarusDeciduousLeavesBlock) properties.add("leafy", new JsonPrimitive("green")); } @Nullable protected LarusLeavesBlock larusLeavesBlock(String mcLeaves) { switch (mcLeaves) { case "minecraft:oak_leaves" -> { return LarusBlocks.OAK_LEAVES.get(); } case "minecraft:birch_leaves" -> { return LarusBlocks.BIRCH_LEAVES.get(); } case "minecraft:acacia_leaves" -> { return LarusBlocks.ACACIA_LEAVES.get(); } case "minecraft:jungle_leaves" -> { return LarusBlocks.JUNGLE_LEAVES.get(); } case "minecraft:dark_oak_leaves" -> { return LarusBlocks.DARK_OAK_LEAVES.get(); } case "minecraft:spruce_leaves" -> { return LarusBlocks.SPRUCE_LEAVES.get(); } } return null; } }  
    • the reason for that is the PlayerModel positions and rotations are set after the RenderPlayerEvent.Pre is fired change to Event to RenderPlayerEvent.Post
    • you can use BiomeLoadingEvent, loop through the Features you get from the Event and remove the Feature if it's the AmethystGeode Feature
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.