Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.12] Item Variants : NullPointerException at getUnlocalizedName


Dylem
 Share

Recommended Posts

Hello, I tried to make variants for an item and I get a NullPointerException from this function (which is taken from ItemDye class) :

 

@Override
public String getUnlocalizedName(ItemStack stack) {

  int i = stack.getMetadata();
  return super.getUnlocalizedName() + "." + EnumVariant.byMetadata(i).getName();
}

 

However, when I remove the function, my 3 variants have the same unlocalized name so it doesn't load textures or names.

 

Crash logs : https://pastebin.com/WcPiNHMb

Full project code on github : https://github.com/dylem/DylemTestMod

Link to comment
Share on other sites

4 minutes ago, Dylem said:

Hello, I tried to make variants for an item and I get a NullPointerException from this function (which is taken from ItemDye class) :

 


@Override
public String getUnlocalizedName(ItemStack stack) {

  int i = stack.getMetadata();
  return super.getUnlocalizedName() + "." + EnumVariant.byMetadata(i).getName();
}

 

However, when I remove the function, my 3 variants have the same unlocalized name so it doesn't load textures or names.

 

Crash logs : https://pastebin.com/WcPiNHMb

Full project code on github : https://github.com/dylem/DylemTestMod

You never put any values in your EnumVariant.META_LOOKUP. You very well could use the EnumVariant#values()

  • Like 1

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

The logging of missing models was broken in Forge 1.12-14.21.0.2363 (commit dc043ac) and fixed in Forge 1.12-14.21.1.2390 (commit ede05a2). Update Forge and run Minecraft again to see the model errors.

Edited by Choonster
Fixed broken link.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

3 hours ago, Choonster said:

The logging of missing models was broken in Forge 1.12-14.21.0.2363 (commit dc043ac) and fixed in Forge 1.12-14.21.1.2390 (commit ede05a2). Update Forge and run Minecraft again to see the model errors.

Thanks, I get the error now. Here it is : https://pastebin.com/0yRa9HMw

Apparently it says it doesn't find the file item_variants.json.

I thought I only needed the jsons for the variants ? I'm a bit confused. Do I need to set the first variant as the "base" and redirect to the other variants from its json ?

Link to comment
Share on other sites

As you can see in the log it cannot find the variant you specified. You specified "item_variants_c" as the variant, which you cannot satisfy with just an item model file, those always use "inventory" as the variant. You must use a blockstate json to specify a different variant.

Link to comment
Share on other sites

I made a blockstate but still get the same errors of missing models.

 

@Choonster how do you have no models for your variants in your testmod3 mod and still get it working with blockstates only ? I tried to do the same and get an incredible ammount of errors...

 

Edited by Dylem
Link to comment
Share on other sites

7 minutes ago, Dylem said:

I made a blockstate but still get the same errors of missing models.

 

@Choonster how do you have no models for your variants in your testmod3 mod and still get it working with blockstates only ? I tried to do the same and get an incredible ammount of errors...

 

 

Forge will automatically try to load the model you've specified for an Item from a blockstates file when it can't find an item model with that name. I have a more detailed description of the model loading process and how ModelResourceLocations are mapped to models here.

 

Are you sure you have a blockstates file called assets/test_mod/blockstates/item_variants.json with the variants test_mod:item_variants_atest_mod:item_variants_b and test_mod:item_variants_c? Variants don't usually have a domain, they're just a single string.

 

Post your blockstates file and its path.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

30 minutes ago, Choonster said:

 

Forge will automatically try to load the model you've specified for an Item from a blockstates file when it can't find an item model with that name. I have a more detailed description of the model loading process and how ModelResourceLocations are mapped to models here.

 

Are you sure you have a blockstates file called assets/test_mod/blockstates/item_variants.json with the variants test_mod:item_variants_atest_mod:item_variants_b and test_mod:item_variants_c? Variants don't usually have a domain, they're just a single string.

 

Post your blockstates file and its path.

private void registerItemModelForMeta(final Item item, final int metadata, final ModelResourceLocation modelResourceLocation) {
	    	
	System.out.println(modelResourceLocation.toString());
	ModelLoader.setCustomModelResourceLocation(item, metadata, modelResourceLocation);
}

That prints :

[15:04:37] [main/INFO] [STDOUT]: [net.dylem.test_mod.init.ModItems$ModelHandler:registerItemModelForMeta:146]: test_mod:item_variants#test_mod:item_variants=a
[15:04:37] [main/INFO] [STDOUT]: [net.dylem.test_mod.init.ModItems$ModelHandler:registerItemModelForMeta:146]: test_mod:item_variants#test_mod:item_variants=b
[15:04:37] [main/INFO] [STDOUT]: [net.dylem.test_mod.init.ModItems$ModelHandler:registerItemModelForMeta:146]: test_mod:item_variants#test_mod:item_variants=c

 

Here is the json :

{
    "forge_marker": 1,
    "defaults": {
        "model": "item/generated"
    },
    "variants": {
        "variant": {
            "a": {
                "textures": {
                    "layer0": "test_mod:items/variants.a"
                }
            },
            "b": {
                "textures": {
                    "layer0": "test_mod:items/variants.b"
                }
            },
            "c": {
                "textures": {
                    "layer0": "test_mod:items/variants.c"
                }
            }
        }
    }
}

From what you did in your mod, that should work, shouldn't it ?

Link to comment
Share on other sites

Your JSON specifies 3 variants: "variant=a", "variant=b" and "variant=c". You tell Minecraft to load "test_mod:item_variants=a", "test_mod:item_variants=b" and "test_mod:item_variants=c".

Not sure what you expected but a "hey, I cannot find what you told me to load".

 

Always keep in mind: Variant strings are not specially parsed. They are simple strings. They either match exactly, or they don't.

Edited by diesieben07
Link to comment
Share on other sites

31 minutes ago, diesieben07 said:

Your JSON specifies 3 variants: "variant=a", "variant=b" and "variant=c". You tell Minecraft to load "test_mod:item_variants=a", "test_mod:item_variants=b" and "test_mod:item_variants=c".

Not sure what you expected but a "hey, I cannot find what you told me to load".

 

Always keep in mind: Variant strings are not specially parsed. They are simple strings. They either match exactly, or they don't.

Choonster did exactly what I did and it works for him, that's why I'm confused.

I tried to replace "variant" by "test_mod:item_variants", or just "item_variants" and it doesn't work either.

 

{
    "forge_marker": 1,
    "defaults": {
        "model": "test_mod:item/generated"
    },
    "variants": {
        "test_mod:item_variants": {
            "a": {
                "textures": {
                    "layer0": "test_mod:items/variants.a"
                }
            },
            "b": {
                "textures": {
                    "layer0": "test_mod:items/variants.b"
                }
            },
            "c": {
                "textures": {
                    "layer0": "test_mod:items/variants.c"
                }
            }
        }
    }
}

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • check if your event is getting fired, first (and you must be in 3rd person on singleplayer for it to work). second, modifying those values doesn't do anything. It is already rendered (in post) or the values will be overwritten for rendering (in pre). You need to cancel the rendering and do it yourself. I do it with the field model#visible = false in pre, then in post, set it to true, then modify the rotation points and angles, then render it using the render method that takes the buffer, vertex builder, ... it would be much easier to use rightArmPose = ... in PRE. 
    • Have you registered your class as EventBusSubscriber on the correct bus?
    • Nope, 1.16 is going to stay as LTS and 1.17 is getting a 1 month grace period.
    • I downloaded ATM7 on the curseforge launcher and installed it, I can launch it and play it just fine the first time. I can play for as long as I want; when I close the game and exit I can re-launch the game just fine. I turn my PC off and back on again in the morning and try to launch it, that's when it errors out and can't "complete the mod scan". The only way around it I've found is making a new profile for it in curseforge, basically re-downloading it and playing it for "the first time" again. I have a RTX 2080 Ti Strix, an i5 8600K and 32 GB of ram with 8 GB allocated to Minecraft. The crash report as follows:  ---- Minecraft Crash Report ---- // Shall we play a game? Time: 11/30/21, 12:09 PM Description: Initializing game java.lang.IllegalStateException: Failed to complete mod scan     at net.minecraftforge.fml.loading.moddiscovery.BackgroundScanHandler.waitForScanToComplete(BackgroundScanHandler.java:103) ~[fmlloader-1.17.1-37.0.109.jar%2322!:?] {}     at net.minecraftforge.fml.ModLoader.gatherAndInitializeMods(ModLoader.java:153) ~[fmlcore-1.17.1-37.0.109.jar%23218!:?] {}     at net.minecraftforge.fmlclient.ClientModLoader.lambda$begin$1(ClientModLoader.java:108) ~[forge-1.17.1-37.0.109-universal.jar%23221!:?] {re:classloading,pl:runtimedistcleaner:A}     at net.minecraftforge.fmlclient.ClientModLoader.lambda$createRunnableWithCatch$4(ClientModLoader.java:129) ~[forge-1.17.1-37.0.109-universal.jar%23221!:?] {re:classloading,pl:runtimedistcleaner:A}     at net.minecraftforge.fmlclient.ClientModLoader.begin(ClientModLoader.java:108) ~[forge-1.17.1-37.0.109-universal.jar%23221!:?] {re:classloading,pl:runtimedistcleaner:A}     at net.minecraft.client.Minecraft.<init>(Minecraft.java:460) ~[client-1.17.1-20210706.113038-srg.jar%23217!:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A}     at net.minecraft.client.main.Main.main(Main.java:151) ~[client-1.17.1-20210706.113038-srg.jar%23217!:?] {re:classloading,pl:runtimedistcleaner:A}     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] {}     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78) ~[?:?] {}     at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] {}     at java.lang.reflect.Method.invoke(Method.java:567) ~[?:?] {}     at net.minecraftforge.fml.loading.targets.CommonClientLaunchHandler.lambda$launchService$0(CommonClientLaunchHandler.java:45) ~[fmlloader-1.17.1-37.0.109.jar%2322!:?] {}     at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.Launcher.run(Launcher.java:106) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.Launcher.main(Launcher.java:77) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:90) [bootstraplauncher-0.1.17.jar:?] {} A detailed walkthrough of the error, its code path and all known details is as follows: --------------------------------------------------------------------------------------- -- Head -- Thread: Render thread Stacktrace:     at net.minecraftforge.fml.loading.moddiscovery.BackgroundScanHandler.waitForScanToComplete(BackgroundScanHandler.java:103) ~[fmlloader-1.17.1-37.0.109.jar%2322!:?] {}     at net.minecraftforge.fml.ModLoader.gatherAndInitializeMods(ModLoader.java:153) ~[fmlcore-1.17.1-37.0.109.jar%23218!:?] {}     at net.minecraftforge.fmlclient.ClientModLoader.lambda$begin$1(ClientModLoader.java:108) ~[forge-1.17.1-37.0.109-universal.jar%23221!:?] {re:classloading,pl:runtimedistcleaner:A}     at net.minecraftforge.fmlclient.ClientModLoader.lambda$createRunnableWithCatch$4(ClientModLoader.java:129) ~[forge-1.17.1-37.0.109-universal.jar%23221!:?] {re:classloading,pl:runtimedistcleaner:A}     at net.minecraftforge.fmlclient.ClientModLoader.begin(ClientModLoader.java:108) ~[forge-1.17.1-37.0.109-universal.jar%23221!:?] {re:classloading,pl:runtimedistcleaner:A}     at net.minecraft.client.Minecraft.<init>(Minecraft.java:460) ~[client-1.17.1-20210706.113038-srg.jar%23217!:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A} -- Initialization -- Details: Stacktrace:     at net.minecraft.client.main.Main.main(Main.java:151) ~[client-1.17.1-20210706.113038-srg.jar%23217!:?] {re:classloading,pl:runtimedistcleaner:A}     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] {}     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78) ~[?:?] {}     at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] {}     at java.lang.reflect.Method.invoke(Method.java:567) ~[?:?] {}     at net.minecraftforge.fml.loading.targets.CommonClientLaunchHandler.lambda$launchService$0(CommonClientLaunchHandler.java:45) ~[fmlloader-1.17.1-37.0.109.jar%2322!:?] {}     at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.Launcher.run(Launcher.java:106) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.Launcher.main(Launcher.java:77) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) [modlauncher-9.0.7.jar%235!:?] {}     at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:90) [bootstraplauncher-0.1.17.jar:?] {} -- System Details -- Details:     Minecraft Version: 1.17.1     Minecraft Version ID: 1.17.1     Operating System: Windows 10 (amd64) version 10.0     Java Version: 16.0.1, Microsoft     Java VM Version: OpenJDK 64-Bit Server VM (mixed mode), Microsoft     Memory: 1436850640 bytes (1370 MiB) / 2885681152 bytes (2752 MiB) up to 9663676416 bytes (9216 MiB)     CPUs: 6     Processor Vendor: GenuineIntel     Processor Name: Intel(R) Core(TM) i5-8600K CPU @ 3.60GHz     Identifier: Intel64 Family 6 Model 158 Stepping 10     Microarchitecture: Coffee Lake     Frequency (GHz): 3.60     Number of physical packages: 1     Number of physical CPUs: 6     Number of logical CPUs: 6     Graphics card #0 name: NVIDIA GeForce RTX 2080 Ti     Graphics card #0 vendor: NVIDIA (0x10de)     Graphics card #0 VRAM (MB): 4095.00     Graphics card #0 deviceId: 0x1e07     Graphics card #0 versionInfo: DriverVersion=30.0.14.9649     Memory slot #0 capacity (MB): 16384.00     Memory slot #0 clockSpeed (GHz): 2.13     Memory slot #0 type: DDR4     Memory slot #1 capacity (MB): 16384.00     Memory slot #1 clockSpeed (GHz): 2.13     Memory slot #1 type: DDR4     Virtual memory max (MB): 34740.69     Virtual memory used (MB): 18387.16     Swap memory total (MB): 2048.00     Swap memory used (MB): 81.51     JVM Flags: 5 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M -Xmx9216m -Xms256m -XX:PermSize=256m     Launched Version: forge-37.0.109     Backend library: LWJGL version 3.2.2 SNAPSHOT     Backend API: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 GL version 3.2.0 NVIDIA 496.49, NVIDIA Corporation     Window size: <not initialized>     GL Caps: Using framebuffer using OpenGL 3.2     GL debug messages:      Using VBOs: Yes     Is Modded: Definitely; Client brand changed to 'forge'     Type: Client (map_client.txt)     CPU: 6x Intel(R) Core(TM) i5-8600K CPU @ 3.60GHz     ModLauncher: 9.0.7+91+master.8569cdf     ModLauncher launch target: forgeclient     ModLauncher naming: srg     ModLauncher services:           mixin PLUGINSERVICE           eventbus PLUGINSERVICE           object_holder_definalize PLUGINSERVICE           runtime_enum_extender PLUGINSERVICE           capability_token_subclass PLUGINSERVICE           capability_inject_definalize PLUGINSERVICE           accesstransformer PLUGINSERVICE           runtimedistcleaner PLUGINSERVICE           mixin TRANSFORMATIONSERVICE           fml TRANSFORMATIONSERVICE      FML Language Providers:          minecraft@1.0         kotori_scala@2.13.6-build-4         javafml@null
    • I still can't figure what's happening. Apparently ShapedRecipeBuilder.save() tries to run this.result.getItemCategory(), but this.result is null, but shoudn't this.result already be defined by ShapedRecipeBuilder.shaped()?
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.