Jump to content

How to spawn structures in underground caves


TheRPGAdventurer

Recommended Posts

6 minutes ago, TheRPGAdventurer said:

like what biomes? so I can make and exception?

Pretty much all of the non-hills biomes.  Plains, forest, birch forest, ice plains...

Average ground height is considered to be 63.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

  • Replies 57
  • Created
  • Last Reply

Top Posters In This Topic

9 hours ago, Animefan8888 said:

This does not generate underground due to these lines.

 

This line makes the chance of it spawning 1 in 120.

This line makes the chance harder if it was underground, but since it is above ground this works.

Update tell me please what's wrong with it.

public void generateNestUnderground(World world, Random random, int chunkX, int chunkZ, Random rand) {        
        int x = chunkX * 16 + random.nextInt(16);
        int z = chunkZ * 16 + random.nextInt(16);
        int xy = x >> 4;
        int zy = z >> 4;
        int y = random.nextInt(43 - 30);
        
            if(world.getBiomeForCoordsBody(new BlockPos(x,y,z)).getBiomeClass().equals(BiomePlains.class)) {
                
                if((random.nextInt(45) + 1) <= 1) {
                    boolean place = true;
        
                    for(int Y = 0; Y < 6; Y++) {
                        for(int Z = 0; Z < 9; Z++) {
                            for(int X = 0; X < 11; X++) {
                                if(world.getBlockState(new BlockPos(X + x, Y + y + 1, Z + z)).getBlock() != Blocks.AIR) {
                                    place = false;
                                }
                            }
                        }
                    }
                    
                    if(place) {
                        dragonNest.generate(world, random, new BlockPos(x,y,z));
                }
            }
        }
    }
}                 

Link to comment
Share on other sites

1 minute ago, TheRPGAdventurer said:

for(int Y = 0; Y < 6; Y++) {
                        for(int Z = 0; Z < 9; Z++) {
                            for(int X = 0; X < 11; X++) {
                                if(world.getBlockState(new BlockPos(X + x, Y + y + 1, Z + z)).getBlock() != Blocks.AIR) {
                                    place = false;
                                }
                            }
                        }
                    }

This part checks to see if a 9x11xHeight space is AIR. Which will almost never happen underground.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

Just now, Animefan8888 said:

This part checks to see if a 9x11xHeight space is AIR. Which will almost never happen underground.

9X11 more or 9X11 less? I mean does it really needs that the ground is exactly 9X11?

Edit: bigger than 9X11 or less than 9X11 needed to spawn?

Edited by TheRPGAdventurer
Link to comment
Share on other sites

1 minute ago, TheRPGAdventurer said:

9X11 more or 9X11 less? I mean does it really needs that the ground is exactly 9X11?

That piece of code is entirely useless for your means. You are checking if a 9x6x11 space is AIR. You don't want to do that.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

Just now, Animefan8888 said:

That piece of code is entirely useless for your means. You are checking if a 9x6x11 space is AIR. You don't want to do that.

the dragonNest.generate(world, random, new BlockPos(x,y,z)); issue tho,  did I did the right thing by putting null on 

if(place) {
                        dragonNest.generate(world, random, null); because I did not use it?

Link to comment
Share on other sites

Just now, TheRPGAdventurer said:

the dragonNest.generate(world, random, new BlockPos(x,y,z)); issue tho,  did I did the right thing by putting null on 

if(place) {
                        dragonNest.generate(world, random, null); because I did not use it?

my structure size btw is 7X2X7; 

Link to comment
Share on other sites

1 minute ago, TheRPGAdventurer said:

the dragonNest.generate(world, random, new BlockPos(x,y,z)); issue tho,  did I did the right thing by putting null on 

if(place) {
                        dragonNest.generate(world, random, null); because I did not use it?

Could you post your DragonNest class? I'm pretty sure you are going to need that BlockPos.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

On 7/16/2017 at 9:03 PM, Animefan8888 said:

Could you post your DragonNest class? I'm pretty sure you are going to need that BlockPos.

here's an update 

public void generateNestUnderground(World world, Random random, int chunkX, int chunkZ, Random rand) {        
        int x = chunkX * 16 + random.nextInt(16);
        int z = chunkZ * 16 + random.nextInt(16);
        int xy = x >> 4;
        int zy = z >> 4;
        int height = world.getChunkFromChunkCoords(xy, zy).getHeight(new BlockPos(x & 15, 0, z & 15));
        int y = height - random.nextInt(43 - 30);
        
            if(world.getBiomeForCoordsBody(new BlockPos(x,y,z)).getBiomeClass().equals(BiomePlains.class)) {
                
                if((random.nextInt(10) + 1) <= 1) {
                    boolean place = true;
        
                    for(int Y = 0; Y < 3; Y++) {
                        for(int Z = 0; Z < 7; Z++) {
                            for(int X = 0; X < 7; X++) {
                                if(world.getBlockState(new BlockPos(X + x, Y + y + 1, Z + z)).getBlock() != Blocks.AIR) {
                                    place = false;
                                }
                            }
                        }
                    }
                    
                    if(place) {
                        dragonNest.generate(world, random, new BlockPos(x,y,z));
                }
            }
        }
    }
}                 

Link to comment
Share on other sites

1 minute ago, TheRPGAdventurer said:

here's an update

That is not what I asked for. I want your entire dragonNest class.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

1 minute ago, TheRPGAdventurer said:

oh sorry, I thought I posted it a minute ago, https://pastebin.com/p6DWTgMP

So what is the problem currently?

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

Just now, TheRPGAdventurer said:

still not spawning.

Are you sure it is not spawning lets run through a checklist.

  • It will only spawn in the Plains Biome.
  • Then after that it will only have a chance to spawn 1 out of 10 times.
  • Where it generates underground has to have enough air blocks to generate.
  • The generation will only run on new chunks.

Make sure you are meeting all of those requirements when you are looking.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

2 hours ago, Animefan8888 said:

Are you sure it is not spawning lets run through a checklist.

  • It will only spawn in the Plains Biome.
  • Then after that it will only have a chance to spawn 1 out of 10 times.
  • Where it generates underground has to have enough air blocks to generate.
  • The generation will only run on new chunks.

Make sure you are meeting all of those requirements when you are looking.

I am using a seed that spawns you in a plains biome

I saved that seed so everytime I create a new world, I don't have trouble looking for a plains biome.

Link to comment
Share on other sites

1 minute ago, TheRPGAdventurer said:

I am using a seed that spawns you in a plains biome

I saved that seed so everytime I create a new world, I don't have trouble looking for a plains biome.

The biggest problem is the third bullet point.

4 minutes ago, Animefan8888 said:

Where it generates underground has to have enough air blocks to generate.

Since most of underground is not Air the likely hood of it being like that is really low. it is less than 1%.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

Just now, TheRPGAdventurer said:

the new generate method I use will still not work? I thought I changed the value to 3, 7, 7,

3 * 7 * 7 = 147. 147 blocks will have to be air at the randomly generated BlockPos. The likely hood of this happening is almost 0%. Just remove 

 

21 minutes ago, TheRPGAdventurer said:

                    boolean place = true;
        
                    for(int Y = 0; Y < 3; Y++) {
                        for(int Z = 0; Z < 7; Z++) {
                            for(int X = 0; X < 7; X++) {
                                if(world.getBlockState(new BlockPos(X + x, Y + y + 1, Z + z)).getBlock() != Blocks.AIR) {
                                    place = false;
                                }
                            }
                        }
                    }
                    
                    if(place) {

None of this is needed.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

2 hours ago, Animefan8888 said:

3 * 7 * 7 = 147. 147 blocks will have to be air at the randomly generated BlockPos. The likely hood of this happening is almost 0%. Just remove 

 

None of this is needed.

but my structure is not a big ass dungeon, it will not be found easily because miners in survival can't see it in caves that's why It needs a cave.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements




×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.