Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.12] Register Item


Razor
 Share

Recommended Posts

Hey, i´m reeeelatively  in forge modding. I try to update my mod to mc 1.12, but when i start minecraft all items and blocks has no textrues....   can anyone help me?

 

I clear the code here a little bit:

 

ModItems

Spoiler

@Mod.EventBusSubscriber
public class ModItems {

	public static Item examleItem;


		public void init() {

			exampleItem = new ItemExample();

	
			NameUtils.setNames(exampleItem, "example_item");
		}

		public void register() {

			registerItem(exampleItem);
		}


		private void registerItem(Item item) {
		ForgeRegistries.ITEMS.register(item);
	}
	

 

 

ClientProxy

Spoiler


public class ClientProxy extends ServerProxy {
 
    @Override
    public void registerClientStuff() {
    	
    	/** Register **/
    	// Items //
    	
    	registerModel(ModItems.exampleItem, 0, new ModelResourceLocation(ModItems.exampleItem.getRegistryName(), "inventory"));

    	
    }
    
    
    
    public void registerModel(Object obj, int meta, ModelResourceLocation loc) {
    	Item item = null;
    	if(obj instanceof Item) {
    		item = (Item) obj;
    	} else if(obj instanceof Block) {
    		item = Item.getItemFromBlock((Block)obj);
    	} else {
    		throw new IllegalArgumentException();
    	}	
    	Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(item, meta, loc);
    	}
	}
   

 

 

 

Link to comment
Share on other sites

Why is your ClientProxy a child of the ServerProxy and not the Common Proxy? And when do you call registerClientStuff?

 

This is what I hacked together for my experiments:

 

 


ModItems {
    
    public static final Item TEST = new ItemBasic("test", CreativeTabs.REDSTONE);
    
    public static final Item[] items = {
            TEST
    };
    
    @SubscribeEvent
    public static void registerItems(final RegistryEvent.Register<Item> event) {
        final IForgeRegistry<Item> registry = event.getRegistry();
        for (final Item item : items) {
            registry.register(item);
        }
    }   
}

public class ItemRenderRegister {
    public static void registerItemRenderer() {
        for(Item item:ModItems.items) {
            register(item);
        }
    }
    public static void register(Item item) {
        Minecraft.getMinecraft().getRenderItem().getItemModelMesher()
        .register(item, 0, new ModelResourceLocation(DSMain.modid + ":" + item.getUnlocalizedName().substring(5), "inventory"));
    }
}

public class ItemBasic extends Item {
    
    public ItemBasic(final String itemName) {
        this(itemName, CreativeTabs.MISC);
    }
    
    public ItemBasic(final String itemName, CreativeTabs tab) {
        setItemName(this, itemName);
        setCreativeTab(tab);
    }
    
    /**
     * Set the registry name of {@code item} to {@code itemName} and the unlocalised name to {@code itemName}.
     *
     * @param item     The item
     * @param itemName The item's name
     */
    public static void setItemName(final Item item, final String itemName) {
        item.setRegistryName(DSMain.MODID, itemName);
        item.setUnlocalizedName(itemName);
    }
}

 

And then I just run MinecraftForge.EVENT_BUS.register(ModItems.class); in my common proxy preinit and ItemRenderRegister.registerItemRenderer(); in my client proxy init.

 

Edit: I moved all three inits to my proxies. This allows me to do general stuff in the common proxy and client/dedicated only stuff in their respective proxy classes after a super call.

Edited by Jacky2611

Here could be your advertisement!

Link to comment
Share on other sites

I think, my version is simplier to maintain and understand.
Common RegistryHandler.java
Client RegistryHandler.java

Those are only classes that register items and models. I personally store everything in ModItems class (HashMaps as a test) and then taking them into register methods with for loops. Feel free to change everything.

UPD. I might've missed @SideOnly annotation on the client class. I was told why it's needed here. I'm not sure if forge actually excludes this class from server jar just because of side param in @EventBusSubscriber (feel like not).

Edited by MrBendelScrolls
English is not my thing
  • Like 1
Link to comment
Share on other sites

Nearly the exact same thing I did. I just manually registered my event handlers instead of using annotations. Might switch to annotations later but for now I like that I can see where my event handlers are registered.

Here could be your advertisement!

Link to comment
Share on other sites

It seems that you are using an outdated way of registering items and their models. Try using registry events like this: 

@Mod.EventBusSubscriber(modid = %modid%)
public class RegistryEventHandler {
	//This Registers the items to the games registry
	@SubscribeEvent
	public static void registerItems(RegistryEvent.Register<Item> event) {
          event.getRegistry().registerAll(ModItems.ITEMS);
          
          for(Block block : ModBlocks.BLOCKS) {
			event.getRegistry().register(new ItemBlock(block).setRegistryName(block.getRegistryName()));
		}
          
    }
   
  //This is the model registerer
   @SideOnly(Side.CLIENT)
   @SubscribeEvent
   public staic void registerModels(MOdelRegistryEvent event) {
   
     for(Item item: ModItems.ITEMS) {
     
     	ModelLoader.setCustomModelResourceLocation(item, 0 , new ModelResourceLocation(item.getRegistryName(), "inventory"));
       
     }
   
   }
}

 Similar to MrBendScrolls, we use RegistryEvents, you do not need to put this into the main java file. Make sure that no file in the assets file is capitolized, forge now enforces that rule.

  • Like 1
Link to comment
Share on other sites

3 minutes ago, Kokkie said:

I think it shouldn't work if you don't use @Mod.EventBusSubscriber because the events are fired before preInit...

He can also use MinecraftForge.EVENT_BUS.register(ModItems.class); in preInit. The events aren't triggered before preInit, they are triggered between preInit and init.

Here could be your advertisement!

Link to comment
Share on other sites

2 hours ago, Jacky2611 said:

Why is your ClientProxy a child of the ServerProxy and not the Common Proxy? And when do you call registerClientStuff?

 

This is what I hacked together for my experiments:

  Reveal hidden contents

 



ModItems {
    
    public static final Item TEST = new ItemBasic("test", CreativeTabs.REDSTONE);
    
    public static final Item[] items = {
            TEST
    };
    
    @SubscribeEvent
    public static void registerItems(final RegistryEvent.Register<Item> event) {
        final IForgeRegistry<Item> registry = event.getRegistry();
        for (final Item item : items) {
            registry.register(item);
        }
    }   
}

public class ItemRenderRegister {
    public static void registerItemRenderer() {
        for(Item item:ModItems.items) {
            register(item);
        }
    }
    public static void register(Item item) {
        Minecraft.getMinecraft().getRenderItem().getItemModelMesher()
        .register(item, 0, new ModelResourceLocation(DSMain.modid + ":" + item.getUnlocalizedName().substring(5), "inventory"));
    }
}

public class ItemBasic extends Item {
    
    public ItemBasic(final String itemName) {
        this(itemName, CreativeTabs.MISC);
    }
    
    public ItemBasic(final String itemName, CreativeTabs tab) {
        setItemName(this, itemName);
        setCreativeTab(tab);
    }
    
    /**
     * Set the registry name of {@code item} to {@code itemName} and the unlocalised name to {@code itemName}.
     *
     * @param item     The item
     * @param itemName The item's name
     */
    public static void setItemName(final Item item, final String itemName) {
        item.setRegistryName(DSMain.MODID, itemName);
        item.setUnlocalizedName(itemName);
    }
}

 

And then I just run MinecraftForge.EVENT_BUS.register(ModItems.class); in my common proxy preinit and ItemRenderRegister.registerItemRenderer(); in my client proxy init.

 

Edit: I moved all three inits to my proxies. This allows me to do general stuff in the common proxy and client/dedicated only stuff in their respective proxy classes after a super call.

 

i have no common proxy, only a server and a client proxy. And i call the the registerClientStuff in the InitEvent of the main class

Link to comment
Share on other sites

1 hour ago, Bak3dC said:

It seems that you are using an outdated way of registering items and their models. Try using registry events like this: 


@Mod.EventBusSubscriber(modid = %modid%)
public class RegistryEventHandler {
	//This Registers the items to the games registry
	@SubscribeEvent
	public static void registerItems(RegistryEvent.Register<Item> event) {
          event.getRegistry().registerAll(ModItems.ITEMS);
          
          for(Block block : ModBlocks.BLOCKS) {
			event.getRegistry().register(new ItemBlock(block).setRegistryName(block.getRegistryName()));
		}
          
    }
   
  //This is the model registerer
   @SideOnly(Side.CLIENT)
   @SubscribeEvent
   public staic void registerModels(MOdelRegistryEvent event) {
   
     for(Item item: ModItems.ITEMS) {
     
     	ModelLoader.setCustomModelResourceLocation(item, 0 , new ModelResourceLocation(item.getRegistryName(), "inventory"));
       
     }
   
   }
}

 Similar to MrBendScrolls, we use RegistryEvents, you do not need to put this into the main java file. Make sure that no file in the assets file is capitolized, forge now enforces that rule.

what do you mean with "capitolized"

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Hi, So as the title says it seems im the only one with this issue, it was working fine yesterday. basically the server just keeps saying Pinging.... and doesn't load, i added a vanilla server to see if all servers would behave the same but no, my modded server was the only one. i asked some of my friends to try connecting and no problem so it seems on my end. I tried connecting even when it says pinging and it just stuck on Encrypting and then timed out Client log https://gist.github.com/thekingtoonboy/1c53875b856e0563b9313a8cc060a4a0.js latest Server log [19Sep2021 06:06:35.440] [Netty Epoll Server IO #2/INFO] [codechicken.lib.config.ConfigSyncManager/]: Skipping config sync, No mods have registered a syncable config. [19Sep2021 06:06:35.529] [Netty Epoll Server IO #2/WARN] [com.connectivity.Connectivity/]: Login payload for Registry minecraft:item is using 111.6286% of max allowed size and will cause errors during login if connectivity is not present on client side. [19Sep2021 06:06:35.543] [Netty Epoll Server IO #2/WARN] [com.connectivity.Connectivity/]: Login payload for Registry minecraft:block is using 87.6082% of max allowed size [19Sep2021 06:06:37.491] [User Authenticator #1/INFO] [net.minecraft.network.login.ServerLoginNetHandler/]: UUID of player KiingSultan is e69dbe58-dd8d-4d26-9317-a643a0ffde12 [19Sep2021 06:08:37.721] [Server thread/INFO] [net.minecraft.network.login.ServerLoginNetHandler/]: com.mojang.authlib.GameProfile@1b416c43[id=e69dbe58-dd8d-4d26-9317-a643a0ffde12,name=KiingSultan,properties={textures=[com.mojang.authlib.properties.Property@38939441]},legacy=false] (/5.193.109.22:50035) lost connection: Timed out [19Sep2021 06:13:10.808] [Netty Epoll Server IO #0/INFO] [codechicken.lib.config.ConfigSyncManager/]: Skipping config sync, No mods have registered a syncable config. [19Sep2021 06:13:10.867] [Netty Epoll Server IO #0/WARN] [com.connectivity.Connectivity/]: Login payload for Registry minecraft:item is using 111.6286% of max allowed size and will cause errors during login if connectivity is not present on client side. [19Sep2021 06:13:10.880] [Netty Epoll Server IO #0/WARN] [com.connectivity.Connectivity/]: Login payload for Registry minecraft:block is using 87.6082% of max allowed size [19Sep2021 06:13:18.792] [User Authenticator #2/INFO] [net.minecraft.network.login.ServerLoginNetHandler/]: UUID of player KiingSultan is e69dbe58-dd8d-4d26-9317-a643a0ffde12 [19Sep2021 06:15:19.013] [Server thread/INFO] [net.minecraft.network.login.ServerLoginNetHandler/]: com.mojang.authlib.GameProfile@28a892fa[id=e69dbe58-dd8d-4d26-9317-a643a0ffde12,name=KiingSultan,properties={textures=[com.mojang.authlib.properties.Property@53a47b26]},legacy=false] (/5.193.109.22:50239) lost connection: Timed out Thanks in advance.
    • This isn't something we can fix (or even work around) without someone on the Dev team having an M1 Mac. For context, this is not a Forge issue, Apple being Apple they decided M1's didn't need backwards compatiblity with their old graphics API when they made the new one and the update to GLFW to accomodate the change hasn't made its way through LWJGL as of this writing
    • Hello. I am trying to add custom ores. Everything seems to be called and executed (when print statements are added), but nothing changes in game. I had it working in 1.16, but not in 1.17. I changed some of it to work with the new forge version, and it compiles without errors, but nothing changes in game. Any help figuring this out is appreciated.   Code: @Mod.EventBusSubscriber public class OreGeneration { public static ImmutableList<TargetBlockState> ORE_TARGET_LIST; public static final ArrayList<ConfiguredFeature<?, ?>> overworldOres = new ArrayList<ConfiguredFeature<?, ?>>(); public static void registerOres(){ ORE_TARGET_LIST = ImmutableList.of(OreConfiguration.target(Predicates.NATURAL_STONE, Blocks.STONE.defaultBlockState())); overworldOres.add(register("tin_ore_block", Feature.ORE.configured(new OreConfiguration(ORE_TARGET_LIST, 5)) .rangeUniform(VerticalAnchor.absolute(0), VerticalAnchor.absolute(48)) .squared() .count(20) )); } private static <FC extends FeatureConfiguration> ConfiguredFeature<FC, ?> register(String name, ConfiguredFeature<FC, ?> configuredFeature) { return Registry.register(BuiltinRegistries.CONFIGURED_FEATURE, new ResourceLocation(Extras.MODID, name), configuredFeature); } @SubscribeEvent(priority = EventPriority.HIGHEST) public static void registerBiomeModification(BiomeLoadingEvent event) { BiomeGenerationSettingsBuilder generation = event.getGeneration(); for(ConfiguredFeature<?, ?> ore : overworldOres){ if (ore != null) { generation.getFeatures(Decoration.UNDERGROUND_ORES).add(() -> { return ore; }); } } } }
    • you haven't, you still store the ModEventBus in a static Field and you register the Renderer of your Entity in FMLCommonSetupEvent and not in FMLClientSetupEvent Edit: you still use static initializer for your EntityTypes, I would recommend you to look again at the basics for the Registry System: FCW or the Forge doc
    • post debug log, if you use java 17 downgrade to java 16, since at the moment not supported by Forge
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.