Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.12] New Registry System and where to call the registry event


GooberGunter
 Share

Recommended Posts

Hey, I just updated my mod and I'm not to up-to-date with the registry system yet. I updated all of my registry methods in my ModItems, ModBlocks, and ModEntities. The only problem is (and it's very much my fault for not knowing this) I have no clue where to call these methods and what to put in the method for the RegistryEvent.

Here's one of my register methods

Spoiler

@SubscribeEvent
	public static void registerItem(final RegistryEvent.Register<Item> event) {
		final IForgeRegistry<Item> regi = event.getRegistry();
		for(int i=0; i <= itemlist.size(); i++) {
			regi.register(itemlist.get(i));
			itemlist.get(i).setCreativeTab(items); //Sets the creative tab
			Utils.getLogger().info("Registered Item: " + itemlist.get(i).getUnlocalizedName().substring(5));
		}
	}

 

 

Link to comment
Share on other sites

A little complains about the code.
1. You don't do whitespaces (or whatever english calls it) after annotations.
2. Unnecessary fori loop, it'd better be foreach.
Now it looks something like this:


@SubscribeEvent
public static void registerItem(final RegistryEvent.Register<Item> event) {
	final IForgeRegistry<Item> regi = event.getRegistry();
	for(Item item : itemList) {
		regi.register(item);
		item.setCreativeTab(items); //Sets the creative tab
		Utils.getLogger().info("Registered Item: " + item.getUnlocalizedName().substring(5));
	}
}

3. Not sure why to store registry in `regi`, is this too hard to just `event.getRegistry().register()`? Simplier and cleaner.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.