Jump to content

[1.12] [SOLVED] KeyInputEvent get keyPressed


oznecniV97

Recommended Posts

Hi guys,

I want to know in my KeyInputEvent which is the key pressed without write a code like this:

int n = 0;
if(KeyBindings.left.isPressed()){
	//EXAMPLE CODE
	n = 1;
}else if(KeyBindings.right.isPressed()){
	//EXAMPLE CODE
	n = 2;
}else if(KeyBindings.up.isPressed()){
	//EXAMPLE CODE
	n = 3;
}else if(KeyBindings.down.isPressed()){
	//EXAMPLE CODE
	n = 4;
}else if(KeyBindings.back.isPressed()){
	//EXAMPLE CODE
	n = 5;
}

because I need to check on ALL the key bindings (even to vanilla ones).

 

Is there a method to get this information from the event argument or can I get a list of all registered KeyBinding?

 

Add:

I've tryied with 

Set<String> binds = KeyBinding.getKeybinds();
for (String bind : binds) {
  System.out.println(bind);
}

but I can only see the categories:

key.categories.misc
key.categories.creative
key.categories.gameplay
key.categories.multiplayer
key.categories.movement
key.categories.inventory

Edited by oznecniV97
Add
Link to comment
Share on other sites

Sorry but, why this is wrong?

	@SubscribeEvent
    public void onKeyInput(InputEvent.KeyInputEvent event) {
        if(KeyBindings.left.isPressed()){
        	//do something
        }
        if(KeyBindings.right.isPressed()){
        	//do something
        }
        if(KeyBindings.up.isPressed()){
        	//do something
        }
        if(KeyBindings.down.isPressed()){
        	//do something
        }
        if(KeyBindings.rompi.isPressed()){
        	//do something
        }
    }

For me it works without any problem.

 

Which are the improvement to use the ClientTickEvent instead of this?

Link to comment
Share on other sites

UPDATE:

If I do this code (*) in the KeyInputEvent I can see the key pressed in the console but if the key works on a isPressed logic it didn't do the base logic (Ex: if I press E, I see "key.inventory - E" but my inventory didn't open).

If I do this code (*) in the PlayerTickEvent/ClientTickEvent if the key works on a isPressed logic I can't see the key pressed in the console but the key works as expected (Ex: if I press E, I can see my inventory opened but nothing in the console).

 

(*)

		Field campo = KeyBinding.class.getDeclaredField("KEYBIND_ARRAY");
    	campo.setAccessible(true);
    	Map<String, KeyBinding> binds = (Map<String, KeyBinding>) campo.get(null);
    	for (String bind : binds.keySet()) {
			if(binds.get(bind).isPressed()){
				System.out.println(bind + " - " + binds.get(bind).getDisplayName());
				break;
			}
		}

 

Edited by oznecniV97
Missing code
Link to comment
Share on other sites

Ok thanks!

Now it work (more or less) with the following code:

private static Map<String, KeyBinding> binds = null;

@SubscribeEvent (priority = EventPriority.LOWEST) //END is not present
public void onClientTick(TickEvent.ClientTickEvent event) throws Exception {
	if(binds == null){
		Field campo = KeyBinding.class.getDeclaredField("KEYBIND_ARRAY");
    	campo.setAccessible(true);
    	binds = (Map<String, KeyBinding>) campo.get(null);
	}
	for (String bind : binds.keySet()) {
		if(binds.get(bind).isKeyDown()){
			System.out.println(bind + " - " + binds.get(bind).getDisplayName());
			break;
		}
	}
}

 

The only one issue that I've found is that if I press very fast a key that have a isPressed logic (like E key) it didn't catch the pressing event and print nothing.

Set this thread as solved.

Link to comment
Share on other sites

With this update (check if phase is END):

private static Field KEYBIND_ARRAY = null;

	@SubscribeEvent (priority = EventPriority.LOWEST)
	public void onClientTick(TickEvent.ClientTickEvent event) throws Exception {
		if(KEYBIND_ARRAY == null){
			KEYBIND_ARRAY = KeyBinding.class.getDeclaredField("KEYBIND_ARRAY");
			KEYBIND_ARRAY.setAccessible(true);
		}
		if(event.phase.equals(Phase.END)){
			Map<String, KeyBinding> binds = (Map<String, KeyBinding>) KEYBIND_ARRAY.get(null);
	    	for (String bind : binds.keySet()) {
				if(binds.get(bind).isKeyDown()){
					System.out.println(bind + " - " + binds.get(bind).getDisplayName());
					break;
				}
			}
		}
	}

I see no difference about the issue.

 

I have a doubt of how can I set the static Field to final because if I do that and set equals to KeyBinding.class.getDeclaredField("field") eclipse give me an error and didn't compile it because there's a throws declaration on this method.

Link to comment
Share on other sites

5 minutes ago, diesieben07 said:

Are such short presses even detected by Minecraft itself?

Yes, this issue is basically related to the open phase of a GUI. If I short press E I see the inventory opened but in the console I can't see nothing (Same problem with L key Advancements). In the others cases (even the E press to close the inventory) I see it.

Link to comment
Share on other sites

Vanilla methods/fields have more than one name: there's the Notch name (Mojang's obfuscated names that change each version), the SRG name (MCP's auto-generated names that remain stable between versions) and the MCP name (MCP's community-assigned deobfuscated names). Forge deobfuscates from Notch to SRG names at runtime, so you never need to worry about Notch names.

 

For normal code, ForgeGradle reobfuscates from MCP to SRG names at build time, so you don't need to worry about the names.

 

For reflection, you need to check both the SRG and the MCP names for vanilla fields and methods yourself. The easiest way to do this is by using Forge's ReflectionHelper.findMethod/findField methods. These don't throw any checked exceptions, so you can use them directly in the field initialiser of the Method/Field field.

 

You can use MCPBot to find the SRG name of a method/field.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
    • It is an issue with quark - update it to this build: https://www.curseforge.com/minecraft/mc-mods/quark/files/3642325
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.