Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.10] [solved]Nullpointerexception when trying to Skin items. (I put it in preinit instead of init)


oldcheese
 Share

Recommended Posts

My Lang file also isn't naming my items, so either I Didn't manage to initialize the item correctly or my Resources aren't set up properly. 

 

However, to make items, they just show up with squares instead of anything usefull.

 

net.minecraftforge.fml.common.LoaderExceptionModCrash: Caught exception from RolePVP (RPVP)
Caused by: java.lang.NullPointerException
	at com.cheese.rpvp.render.ItemRenderRegister.reg(ItemRenderRegister.java:18)
	at com.cheese.rpvp.render.ItemRenderRegister.registerItemRenderer(ItemRenderRegister.java:14)
	at com.cheese.rpvp.ClientProxy.preInit(ClientProxy.java:13)
	at com.cheese.rpvp.Main.preInit(Main.java:23)

There's my error. Now for the codes. 


    @EventHandler
    public void preInit(FMLPreInitializationEvent e) {
23    	Main.proxy.preInit(e);
    	RPVPItems.createItems();
    }

That's the first offending line,, just me invoking the Proxy files. 

 

public class ClientProxy extends CommonProxy{
	
	@Override
    public void preInit(FMLPreInitializationEvent e) {
    	ItemRenderRegister.registerItemRenderer();
        super.preInit(e);
    }

Part of my ItemRenderer class that I had hoped to use to render multiple items down the line.

 

As you can see I invoke the method in my Preinitialization.

 

package com.cheese.rpvp.render;
import com.cheese.rpvp.Main;
import com.cheese.rpvp.items.RPVPItems;

import net.minecraft.client.Minecraft;
import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.item.Item;

public final class ItemRenderRegister {
	public static String modid = Main.MODID;
	
	public static void registerItemRenderer(){
		reg(RPVPItems.testitem);
	}
	
	public static void reg(Item item){
		Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(item, 0, new ModelResourceLocation(item.getRegistryName(), "inventory"));
	}
	
}

There's the entire Itemrenderer class.  I send an item through to reg. This is where the nullpointerexception mainly takes place it seems. 

 

package com.cheese.rpvp.items;

import net.minecraftforge.fml.common.registry.GameRegistry;

public final class RPVPItems {

	public static BasicItem testitem = new BasicItem("testitem");
	public static void createItems(){
		GameRegistry.register(testitem);
	}
	
}

This is the code I use to create items. Here's where I list them. It's just for generic items so I use one class for most of them. 

 

package com.cheese.rpvp.items;

import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.item.Item;

public class BasicItem extends Item{

	public BasicItem(String unlocalizedName){
		super();
		this.setUnlocalizedName(unlocalizedName);
		this.setCreativeTab(CreativeTabs.MATERIALS);
		this.setRegistryName(unlocalizedName);
	}
	
}

Finally here's the class I use for BasicItem.

 

That should be all important classes. Now for hierarchy 

Link to imgur

Here's a screenshot of how that's setup. as you can see I have a assets.rpvp.models.item with the Json listed here:

{
    "parent": "item/generated",
    "textures": {
        "layer0": "rpvp:items/testitem"
     },
     
    "display": {
        "thirdperson": {
            "rotation": [-90,0,0],
            "translation": [0,1,-3],
            "scale": [0.55,0.55,0.55]
        },
        "firstperson": {
            "rotation": [0,-135,25],
            "translation": [0,4,2],
            "scale": [1.7,1.7,1.7]
        }
    }
}

I've tried changing testitem to different things. I've tried changing my fully Caps RPVP to rpvp for the modid. nothing much helped. I keep getting a nullpointer even though I clearly state most locations.

vCaiD5S[1].png

Edited by oldcheese
Link to comment
Share on other sites

If I'm not mistaking, the item needs to be registered in the game registry before registering its model. The calling order must change as so

 

@EventHandler
    public void preInit(FMLPreInitializationEvent e) {
  		RPVPItems.createItems();  	
  		Main.proxy.preInit(e);
    }
Link to comment
Share on other sites

43 minutes ago, ctbe said:

If I'm not mistaking, the item needs to be registered in the game registry before registering its model. The calling order must change as so

 


@EventHandler
    public void preInit(FMLPreInitializationEvent e) {
  		RPVPItems.createItems();  	
  		Main.proxy.preInit(e);
    }

The items aren't a problem. I'm able to create the item in game when I comment out my Renderer. The renderer is causing a nullpointer. Changing the order changed nothing for me. I'm getting the exact same error.

Link to comment
Share on other sites

Either ItemModelMesher or RenderItem is null. You can test which one of them is giving null by first getting each one of them into a variable and debugging to see which one of them is been null. To solve it and not debug anything, use ModelLoader instead of ModelMesher.

 

ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(item.getRegistryName(), "inventory"))

 

 

Link to comment
Share on other sites

45 minutes ago, oldcheese said:

The items aren't a problem. I'm able to create the item in game when I comment out my Renderer. The renderer is causing a nullpointer. Changing the order changed nothing for me. I'm getting the exact same error.

Loading a world happens waaaaaaaaay after item creation and registration. Your objection is wrong. Your renderer is broken because its happening BEFORE YOUR ITEMS EXIST. 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

12 hours ago, Draco18s said:

Loading a world happens waaaaaaaaay after item creation and registration. Your objection is wrong. Your renderer is broken because its happening BEFORE YOUR ITEMS EXIST. 

How would I even change this? 

 

I've changed my code so that items are created first, then the proxies are called 

 

    @EventHandler
    public void preInit(FMLPreInitializationEvent e) {
    	RPVPItems.createItems();
    	Main.proxy.preInit(e);
    }

so now the items exist, then it calls the preinit in the proxies. Which means that my items should exist before I attempt to render them. Is there some other way to fix my Item existing? 

 

Perhaps the way I make items is wrong?  I've used the method above, but even when I Initialize my item right in the start by adding 

Quote

//items
    public static BasicItem testitem = new BasicItem("testitem");
  

to the code before the preinit it won't really change the crash.

 

 

Edit: I'm an idiot. is Rendering items an INIT task instead of preinit? Because it worked perfectly when I added it to the init code instead of PreInit. 

 

Jesus christ I spend like 5 hours staring at this code and it turns out it's a little tiny thing that could've easily been avoided if I re-read the documentation for a second :/

 

 

Thanks for the help!

 

Edited by oldcheese
I'm an idiot.
Link to comment
Share on other sites

1 minute ago, diesieben07 said:

This is your problem.

You need to use ModelLoader.setCustomModelResourceLocation in preInit, not this.

I do use this funciton in Preinit. Preinit calls RegisterItemrenderer(); which is a method that contains the line of code you quoted.

 

The way It seems to work is when I put my ItemRenderer in my Init instead of my preInit everything works just fine.

Link to comment
Share on other sites

22 minutes ago, diesieben07 said:

 

My bad. I'm a bigger idiot than I thought, I'm sorry for misunderstanding. English isn't my main language.

 

I thought you meant the new ModelLoaderResource that you'd use in the original long string, I get what you mean now.

 

Thanks for the help!

 

 

Edited by oldcheese
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Register your own IRecipeSerializer. It is registered like any other registry entry. However note that you should have as much as possible in the JSON. Don't just have a placeholder JSON file and then hardcode all the logic in code. That defeats the point of datapacks. You'll have to have your own repair recipe then (see above for how to make your own serializer) and override getRemainingItems. If the knife is your item, override hasContainerItem and getContainerItem in your Item class. If the knife is not your item, refer to the section about repairing. Use a GlobalLootModifier.
    • So, im kinda new to modding. Trying to make relatively complicated mod(as I see now, it breaks the api a little bit...), and faced into some problems, especially with crafting. I think I should tell a little bit about my mod, you actually can skip this part, but if you don't get something, i strongly suggest to read this part. The goal i'm chasing is to implement similar food mechanics to TFC classic(1.7.10) mechanics. In a nutshell, it's food with durrability, and when you eat, you consume as much as you need(like if you have a steak and 1 hunger, if you eat it, stake's potential wastes, in case of my mod, it shouldn't). That's it, that's already done(with little bugs thou, but done). Now I have to do crafting somehow, using that items and modify durability while crafting. And it doesn't seems to be easy.     And.. question 1 will be: is it possible to hardcode crafts in 1.16.5? I know.. it's kinda not beautifull, but I really hate the json system. I've made as much crafts as possible by using it, but now, when I need to implement some logic, it's such a headache.   2. This question is about repearing. I mean, placing two damaged items in recipe grid. If you add 2 8/10 items, you'll get just one 10/10 item, and nothing more. I'd like 6/10 item to apear in grid after crafting. 3. Also there should be a recipe for extracting seeds with knife(i don't like to loose knife and whole peace of crop after craft). 4. And the last one. Well, I should change drop of crops if it's broken by special tool. I know, it's possible to do it by adding harvest tools, but I can't modify vanilla crops(maybe only by reflection..). Seems like it's reasonable to use onBlockBroken event, or something like that, but I keep finding deprecated code examples in google, and it doesn't work for me. Maybe there is a better solution.   About crafts.. I tried to figure out how CraftSerializers works, and i think it might be a good solution for that crafting stuff. But don't understand how to bind the serializer to regular minecraft crafting. Tried to read ShapelessRecipe class, but don't understand what happens in mathes, so cant do any assumptions how should I modify it. 
    • IP: Play.EpicLandCraft.Com Version: Cualquiera
    • What Im trying to do is to implement a "dash" mechanic on a Shift button.   @SubscribeEvent public static void onEvent(InputEvent.KeyInputEvent event){ KeyBinding runBinding = Minecraft.getInstance().gameSettings.keyBindSprint; int key = event.getKey(); int runKey = runBinding.getKey().getKeyCode(); ClientPlayerEntity player = Minecraft.getInstance().player; if (key == runKey){ //some checks, and then: float yaw = player.rotationYaw; float x = -MathHelper.sin(yaw * 0.017453292F); float z = MathHelper.cos(yaw * 0.017453292F); double groundMotion = 5, airMotion = 2; if (player.isOnGround()) player.setMotion(new Vector3d(x * groundMotion, 0, z * groundMotion)); else player.setMotion(new Vector3d(x * airMotion, 0, z * airMotion)); } } And this code works. The problem is, it causes a lot of lag when the setMotion() is called - my fps drops from 60 to 50-40 and the dash movement looks discrete. I wonder why is it so and how it can be improved...
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.