Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.11.2] Can I use SimpleImpl to send a message from a client to the server to another client?


Recommended Posts

I'm trying to create a GUI that can play sounds of type MovingSound (as opposed to a normal PositionedSoundRecords, which is what World#playSound uses) when pressed, not only to the player using the GUI, but to everyone within range. Of course, GUI's are exclusively client sided, so I decided to use SimpleImpl to send a message about the sound to the server, but since I'm using a MovingSound I then have to play it through the SoundHandler in Minecraft (which is a client class) on all receiving clients. I'm kinda new to SimpleImpl and networking in general, but from my limited experience it would appear that you have to register your client packets only on the client side and server packets on the server side (if I didn't do this either the server would crash or my client would be kicked from the server, respectively). This, however, poses a problem as I'm trying to send a package that is only registered on the client from a package that is only registered on the server, meaning that I'm effectively trying to send a package that isn't registered (at least, that's how I think it works). I believe there's something wrong with how I register my packets, but as I say I'm new to networking so I don't really know. Help would be greatly appreciated!

 

GitHub can be found here:

https://github.com/TheMattyBoy00/petri-mod-2.0/tree/master/Petri_Mod-1.11.2/src/main/java/erikalebenjamattias/petrimod

My GUI is here (it's long and messy, package is sent at line 324) (if you're wondering why I play the sound on the client and then send it to the server to play to all other clients nearby, it's to reduce latency for the person playing the piano [which is what the GUI is for if you hadn't guessed]):

https://github.com/TheMattyBoy00/petri-mod-2.0/blob/master/Petri_Mod-1.11.2/src/main/java/erikalebenjamattias/petrimod/client/gui/GuiPianoKeyboard.java#L324

Package to send to server (a quick println shows that this does in fact find all the players it should that are in range):

https://github.com/TheMattyBoy00/petri-mod-2.0/blob/master/Petri_Mod-1.11.2/src/main/java/erikalebenjamattias/petrimod/network/NotifyServerOfPianoPlayMessages.java

Package to send to clients (println in the onMessage() method shows that it does not get called what so ever, and the constructor with the println only gets called on the server where it's called in the server package, despite it being a client event):

https://github.com/TheMattyBoy00/petri-mod-2.0/blob/master/Petri_Mod-1.11.2/src/main/java/erikalebenjamattias/petrimod/network/NotifyClientOfPianoPlayMessages.java

Packet handler:

https://github.com/TheMattyBoy00/petri-mod-2.0/blob/master/Petri_Mod-1.11.2/src/main/java/erikalebenjamattias/petrimod/network/PetriPacketHandler.java

Packets registered in the client proxy and server proxy respectively. This is where I think I might be doing something wrong.

Edited by TheMattyBoy

IGN: matte006

Played Minecraft since summer 2011.

Modding is my life now.

Please check out my mod :)

https://minecraft.curseforge.com/projects/gadgets-n-goodies-mod?gameCategorySlug=mc-mods&projectID=230028

Link to post
Share on other sites
  • Stop calling packets packages. They are different things.
  • This is not needed. The server knows who sent the packet.
  • You cannot blindly trust the entity ID (pianoId in your packet) that the client sends. At least do a check that the client is within range.
  • Packets must always be registered on both sides.
Link to post
Share on other sites
16 minutes ago, diesieben07 said:

Stop calling packets packages. They are different things.

Oh oops, didn't even notice that... Embarrassing...

 

17 minutes ago, diesieben07 said:

This is not needed. The server knows who sent the packet.

Right, thanks.

 

17 minutes ago, diesieben07 said:

You cannot blindly trust the entity ID (pianoId in your packet) that the client sends. At least do a check that the client is within range.

Didn't I already sort of do this by doing world.getEntityByID(message.pianoId).getDistanceSqToEntity(p_apply_1_) < 900.0D in the predicate for finding the players?

 

20 minutes ago, diesieben07 said:

Packets must always be registered on both sides.

Alright, this is what I was having trouble with. If I tried to register a client packet on both sides the server would crash with a NoClassDefFoundError on whatever client-only class I was trying to access in my onMessage method in my message handler, and no amount of side checking or @SideOnly-ing would fix the error. How do I register a packet on both sides, while being able to access client only classes and methods, without the server immediately crashing with a NoClassDefFoundError or NoSuchMethodError?

IGN: matte006

Played Minecraft since summer 2011.

Modding is my life now.

Please check out my mod :)

https://minecraft.curseforge.com/projects/gadgets-n-goodies-mod?gameCategorySlug=mc-mods&projectID=230028

Link to post
Share on other sites
5 minutes ago, TheMattyBoy said:

Didn't I already sort of do this by doing world.getEntityByID(message.pianoId).getDistanceSqToEntity(p_apply_1_) < 900.0D in the predicate for finding the players?

No, there you are just checking that you are sending to players near the piano. You are not checking that the player playing the note is actually near the piano.

Also, this whole thing can be done much more efficiently by using World::getEntitiesWihtinAABB, that way you do not have to loop through all players.

 

7 minutes ago, TheMattyBoy said:

How do I register a packet on both sides, while being able to access client only classes and methods, without the server immediately crashing with a NoClassDefFoundError or NoSuchMethodError?

@SidedProxy is the tool to interact with side-specific code from common code.

Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Im playing with MultiMC. I get to the "Loading world, Bulding Terrain..." screen and then it goes to minecraft dindn't respond. I've been at this for two hour now. I can't find any articles that deal with this error. I also have OptiFine installed, I tried deleting the options text file and restarting but still no luck. I dunno which information is important so I'll post the full log. ---- Minecraft Crash Report ---- WARNING: coremods are present:   LucraftCoreCoreMod (LucraftCore-1.12.2-2.4.16.jar)   MalisisCorePlugin (malisiscore-1.12.2-6.5.1.jar) Contact their authors BEFORE contacting forge // My bad. Time: 7/23/21 5:25 PM Description: Ticking player java.lang.NoSuchMethodError: lucraft.mods.lucraftcore.superpowers.abilities.Ability.getCurrentPlayerAbilities(Lnet/minecraft/entity/player/EntityPlayer;)Ljava/util/List;     at lucraft.mods.speedsterheroes.abilities.AbilityPhasing$EventHandler.onLivingUpdate(AbilityPhasing.java:82)     at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_54_EventHandler_onLivingUpdate_LivingUpdateEvent.invoke(.dynamic)     at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90)     at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:182)     at net.minecraftforge.common.ForgeHooks.onLivingUpdate(ForgeHooks.java:581)     at net.minecraft.entity.EntityLivingBase.func_70071_h_(EntityLivingBase.java:2095)     at net.minecraft.entity.player.EntityPlayer.func_70071_h_(EntityPlayer.java:234)     at net.minecraft.entity.player.EntityPlayerMP.func_71127_g(EntityPlayerMP.java:382)     at net.minecraft.network.NetHandlerPlayServer.func_73660_a(NetHandlerPlayServer.java:173)     at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher$1.func_73660_a(NetworkDispatcher.java:209)     at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:285)     at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:180)     at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:790)     at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:668)     at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:279)     at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526)     at java.lang.Thread.run(Unknown Source) A detailed walkthrough of the error, its code path and all known details is as follows: --------------------------------------------------------------------------------------- -- Head -- Thread: Server thread Stacktrace:     at lucraft.mods.speedsterheroes.abilities.AbilityPhasing$EventHandler.onLivingUpdate(AbilityPhasing.java:82)     at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_54_EventHandler_onLivingUpdate_LivingUpdateEvent.invoke(.dynamic)     at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90)     at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:182)     at net.minecraftforge.common.ForgeHooks.onLivingUpdate(ForgeHooks.java:581)     at net.minecraft.entity.EntityLivingBase.func_70071_h_(EntityLivingBase.java:2095)     at net.minecraft.entity.player.EntityPlayer.func_70071_h_(EntityPlayer.java:234) -- Player being ticked -- Details:     Entity Type: null (net.minecraft.entity.player.EntityPlayerMP)     Entity ID: 1844     Entity Name: RedcreeperYT_     Entity's Exact location: 453.50, 4.00, 91.50     Entity's Block location: World: (453,4,91), Chunk: (at 5,0,11 in 28,5; contains blocks 448,0,80 to 463,255,95), Region: (0,0; contains chunks 0,0 to 31,31, blocks 0,0,0 to 511,255,511)     Entity's Momentum: 0.00, 0.00, 0.00     Entity's Passengers: []     Entity's Vehicle: ~~ERROR~~ NullPointerException: null Stacktrace:     at net.minecraft.entity.player.EntityPlayerMP.func_71127_g(EntityPlayerMP.java:382)     at net.minecraft.network.NetHandlerPlayServer.func_73660_a(NetHandlerPlayServer.java:173)     at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher$1.func_73660_a(NetworkDispatcher.java:209)     at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:285) -- Ticking connection -- Details:     Connection: net.minecraft.network.NetworkManager@29c7e996 Stacktrace:     at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:180)     at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:790)     at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:668)     at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:279)     at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526)     at java.lang.Thread.run(Unknown Source) -- System Details -- Details:     Minecraft Version: 1.12.2     Operating System: Windows 10 (amd64) version 10.0     Java Version: 1.8.0_291, Oracle Corporation     Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation     Memory: 1306579696 bytes (1246 MB) / 2693267456 bytes (2568 MB) up to 3817865216 bytes (3641 MB)     JVM Flags: 3 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xms512m -Xmx4096m     IntCache: cache: 0, tcache: 0, allocated: 0, tallocated: 0     FML: MCP 9.42 Powered by Forge 14.23.5.2855 Optifine OptiFine_1.12.2_HD_U_G6_pre1 19 mods loaded, 19 mods active     States: 'U' = Unloaded 'L' = Loaded 'C' = Constructed 'H' = Pre-initialized 'I' = Initialized 'J' = Post-initialized 'A' = Available 'D' = Disabled 'E' = Errored     | State  | ID              | Version               | Source                                   | Signature                                |     |:------ |:--------------- |:--------------------- |:---------------------------------------- |:---------------------------------------- |     | LCHIJA | minecraft       | 1.12.2                | minecraft.jar                            | None                                     |     | LCHIJA | mcp             | 9.42                  | minecraft.jar                            | None                                     |     | LCHIJA | FML             | 8.0.99.99             | forge-1.12.2-14.23.5.2855-universal.jar  | e3c3d50c7c986df74c645c0ac54639741c90a557 |     | LCHIJA | forge           | 14.23.5.2855          | forge-1.12.2-14.23.5.2855-universal.jar  | e3c3d50c7c986df74c645c0ac54639741c90a557 |     | LCHIJA | securitycraft   | v1.8.22.2             | [1.12.2]+SecurityCraft+v1.8.22.2.jar     | None                                     |     | LCHIJA | customspawner   | 3.11.4                | Custom-Mob-Spawner-Mod-1.12.2.jar        | None                                     |     | LCHIJA | ptrmodellib     | 1.0.4                 | PTRLib-1.0.4.jar                         | None                                     |     | LCHIJA | props           | 2.6.3                 | Decocraft-2.6.3_1.12.2.jar               | None                                     |     | LCHIJA | jei             | 4.16.1.302            | jei_1.12.2-4.16.1.302.jar                | None                                     |     | LCHIJA | speedsterheroes | 1.12.2-2.0.7          | Quicksilver-Mod-1.12.2.jar               | None                                     |     | LCHIJA | lucraftcore     | 1.12.2-2.4.16         | LucraftCore-1.12.2-2.4.16.jar            | None                                     |     | LCHIJA | malisiscore     | 1.12.2-6.5.1-SNAPSHOT | malisiscore-1.12.2-6.5.1.jar             | None                                     |     | LCHIJA | malisisdoors    | 1.12.2-7.3.0          | malisisdoors-1.12.2-7.3.0.jar            | None                                     |     | LCHIJA | mocreatures     | 12.0.5                | Mo-Creatures-Mod-1.12.2.jar              | None                                     |     | LCHIJA | movingelevators | 1.2.34                | movingelevators-1.2.34-mc1.12.jar        | None                                     |     | LCHIJA | scp             | 2.4.0                 | SCP_Lockdown-1.12.2-2.4.0-hotfix.jar     | None                                     |     | LCHIJA | scple           | 1.0                   | scple-1.0.jar                            | None                                     |     | LCHIJA | thejungle       | 1.2006.1222           | Welcome-to-the-Jungle-Mod-1.12.2.jar     | None                                     |     | LCHIJA | worldedit       | 6.1.10                | worldedit-forge-mc1.12.2-6.1.10-dist.jar | None                                     |     Loaded coremods (and transformers):  LucraftCoreCoreMod (LucraftCore-1.12.2-2.4.16.jar)   lucraft.mods.lucraftcore.core.LCTransformer MalisisCorePlugin (malisiscore-1.12.2-6.5.1.jar)        GL info: ~~ERROR~~ RuntimeException: No OpenGL context found in the current thread.     Profiler Position: N/A (disabled)     Player Count: 1 / 8; [EntityPlayerMP['RedcreeperYT_'/1844, l='New World', x=453.50, y=4.00, z=91.50]]     Type: Integrated Server (map_client.txt)     Is Modded: Definitely; Client brand changed to 'fml,forge'     OptiFine Version: OptiFine_1.12.2_HD_U_G6_pre1     OptiFine Build: 20210323-161358     Render Distance Chunks: 8     Mipmaps: 4     Anisotropic Filtering: 1     Antialiasing: 0     Multitexture: false     Shaders: null     OpenGlVersion: 4.6.0 NVIDIA 466.27     OpenGlRenderer: NVIDIA GeForce GTX 1650 SUPER/PCIe/SSE2     OpenGlVendor: NVIDIA Corporation     CpuCount: 4
    • Goal: when Entity attacks player, it dies. Code: public class EventHandler { @SubscribeEvent public static void onLivingAttackEvent(LivingAttackEvent event) { if (event.getEntityLiving().getItemStackFromSlot(EquipmentSlotType.HEAD).getItem() == ItemInit.LAVA_HELMET.get() && event.getEntityLiving().getItemStackFromSlot(EquipmentSlotType.CHEST).getItem() == ItemInit.LAVA_CHEST.get() && event.getEntityLiving().getItemStackFromSlot(EquipmentSlotType.LEGS).getItem() == ItemInit.LAVA_LEGGINGS.get() && event.getEntityLiving().getItemStackFromSlot(EquipmentSlotType.FEET).getItem() == ItemInit.LAVA_BOOTS.get()) { if (event.getSource().getTrueSource().getEntity() instanceof MobEntity) { event.getSource().getTrueSource().getEntity().onKillCommand(); } } } } And: @Mod(LavaArmor.MODID) public class LavaArmor { public static final String MODID = "lavaarmor"; public LavaArmor() { IEventBus bus = FMLJavaModLoadingContext.get().getModEventBus(); bus.addListener(this::setup); ItemInit.ITEMS.register(bus); MinecraftForge.EVENT_BUS.register(this); MinecraftForge.EVENT_BUS.register(EventHandler.class); } @SuppressWarnings("deprecation") private void setup(final FMLCommonSetupEvent event) { } } I think I've done everything I've needed. Moreover, the exact same code works fine in my another project. What's wrong?
    • The same question. The only thing I could find is CommentedFileConfig.preserveInsertionOrder(), but either it doesn't work, or I'm doing something wrong...
    • I'M SO DUMB THANK YOU SO MUCH!!!!!!!!!!!
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.