Jump to content

[1.10.2] Hammer 3x3x1


DarkProd02

Recommended Posts

I believe you have to override the onBlockDestroyed method and destroy the 8 blocks around the one that the hammer itself broke. You need to know somehow what side did the player break this block from to determine in which direction you going to destroy the other 8. Back in 1.8.9 MovingObjectPosition was one way to do it. Not sure on 1.10.2 what works.
 

Edited by American2050
Link to comment
Share on other sites

Call Item::rayTrace to gain access to a RayTraceResult, which can give you a block, and specifically the side of the block. Be sure to checkRayTraceResult#Type though. It might be nothing "MISS" or an entity "ENTITY".

 

I would call said rayTrace method in an override of Item::onBlockDestroyed, and verify that the result's blockstate equals the blockstate being destroyed.

 

Also previously known as eAndPi.

"Pi, is there a station coming up where we can board your train of thought?" -Kronnn

Published Mods: Underworld

Handy links: Vic_'s Forge events Own WIP Tutorials.

Link to comment
Share on other sites

No.
This forum is for helping people with their own code.
Giving out copy-paste-code is not helpful, neither to you, who won't learn what the actual code does, nor us, who'd have to write detailed tutorials on where, how, why and when the code does whatever it does.

I've told you how to gain access to a block that the player is looking at, and how to get the specific side as well (Item::rayTrace).
Now try and use it.
We can help you along the way. We will not send you off with a free ticket.

  • Like 1

Also previously known as eAndPi.

"Pi, is there a station coming up where we can board your train of thought?" -Kronnn

Published Mods: Underworld

Handy links: Vic_'s Forge events Own WIP Tutorials.

Link to comment
Share on other sites

ok here is my code : 

public boolean onBlockDestroyed(ItemStack stack, World worldIn, IBlockState state, BlockPos pos, EntityLivingBase entityLiving)
  {
    if ((!worldIn.isRemote) && 
      ((entityLiving instanceof EntityPlayer)))
    {
      EntityPlayer player = (EntityPlayer)entityLiving;
      
      RayTraceResult raytraceresult = rayTrace(player.getEntityWorld(), player, true);
      if (raytraceresult != null)
      {
        BlockPos[] blockPosesNS = { new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY() - 1, pos.getZ()) };
        
        BlockPos[] blockPosesEW = { new BlockPos(pos.getX(), pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ() - 1) };
        
        BlockPos[] blockPosesUD = { new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ() - 1) };
        BlockPos[] blockPoses;
        if (raytraceresult.sideHit.equals(EnumFacing.NORTH))
        {
          blockPoses = blockPosesNS;
        }
        else
        {
          BlockPos[] blockPoses;
          if (raytraceresult.sideHit.equals(EnumFacing.SOUTH))
          {
            blockPoses = blockPosesNS;
          }
          else
          {
            BlockPos[] blockPoses;
            if (raytraceresult.sideHit.equals(EnumFacing.EAST))
            {
              blockPoses = blockPosesEW;
            }
            else
            {
              BlockPos[] blockPoses;
              if (raytraceresult.sideHit.equals(EnumFacing.WEST))
              {
                blockPoses = blockPosesEW;
              }
              else
              {
                BlockPos[] blockPoses;
                if (raytraceresult.sideHit.equals(EnumFacing.UP))
                {
                  blockPoses = blockPosesUD;
                }
                else
                {
                  BlockPos[] blockPoses;
                  if (raytraceresult.sideHit.equals(EnumFacing.DOWN)) {
                    blockPoses = blockPosesUD;
                  } else {
                    return super.onBlockDestroyed(stack, worldIn, state, pos, entityLiving);
                  }
                }
              }
            }
          }
        }
        BlockPos[] blockPoses;
        for (BlockPos blockPos : blockPoses)
        {
          Boolean isvalidate = Boolean.valueOf(false);
          
          int x = blockPos.getX();
          int y = blockPos.getY();
          int z = blockPos.getZ();
          for (Material material : MATERIALS) {
            if (worldIn.getBlockState(blockPos).getMaterial().equals(material)) {
              isvalidate = Boolean.valueOf(true);
            }
          }
          if (worldIn.getBlockState(blockPos).getBlock().equals(Blocks.BEDROCK)) {
            isvalidate = Boolean.valueOf(false);
          }
        }
      }
    }
    stack.damageItem(1, entityLiving);
    return false;
}

 

Link to comment
Share on other sites

I'm sorry, but... and?
Your code doesn't actually break any blocks...
It just ends with "i have these blocks."

 

You are validating the block's materials, but nothing else... of course the blocks won't break.

At the end of your for-each blockpos loop, call ForgeHooks#canHarvestBlock (to make sure the player can break these blocks (in the case of protection plugins etc)) and if they can, call World::destroyBlock with true to make sure the block's drops actually drop.

 

 

 

Also previously known as eAndPi.

"Pi, is there a station coming up where we can board your train of thought?" -Kronnn

Published Mods: Underworld

Handy links: Vic_'s Forge events Own WIP Tutorials.

Link to comment
Share on other sites

it still not working 

package fr.darkprod.archymod.items;

import java.util.Iterator;
import java.util.List;

import fr.darkprod.archymod.ArchyMod;
import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.block.state.IBlockState;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Blocks;
import net.minecraft.inventory.EntityEquipmentSlot;
import net.minecraft.item.Item;
import net.minecraft.item.Item.ToolMaterial;
import net.minecraft.item.ItemPickaxe;
import net.minecraft.item.ItemStack;
import net.minecraft.item.crafting.FurnaceRecipes;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.RayTraceResult;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;

public class ItemHammer
  extends ItemPickaxe
{
  public long time = System.currentTimeMillis();
  protected static final Material[] MATERIALS = { Material.ROCK, Material.IRON, Material.ICE, Material.GLASS, Material.PISTON, Material.ANVIL, Material.SNOW, Material.CRAFTED_SNOW, Material.CLAY };
  
  public ItemHammer(String name,Item.ToolMaterial material)
  {
    super(material);
    setCreativeTab(ArchyMod.ArchyMod);
    setRegistryName(name);
    setUnlocalizedName(name);
  }
  
  public int getItemEnchantability()
  {
    return 0;
  }
  
  public int getItemEnchantability(ItemStack stack)
  {
    return 0;
  }
  
  public boolean isBookEnchantable(ItemStack stack, ItemStack book)
  {
    return false;
  }
  
  public boolean getIsRepairable(ItemStack toRepair, ItemStack repair)
  {
    return false;
  }
  
  public void onUpdate(ItemStack stack, World worldIn, Entity entityIn, int itemSlot, boolean isSelected)
  {
    if ((!worldIn.isRemote) && 
      ((entityIn instanceof EntityPlayer)))
    {
      EntityPlayer entityPlayer = (EntityPlayer)entityIn;
      if (entityPlayer.getItemStackFromSlot(EntityEquipmentSlot.MAINHAND) == null) {
        return;
      }
    }
  }
  
  public boolean onBlockDestroyed(ItemStack stack, World worldIn, IBlockState state, BlockPos pos, EntityLivingBase entityLiving)
  {
    if ((!worldIn.isRemote) && 
      ((entityLiving instanceof EntityPlayer)))
    {
      EntityPlayer player = (EntityPlayer)entityLiving;
      
      RayTraceResult raytraceresult = rayTrace(player.getEntityWorld(), player, true);
      BlockPos[] blockPoses;
      if (raytraceresult != null)
      {
        BlockPos[] blockPosesNS = { new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY() - 1, pos.getZ()) };
        
        BlockPos[] blockPosesEW = { new BlockPos(pos.getX(), pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ() - 1) };
        
        BlockPos[] blockPosesUD = { new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ() - 1) };

        if (raytraceresult.sideHit.equals(EnumFacing.NORTH))
        {
          blockPoses = blockPosesNS;
        }
        else
        {

          if (raytraceresult.sideHit.equals(EnumFacing.SOUTH))
          {
            blockPoses = blockPosesNS;
          }
          else
          {

            if (raytraceresult.sideHit.equals(EnumFacing.EAST))
            {
              blockPoses = blockPosesEW;
            }
            else
            {
              if (raytraceresult.sideHit.equals(EnumFacing.WEST))
              {
                blockPoses = blockPosesEW;
              }
              else
              {

                if (raytraceresult.sideHit.equals(EnumFacing.UP))
                {
                  blockPoses = blockPosesUD;
                }
                else
                {

                  if (raytraceresult.sideHit.equals(EnumFacing.DOWN)) {
                    blockPoses = blockPosesUD;
                  } else {
                    return super.onBlockDestroyed(stack, worldIn, state, pos, entityLiving);
                  }
                }
              }
            }
          }
        }
        for (BlockPos blockPos : blockPoses)
        {
          Boolean isvalidate = Boolean.valueOf(false);
          
          int x = blockPos.getX();
          int y = blockPos.getY();
          int z = blockPos.getZ();
          for (Material material : MATERIALS) {
            if (worldIn.getBlockState(blockPos).getMaterial().equals(material)) {
              isvalidate = Boolean.valueOf(true);
            }
          }
          if (worldIn.getBlockState(blockPos).getBlock().equals(Blocks.BEDROCK)) {
            isvalidate = Boolean.valueOf(false);
          }
        }
      }
    }
    stack.damageItem(1, entityLiving);
    return false;
  }
  public static boolean canHarvestBlock(Block block, EntityPlayer player, IBlockAccess world,BlockPos pos) {
	return true;
	  
  }
}

 

Link to comment
Share on other sites

That is not what I said.
When someone states "call method x" you do not override it as you did here, and especially not in a class that is not an instance of the class using the original method...

What you did is re-create a method that blindly says "yes" whenever it is asked.
Calling a method means you actually call the method. Here that means running if(ForgeHooks.canHarvestBlock(Block, Player, World, BlockPos)){//run code here if player can break this block}

Edited by Matryoshika

Also previously known as eAndPi.

"Pi, is there a station coming up where we can board your train of thought?" -Kronnn

Published Mods: Underworld

Handy links: Vic_'s Forge events Own WIP Tutorials.

Link to comment
Share on other sites

like this 

package fr.darkprod.archymod.items;

import java.util.Iterator;
import java.util.List;

import fr.darkprod.archymod.ArchyMod;
import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.block.state.IBlockState;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Blocks;
import net.minecraft.inventory.EntityEquipmentSlot;
import net.minecraft.item.Item;
import net.minecraft.item.Item.ToolMaterial;
import net.minecraft.item.ItemPickaxe;
import net.minecraft.item.ItemStack;
import net.minecraft.item.crafting.FurnaceRecipes;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.RayTraceResult;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraftforge.common.ForgeHooks;

public class ItemHammer
  extends ItemPickaxe
{
  public long time = System.currentTimeMillis();
  protected static final Material[] MATERIALS = { Material.ROCK, Material.IRON, Material.ICE, Material.GLASS, Material.PISTON, Material.ANVIL, Material.SNOW, Material.CRAFTED_SNOW, Material.CLAY };
  
  public ItemHammer(String name,Item.ToolMaterial material)
  {
    super(material);
    setCreativeTab(ArchyMod.ArchyMod);
    setRegistryName(name);
    setUnlocalizedName(name);
  }
  
  public int getItemEnchantability()
  {
    return 0;
  }
  
  public int getItemEnchantability(ItemStack stack)
  {
    return 0;
  }
  
  public boolean isBookEnchantable(ItemStack stack, ItemStack book)
  {
    return false;
  }
  
  public boolean getIsRepairable(ItemStack toRepair, ItemStack repair)
  {
    return false;
  }
  
  public void onUpdate(ItemStack stack, World worldIn, Entity entityIn, int itemSlot, boolean isSelected)
  {
    if ((!worldIn.isRemote) && 
      ((entityIn instanceof EntityPlayer)))
    {
      EntityPlayer entityPlayer = (EntityPlayer)entityIn;
      if (entityPlayer.getItemStackFromSlot(EntityEquipmentSlot.MAINHAND) == null) {
        return;
      }
    }
  }
  
  public boolean onBlockDestroyed(ItemStack stack, World worldIn, IBlockState state, BlockPos pos, EntityLivingBase entityLiving)
  {
	
    if ((!worldIn.isRemote) && 
      ((entityLiving instanceof EntityPlayer)))
    {
      EntityPlayer player = (EntityPlayer)entityLiving;
      
      RayTraceResult raytraceresult = rayTrace(player.getEntityWorld(), player, true);
      BlockPos[] blockPoses;
      if (raytraceresult != null)
      {
        BlockPos[] blockPosesNS = { new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY() - 1, pos.getZ()) };
        
        BlockPos[] blockPosesEW = { new BlockPos(pos.getX(), pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ() - 1) };
        
        BlockPos[] blockPosesUD = { new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ() - 1) };

        if (raytraceresult.sideHit.equals(EnumFacing.NORTH))
        {
          blockPoses = blockPosesNS;
        }
        else
        {

          if (raytraceresult.sideHit.equals(EnumFacing.SOUTH))
          {
            blockPoses = blockPosesNS;
          }
          else
          {

            if (raytraceresult.sideHit.equals(EnumFacing.EAST))
            {
              blockPoses = blockPosesEW;
            }
            else
            {
              if (raytraceresult.sideHit.equals(EnumFacing.WEST))
              {
                blockPoses = blockPosesEW;
              }
              else
              {

                if (raytraceresult.sideHit.equals(EnumFacing.UP))
                {
                  blockPoses = blockPosesUD;
                }
                else
                {

                  if (raytraceresult.sideHit.equals(EnumFacing.DOWN)) {
                    blockPoses = blockPosesUD;
                  } else {
                    return super.onBlockDestroyed(stack, worldIn, state, pos, entityLiving);
                  }
                }
              }
            }
          }
        }
        for (BlockPos blockPos : blockPoses)
        {
          Boolean isvalidate = Boolean.valueOf(false);
          
          int x = blockPos.getX();
          int y = blockPos.getY();
          int z = blockPos.getZ();
          for (Material material : MATERIALS) {
            if (worldIn.getBlockState(blockPos).getMaterial().equals(material)) {
              isvalidate = Boolean.valueOf(true);
            }
          }
          if (worldIn.getBlockState(blockPos).getBlock().equals(Blocks.BEDROCK)) {
            isvalidate = Boolean.valueOf(false);
          }
        }
        if(ForgeHooks.canHarvestBlock(null, player, worldIn, pos)){
        	if(player.capabilities.isCreativeMode) {
        		
        	}
        }
        
      }
    }
    stack.damageItem(1, entityLiving);
    return false;
    
  }
}

 

Link to comment
Share on other sites

Yes, and no.
Never use null unless you are absolutely sure that it is harmless. Most of the time, using null with cause nullpointerexceptions, aka crash the game.
Use World::getBlockState::getBlock to get the block.

As I mentioned in my previous post, ForgeHooks::canHarvestBlock checks for you if the player CAN break the block. If it returns true, use World::breakBlock with true as the second argument to actually break the block.

Also previously known as eAndPi.

"Pi, is there a station coming up where we can board your train of thought?" -Kronnn

Published Mods: Underworld

Handy links: Vic_'s Forge events Own WIP Tutorials.

Link to comment
Share on other sites

ok thx a lot my code is good now?

package fr.darkprod.archymod.items;

import java.util.Iterator;
import java.util.List;

import fr.darkprod.archymod.ArchyMod;
import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.block.state.IBlockState;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Blocks;
import net.minecraft.inventory.EntityEquipmentSlot;
import net.minecraft.item.Item;
import net.minecraft.item.Item.ToolMaterial;
import net.minecraft.item.ItemPickaxe;
import net.minecraft.item.ItemStack;
import net.minecraft.item.crafting.FurnaceRecipes;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.RayTraceResult;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraft.world.WorldEntitySpawner;
import net.minecraftforge.common.ForgeHooks;

public class ItemHammer
  extends ItemPickaxe
{
  public long time = System.currentTimeMillis();
  protected static final Material[] MATERIALS = { Material.ROCK, Material.IRON, Material.ICE, Material.GLASS, Material.PISTON, Material.ANVIL, Material.SNOW, Material.CRAFTED_SNOW, Material.CLAY };
  
  public ItemHammer(String name,Item.ToolMaterial material)
  {
    super(material);
    setCreativeTab(ArchyMod.ArchyMod);
    setRegistryName(name);
    setUnlocalizedName(name);
  }
  
  public int getItemEnchantability()
  {
    return 0;
  }
  
  public int getItemEnchantability(ItemStack stack)
  {
    return 0;
  }
  
  public boolean isBookEnchantable(ItemStack stack, ItemStack book)
  {
    return false;
  }
  
  public boolean getIsRepairable(ItemStack toRepair, ItemStack repair)
  {
    return false;
  }
  
  public void onUpdate(ItemStack stack, World worldIn, Entity entityIn, int itemSlot, boolean isSelected)
  {
    if ((!worldIn.isRemote) && 
      ((entityIn instanceof EntityPlayer)))
    {
      EntityPlayer entityPlayer = (EntityPlayer)entityIn;
      if (entityPlayer.getItemStackFromSlot(EntityEquipmentSlot.MAINHAND) == null) {
        return;
      }
    }
  }
  
  public boolean onBlockDestroyed(ItemStack stack, World worldIn, IBlockState state, BlockPos pos, EntityLivingBase entityLiving)
  {
	
    if ((!worldIn.isRemote) && 
      ((entityLiving instanceof EntityPlayer)))
    {
      EntityPlayer player = (EntityPlayer)entityLiving;
      
      RayTraceResult raytraceresult = rayTrace(player.getEntityWorld(), player, true);
      BlockPos[] blockPoses;
      if (raytraceresult != null)
      {
        BlockPos[] blockPosesNS = { new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY() - 1, pos.getZ()) };
        
        BlockPos[] blockPosesEW = { new BlockPos(pos.getX(), pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ() - 1) };
        
        BlockPos[] blockPosesUD = { new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ() - 1) };

        if (raytraceresult.sideHit.equals(EnumFacing.NORTH))
        {
          blockPoses = blockPosesNS;
        }
        else
        {

          if (raytraceresult.sideHit.equals(EnumFacing.SOUTH))
          {
            blockPoses = blockPosesNS;
          }
          else
          {

            if (raytraceresult.sideHit.equals(EnumFacing.EAST))
            {
              blockPoses = blockPosesEW;
            }
            else
            {
              if (raytraceresult.sideHit.equals(EnumFacing.WEST))
              {
                blockPoses = blockPosesEW;
              }
              else
              {

                if (raytraceresult.sideHit.equals(EnumFacing.UP))
                {
                  blockPoses = blockPosesUD;
                }
                else
                {

                  if (raytraceresult.sideHit.equals(EnumFacing.DOWN)) {
                    blockPoses = blockPosesUD;
                  } else {
                    return super.onBlockDestroyed(stack, worldIn, state, pos, entityLiving);
                  }
                }
              }
            }
          }
        }
        for (BlockPos blockPos : blockPoses)
        {
          Boolean isvalidate = Boolean.valueOf(false);
          
          int x = blockPos.getX();
          int y = blockPos.getY();
          int z = blockPos.getZ();
          for (Material material : MATERIALS) {
            if (worldIn.getBlockState(blockPos).getMaterial().equals(material)) {
              isvalidate = Boolean.valueOf(true);
            }
          }
          if (worldIn.getBlockState(blockPos).getBlock().equals(Blocks.BEDROCK)) {
            isvalidate = Boolean.valueOf(false);
          }
        }
        if(ForgeHooks.canHarvestBlock(worldIn.getBlockState(pos).getBlock(), player, worldIn, pos)){
        	if(player.canHarvestBlock(state)) {
        		worldIn.destroyBlock(pos, true);
        	}
        }
        
      }
    }
    stack.damageItem(1, entityLiving);
    return false;
    
  }
}

edit : i tried it the hammer break blocks but he doesn't break blocks in 3x3x1

Edited by DarkProd02
tried it
Link to comment
Share on other sites

1 hour ago, DarkProd02 said:

ok thx a lot my code is good now?


package fr.darkprod.archymod.items;

import java.util.Iterator;
import java.util.List;

import fr.darkprod.archymod.ArchyMod;
import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.block.state.IBlockState;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Blocks;
import net.minecraft.inventory.EntityEquipmentSlot;
import net.minecraft.item.Item;
import net.minecraft.item.Item.ToolMaterial;
import net.minecraft.item.ItemPickaxe;
import net.minecraft.item.ItemStack;
import net.minecraft.item.crafting.FurnaceRecipes;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.RayTraceResult;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraft.world.WorldEntitySpawner;
import net.minecraftforge.common.ForgeHooks;

public class ItemHammer
  extends ItemPickaxe
{
  public long time = System.currentTimeMillis();
  protected static final Material[] MATERIALS = { Material.ROCK, Material.IRON, Material.ICE, Material.GLASS, Material.PISTON, Material.ANVIL, Material.SNOW, Material.CRAFTED_SNOW, Material.CLAY };
  
  public ItemHammer(String name,Item.ToolMaterial material)
  {
    super(material);
    setCreativeTab(ArchyMod.ArchyMod);
    setRegistryName(name);
    setUnlocalizedName(name);
  }
  
  public int getItemEnchantability()
  {
    return 0;
  }
  
  public int getItemEnchantability(ItemStack stack)
  {
    return 0;
  }
  
  public boolean isBookEnchantable(ItemStack stack, ItemStack book)
  {
    return false;
  }
  
  public boolean getIsRepairable(ItemStack toRepair, ItemStack repair)
  {
    return false;
  }
  
  public void onUpdate(ItemStack stack, World worldIn, Entity entityIn, int itemSlot, boolean isSelected)
  {
    if ((!worldIn.isRemote) && 
      ((entityIn instanceof EntityPlayer)))
    {
      EntityPlayer entityPlayer = (EntityPlayer)entityIn;
      if (entityPlayer.getItemStackFromSlot(EntityEquipmentSlot.MAINHAND) == null) {
        return;
      }
    }
  }
  
  public boolean onBlockDestroyed(ItemStack stack, World worldIn, IBlockState state, BlockPos pos, EntityLivingBase entityLiving)
  {
	
    if ((!worldIn.isRemote) && 
      ((entityLiving instanceof EntityPlayer)))
    {
      EntityPlayer player = (EntityPlayer)entityLiving;
      
      RayTraceResult raytraceresult = rayTrace(player.getEntityWorld(), player, true);
      BlockPos[] blockPoses;
      if (raytraceresult != null)
      {
        BlockPos[] blockPosesNS = { new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY() - 1, pos.getZ()) };
        
        BlockPos[] blockPosesEW = { new BlockPos(pos.getX(), pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ() - 1) };
        
        BlockPos[] blockPosesUD = { new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ() - 1) };

        if (raytraceresult.sideHit.equals(EnumFacing.NORTH))
        {
          blockPoses = blockPosesNS;
        }
        else
        {

          if (raytraceresult.sideHit.equals(EnumFacing.SOUTH))
          {
            blockPoses = blockPosesNS;
          }
          else
          {

            if (raytraceresult.sideHit.equals(EnumFacing.EAST))
            {
              blockPoses = blockPosesEW;
            }
            else
            {
              if (raytraceresult.sideHit.equals(EnumFacing.WEST))
              {
                blockPoses = blockPosesEW;
              }
              else
              {

                if (raytraceresult.sideHit.equals(EnumFacing.UP))
                {
                  blockPoses = blockPosesUD;
                }
                else
                {

                  if (raytraceresult.sideHit.equals(EnumFacing.DOWN)) {
                    blockPoses = blockPosesUD;
                  } else {
                    return super.onBlockDestroyed(stack, worldIn, state, pos, entityLiving);
                  }
                }
              }
            }
          }
        }
        for (BlockPos blockPos : blockPoses)
        {
          Boolean isvalidate = Boolean.valueOf(false);
          
          int x = blockPos.getX();
          int y = blockPos.getY();
          int z = blockPos.getZ();
          for (Material material : MATERIALS) {
            if (worldIn.getBlockState(blockPos).getMaterial().equals(material)) {
              isvalidate = Boolean.valueOf(true);
            }
          }
          if (worldIn.getBlockState(blockPos).getBlock().equals(Blocks.BEDROCK)) {
            isvalidate = Boolean.valueOf(false);
          }
        }
        if(ForgeHooks.canHarvestBlock(worldIn.getBlockState(pos).getBlock(), player, worldIn, pos)){
        	if(player.canHarvestBlock(state)) {
        		worldIn.destroyBlock(pos, true);
        	}
        }
        
      }
    }
    stack.damageItem(1, entityLiving);
    return false;
    
  }
}

edit : i tried it the hammer break blocks but he doesn't break blocks in 3x3x1

Why you have the onUpdate ?

Can you do a Switch with the result of the raytrace instead of those if else statements? That will probably make things cleaner.

 

Also I think it's not breaking blocks, because when you actually call the worldIn.detroyBlock you passing "pos" and not "blockPos" that you using on the for loop.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.