[1.10.2] ForgeRegistries.ITEMS.register or GameRegistry.register(item)?

[mooL 0]

Hello I came across ForgeRegistries.ITEMS.register, ForgeRegistries.BLOCKS.register, etc and I was wondering, Is there a difference between that and GameRegistry.register(item)? Do they both do the same thing? Which one should I use? 

Edited January 5, 2018 by mooL

[LeoCTH 0]

GameRegistry.register() is now private and internal.

Use register events, or ForgeRegistries above.

[mooL 0]

what do you mean by private and internal? as in only minecraft itself uses it, and not modders?

[Abastro 123]

5 minutes ago, mooL said:

what do you mean by private and internal? as in only minecraft itself uses it, and not modders?

Minecraft Forge uses it internally, if I recall correctly.

It's recommended to use register events: https://mcforge.readthedocs.io/en/latest/concepts/registries/

[LeoCTH 0]

7 hours ago, Abastro said:

Minecraft Forge uses it internally, if I recall correctly.

It's recommended to use register events: https://mcforge.readthedocs.io/en/latest/concepts/registries/

yes exactly...

but in my own personal case I use ForgeRegistries: LINK

and GameRegistry.register is REALLY private access, and it's javadocs also says it's internal.

[Matryoshika 118]

It's not just "recommended".
There are multiple issues just these last weeks where people are registering though ForgeRegistries.
As per the JavaDoc for ForgeRegistries "..but queries and iterations can use this".

Why should one use the RegistryEvents when you can be lazy and register objects like this?
Well, registration has to happen during a specific interval in Minecraft's life-cycle, which the RegistryEvents were made specifically for, or you may end up with "The object [name] is being added too late" because Forge has called ForgeRegistry::freeze because whoops, time's up, and you shouldn't be messing with this stuff now.

[Draco18s 2375]

10 hours ago, LeoCTH said:

ForgeRegistries above.

No. And if anyone can point me at a tutorial that is saying to do this, link it, so I can go punch that person in the face for being an idiot.

Problematic Code Issue #1

Edited January 5, 2018 by Draco18s

[LexManos 1607]

Seriously, Use the event not the static registries. Timing of registration is important. So stop doing it in random places. I was tempted to name the event 'RegisterYourStuffHereAndStopBreakingEverythingElseSeriouslyStopRegisteringYourCrapInRandomPlacesItBreaksThingsAndHoldsUsBackFromBeingAbleToDoCoolThingsThatWeveBeenWantingToDoForFourYearsNow' but I decided against that as it was a bit long

[Draco18s 2375]

2 hours ago, LexManos said:

Seriously, Use the event not the static registries. Timing of registration is important. So stop doing it in random places. I was tempted to name the event 'RegisterYourStuffHereAndStopBreakingEverythingElseSeriouslyStopRegisteringYourCrapInRandomPlacesItBreaksThingsAndHoldsUsBackFromBeingAbleToDoCoolThingsThatWeveBeenWantingToDoForFourYearsNow' but I decided against that as it was a bit long

RegisterShitHereAndStopBreakingStuffEvent would have worked just fine.

 

[LeoCTH 0]

6 hours ago, LexManos said:

Seriously, Use the event not the static registries. Timing of registration is important. So stop doing it in random places. I was tempted to name the event 'RegisterYourStuffHereAndStopBreakingEverythingElseSeriouslyStopRegisteringYourCrapInRandomPlacesItBreaksThingsAndHoldsUsBackFromBeingAbleToDoCoolThingsThatWeveBeenWantingToDoForFourYearsNow' but I decided against that as it was a bit long

Okokokokok guys

I'm just gonna make a new thread cuz I don't want to spam at other's threads again

lol