Jump to content
  • Home
  • Files
  • Docs
Topics
  • All Content

  • This Topic
  • This Forum

  • Advanced Search
  • Existing user? Sign In  

    Sign In



    • Not recommended on shared computers


    • Forgot your password?

  • Sign Up
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • [1.10.2] ForgeRegistries.ITEMS.register or GameRegistry.register(item)?
Currently Supported: 1.16.X (Latest) and 1.15.X (LTS)
Sign in to follow this  
Followers 1
mooL

[1.10.2] ForgeRegistries.ITEMS.register or GameRegistry.register(item)?

By mooL, January 5, 2018 in Modder Support

  • Reply to this topic
  • Start new topic

Recommended Posts

mooL    0

mooL

mooL    0

  • Tree Puncher
  • mooL
  • Members
  • 0
  • 21 posts
Posted January 5, 2018 (edited)

Hello I came across ForgeRegistries.ITEMS.register, ForgeRegistries.BLOCKS.register, etc and I was wondering, Is there a difference between that and GameRegistry.register(item)? Do they both do the same thing? Which one should I use? 

Edited January 5, 2018 by mooL
  • Quote

Share this post


Link to post
Share on other sites

LeoCTH    0

LeoCTH

LeoCTH    0

  • Stone Miner
  • LeoCTH
  • Members
  • 0
  • 58 posts
Posted January 5, 2018

GameRegistry.register() is now private and internal.

Use register events, or ForgeRegistries above.

  • Quote

Share this post


Link to post
Share on other sites

mooL    0

mooL

mooL    0

  • Tree Puncher
  • mooL
  • Members
  • 0
  • 21 posts
Posted January 5, 2018

what do you mean by private and internal? as in only minecraft itself uses it, and not modders?

  • Quote

Share this post


Link to post
Share on other sites

Abastro    123

Abastro

Abastro    123

  • World Shaper
  • Abastro
  • Forge Modder
  • 123
  • 1075 posts
Posted January 5, 2018
5 minutes ago, mooL said:

what do you mean by private and internal? as in only minecraft itself uses it, and not modders?

Minecraft Forge uses it internally, if I recall correctly.

It's recommended to use register events: https://mcforge.readthedocs.io/en/latest/concepts/registries/

  • Quote

I. Stellarium for Minecraft: Configurable Universe for Minecraft! (WIP)

II. Stellar Sky, Better Star Rendering&Sky Utility mod, had separated from Stellarium.

Share this post


Link to post
Share on other sites

LeoCTH    0

LeoCTH

LeoCTH    0

  • Stone Miner
  • LeoCTH
  • Members
  • 0
  • 58 posts
Posted January 5, 2018
7 hours ago, Abastro said:

Minecraft Forge uses it internally, if I recall correctly.

It's recommended to use register events: https://mcforge.readthedocs.io/en/latest/concepts/registries/

yes exactly...

but in my own personal case I use ForgeRegistries: LINK

and GameRegistry.register is REALLY private access, and it's javadocs also says it's internal.

  • Quote

Share this post


Link to post
Share on other sites

Matryoshika    118

Matryoshika

Matryoshika    118

  • Dragon Slayer
  • Matryoshika
  • Forge Modder
  • 118
  • 523 posts
Posted January 5, 2018

It's not just "recommended".
There are multiple issues just these last weeks where people are registering though ForgeRegistries.
As per the JavaDoc for ForgeRegistries "..but queries and iterations can use this".


Why should one use the RegistryEvents when you can be lazy and register objects like this?
Well, registration has to happen during a specific interval in Minecraft's life-cycle, which the RegistryEvents were made specifically for, or you may end up with "The object [name] is being added too late" because Forge has called ForgeRegistry::freeze because whoops, time's up, and you shouldn't be messing with this stuff now.

  • Quote

Also previously known as eAndPi.

"Pi, is there a station coming up where we can board your train of thought?" -Kronnn

Published Mods: Underworld

Handy links: Vic_'s Forge events Own WIP Tutorials.

Share this post


Link to post
Share on other sites

Draco18s    2414

Draco18s

Draco18s    2414

  • Reality Controller
  • Draco18s
  • Members
  • 2414
  • 15995 posts
Posted January 5, 2018 (edited)
10 hours ago, LeoCTH said:

ForgeRegistries above.

No. And if anyone can point me at a tutorial that is saying to do this, link it, so I can go punch that person in the face for being an idiot.

Problematic Code Issue #1

Edited January 5, 2018 by Draco18s
  • Like 2
  • Quote

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Share this post


Link to post
Share on other sites

LexManos    1620

LexManos

LexManos    1620

  • Reality Controller
  • LexManos
  • Forge Code God
  • 1620
  • 8954 posts
Posted January 5, 2018

Seriously, Use the event not the static registries. Timing of registration is important. So stop doing it in random places. I was tempted to name the event 'RegisterYourStuffHereAndStopBreakingEverythingElseSeriouslyStopRegisteringYourCrapInRandomPlacesItBreaksThingsAndHoldsUsBackFromBeingAbleToDoCoolThingsThatWeveBeenWantingToDoForFourYearsNow' but I decided against that as it was a bit long ;)

  • Like 5
  • Quote

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Patreon: http://www.patreon.com/lexmanos
Paypal: http://paypal.me/LexManos

BitCoin: 1Q8rWvUNMM2T1ZfDaFeeYQyVXtYoeT6tTn

Share this post


Link to post
Share on other sites

Draco18s    2414

Draco18s

Draco18s    2414

  • Reality Controller
  • Draco18s
  • Members
  • 2414
  • 15995 posts
Posted January 6, 2018
2 hours ago, LexManos said:

Seriously, Use the event not the static registries. Timing of registration is important. So stop doing it in random places. I was tempted to name the event 'RegisterYourStuffHereAndStopBreakingEverythingElseSeriouslyStopRegisteringYourCrapInRandomPlacesItBreaksThingsAndHoldsUsBackFromBeingAbleToDoCoolThingsThatWeveBeenWantingToDoForFourYearsNow' but I decided against that as it was a bit long ;)

RegisterShitHereAndStopBreakingStuffEvent would have worked just fine.

 

  • Like 1
  • Quote

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Share this post


Link to post
Share on other sites

LeoCTH    0

LeoCTH

LeoCTH    0

  • Stone Miner
  • LeoCTH
  • Members
  • 0
  • 58 posts
Posted January 6, 2018
6 hours ago, LexManos said:

Seriously, Use the event not the static registries. Timing of registration is important. So stop doing it in random places. I was tempted to name the event 'RegisterYourStuffHereAndStopBreakingEverythingElseSeriouslyStopRegisteringYourCrapInRandomPlacesItBreaksThingsAndHoldsUsBackFromBeingAbleToDoCoolThingsThatWeveBeenWantingToDoForFourYearsNow' but I decided against that as it was a bit long ;)

Okokokokok guys

I'm just gonna make a new thread cuz I don't want to spam at other's threads again

lol

  • Quote

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

    • Insert image from URL
×
  • Desktop
  • Tablet
  • Phone
Sign in to follow this  
Followers 1
Go To Topic Listing



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • diesieben07
      The game crashed whilst rendering overlay

      By diesieben07 · Posted 45 minutes ago

      In the future please make your own thread instead of posting in an old, unrelated thread.   Delete this file.
    • FactionsFire
      Exit code 0 Sorry for inconvenience

      By FactionsFire · Posted 47 minutes ago

      I am trying to lanuch 1.8.9 forge and i get "An unexpected issue happened and the game has crashed exit sorry for inconvenience exit code 0"" And this has happened for about a week. 
    • Merken
      The game crashed whilst rendering overlay

      By Merken · Posted 51 minutes ago

      The game crashed whilst rendering overlay Error: net.minecraftforge.fml.config.ConfigFileTypeHandler$ConfigLoadingException: Failed loading config file forge-client.toml of type CLIENT for modid forge Exit Code: -1
    • Merken
      The game crashed whilst rendering overlay

      By Merken · Posted 56 minutes ago

      The game crashed whilst rendering overlay Error: net.minecraftforge.fml.config.ConfigFileTypeHandler$ConfigLoadingException: Failed loading config file forge-client.toml of type CLIENT for modid forge Exit Code: -1
    • diesieben07
      My game keeps crashing

      By diesieben07 · Posted 2 hours ago

      You do not. In the future please make your own thread instead of posting in some random thread that looks vaguely similar.   Your Optifine version is outdated and not listed as compatible with your version of Forge. Refer to the Optifine downloads page regarding compatibility with Forge.
  • Topics

    • Merken
      2
      The game crashed whilst rendering overlay

      By Merken
      Started 51 minutes ago

    • FactionsFire
      0
      Exit code 0 Sorry for inconvenience

      By FactionsFire
      Started 42 minutes ago

    • seekR4621
      1
      My game keeps crashing

      By seekR4621
      Started 2 hours ago

    • NorthWestWind
      2
      [1.16.x] Stop Held Item blobbing in Hand

      By NorthWestWind
      Started 2 hours ago

    • ehbean
      1
      1.16.x Custom Furnace/Brewing Stand

      By ehbean
      Started 11 hours ago

  • Who's Online (See full list)

    • diesieben07
    • Ghost0nLinéaire
    • charlie121kkt
    • FactionsFire
    • Nanook
    • GermanBucket
    • rhinitis
    • Differentiation
  • All Activity
  • Home
  • Mod Developer Central
  • Modder Support
  • [1.10.2] ForgeRegistries.ITEMS.register or GameRegistry.register(item)?
  • Theme

Copyright © 2019 ForgeDevelopment LLC · Ads by Longitude Ads LLC Powered by Invision Community