[1.12] Custom item in all tabs

[WildHeart]

Hello, i created a custom tab and custom items and when i open CreativeInventory, i see a my items in all tabs. How to fix it?

Code Item:

class ItemMoney: Item
{
    init
    {
        this.setRegistryName("money");
        this.setUnlocalizedName("money");
        this.setCreativeTab(Crank.tab);
        this.setHasSubtypes(true);
    }

    override fun getSubItems(tab: CreativeTabs, subItems: NonNullList<ItemStack>)
    {
        MoneyType.values().mapTo(subItems) { ItemStack(this, 1, it.meta) }
    }

    override fun getUnlocalizedName(stack: ItemStack?): String
    {
        return super.getUnlocalizedName() + "." + MoneyType.byMetadata(stack!!.metadata).getName()
    }
}

Code Tab:

class CustomTab: CreativeTabs("customtab")
{
    override fun getTabIconItem(): ItemStack
    {
        return ItemStack(Items.APPLE)
    }
}

 

[Differentiation]

5 minutes ago, WildHeart said:

Hello, i created a custom tab and custom items and when i open CreativeInventory, i see a my items in all tabs. How to fix it?

Code Item:

class ItemMoney: Item
{
    init
    {
        this.setRegistryName("money");
        this.setUnlocalizedName("money");
        this.setCreativeTab(Crank.tab);
        this.setHasSubtypes(true);
    }

    override fun getSubItems(tab: CreativeTabs, subItems: NonNullList<ItemStack>)
    {
        MoneyType.values().mapTo(subItems) { ItemStack(this, 1, it.meta) }
    }

    override fun getUnlocalizedName(stack: ItemStack?): String
    {
        return super.getUnlocalizedName() + "." + MoneyType.byMetadata(stack!!.metadata).getName()
    }
}

Code Tab:

class CustomTab: CreativeTabs("customtab")
{
    override fun getTabIconItem(): ItemStack
    {
        return ItemStack(Items.APPLE)
    }
}

I'm pretty sure we do Java here, not other Programming Languages

Edited January 24, 2018 by Differentiation

[Draco18s]

I think that's Kotlin, which can cross-compile to Java. Don't quote me on that though.

 

Anyway, the problem is here:

getSubItems(tab: CreativeTabs

ALL items have this method called for ALL tabs, which tab is the current one is passed in in this parameter. If you want to only have your item show up in one tab, you need to only return your item stack list when that tab is active.

[WildHeart]

16 minutes ago, Differentiation said:

I'm pretty sure we do Java here, not other Programming Languages

This is Kotlin.

[WildHeart]

8 minutes ago, Draco18s said:

I think that's Kotlin, which can cross-compile to Java. Don't quote me on that though.

 

Anyway, the problem is here:

getSubItems(tab: CreativeTabs

ALL items have this method called for ALL tabs, which tab is the current one is passed in in this parameter. If you want to only have your item show up in one tab, you need to only return your item stack list when that tab is active.

Thanks, it is working.