[1.12] Custom dispenser block not working as expected

[Willbl3pic]

So I have a custom block which extends BlockDispenser - it's supposed to place blocks in its inventory when given a redstone signal. I had it working before, in 1.11, but now it doesn't seem to work. Instead of placing the block, it just makes a click noise and the entire inventory empties.

 

I made some breakpoints and stepped through, and it appears that the problem is

TileEntityBlockPlacer.getDispenseSlot()

always returning -1. The cause of this seems to be that the

stacks

variable is always full of stacks of air.

 

As for why that is, I'm not sure... Does anyone have any ideas? I haven't found anything useful yet online, and I'm not really sure where to go from here. The stacks are in the blockplacer, and they persist between minecraft reboots, and yet the list of stacks is empty...

 

Block

IBehaviorDispenseItem

TileEntity

Edited February 13, 2018 by Willbl3pic

[Draco18s]

Your custom TE class does nothing at all remotely useful. It has its own inventory (separate and different than the base class's inventory!) but the overridden methods...do nothing with this new inventory.

 

Your block has several methods that are unused too:

getBehavior() - this method is protected and not referenced by your class

dispense() - this method is protected and not referenced by your class

dropBehavior - this field is private and only referenced by getBehavior() and dispense().

[Willbl3pic]

12 minutes ago, Draco18s said:

Your custom TE class does nothing at all remotely useful. It has its own inventory (separate and different than the base class's inventory!) but the overridden methods...do nothing with this new inventory.

 

Your block has several methods that are unused too:

getBehavior() - this method is protected and not referenced by your class

dispense() - this method is protected and not referenced by your class

dropBehavior - this field is private and only referenced by getBehavior() and dispense().

You're right about getBehavior and the various things in the tileentity - a lot of that was due to me blindly copying things from the dropper and dispenser, trying to fix the problem. I have now removed them.

 

However, dispense() is called. My breakpoint is always hit.

[Draco18s]

Is it an overridden method? That might be why.

If so, mark it with @Override

[Willbl3pic]

Whoops, I must have missed that, thanks. I'll annotate it, along with createNewTileEntity().

 

I've just tried removing all references to TileEntityBlockPlacer and replacing them with TileEntityDispenser. It works, but now, because the block uses a TileEntityDispenser, it shows 'Dispenser' at the top of the GUI rather than 'Block Placer'.

 

I'm not really sure why TileEntityDispenser works but TileEntityBlockPlacer doesn't, especially as TileEntityBlockPlacer extends it and is exactly the same, except getName(). Perhaps it could be to do with the fact that TileEntityDispenser.stacks is private rather than protected?

[Draco18s]

44 minutes ago, Willbl3pic said:

Perhaps it could be to do with the fact that TileEntityDispenser.stacks is private rather than protected?

Probably. Rather than trying to override that inventory, I would just use super calls in the necessary functions.

I haven't messed with custom dispensers since 1.7.10, but maybe that'll help.

You may also be interested in this.