Jump to content

[SOLVED] Custom Item Drops for Blocks for 1.12.2


34486

Recommended Posts

Forge 1.12.2

Hopefully I am asking in the correct place! How can I make my blocks in my mod drop specific items, or a list of items. I have googled this already, and found that nothing is 'working' I get no errors once I fix the things Eclipse Oxygen.2 tells me to do, and the game runs and starts with no error, but does not drop what I want when I break the block.. again with no error!  I am sorry that I have not been able to successfully google something that is clear for my stupid mind to comprehend, so I post here for help, I hope. 

 

How and where can I implement a custom block drop?  I'll post some images of my work space so you can tell me where I need to put what and how. I'll open some classes too, which I feel might need to have something changed. 

Screenshot 1.PNG

oreblocks.PNG

Blockbase.PNG

Normal Block reference for oreblock.PNG

IHasModel.PNG

modblocks.PNG

moditems.PNG

Registry Handler.PNG

Edited by 34486
Changed the title..

Gregtech FOR THE WIN! (I miss GT from 1.4)

Link to comment
Share on other sites

Override Block#getDrops.

 

Also, the IHasModel method of registering models makes no sense. Every Block and Item needs a model.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

8 minutes ago, larsgerrits said:

Override Block#getDrops.

 

Also, the IHasModel method of registering models makes no sense. Every Block and Item needs a model.

Eclipse suggested I add this into BlockBase class

public ArrayList<ItemStack> getDrops(World world, int x, int y, int z, int metadata, int fortune) {
        // TODO Auto-generated method stub
        return null;
    }

 

I put this in the OreBlock class

@Override
     public ArrayList<ItemStack> getDrops(World world, int x, int y, int z, int metadata, int fortune) {
     ArrayList<ItemStack> stack = super.getDrops(world, x, y, z, metadata, fortune);
     stack.add(new ItemStack(Items.APPLE, 2));
     return stack;
     }

 

I get NO errors when loading, running or exiting the client. It does not drop an APPLE, Which I am using for simplicity, and to drop 2 of them. 

 

Is this what you mean by Override Block#getDrops? I'm really dumb, sorry, trying to learn this for the 4th time, tried in 1.6, failed, 1.7, failed, .1.10, failed, trying 1.12.2

Gregtech FOR THE WIN! (I miss GT from 1.4)

Link to comment
Share on other sites

2 minutes ago, diesieben07 said:

What version are you coding in? In 1.12.x you should be using 


void getDrops(NonNullList<ItemStack> drops, IBlockAccess world, BlockPos pos, IBlockState state, int fortune)

1.12.2, Latest Forge Version. 

Gregtech FOR THE WIN! (I miss GT from 1.4)

Link to comment
Share on other sites

4 minutes ago, diesieben07 said:

That is impossible there is no ArrayList-returning getDrops in latest Forge.

Ok, In my OreBlocks source I added this

public void getDrops(NonNullList<ItemStack> drops, IBlockAccess world, BlockPos pos, IBlockState state, int fortune) {
        
        
        
    }

 

But what do I put inside the brackets, getDrops(); just gets crossed out with an error and drops.* has nothing useful. 

Gregtech FOR THE WIN! (I miss GT from 1.4)

Link to comment
Share on other sites

2 minutes ago, diesieben07 said:

You know how a List works in Java, yes? If not, you need to go learn basic Java.

Ok, I understand that the arraylist was used in 1.7 and not 1.12.2, I cannot find anything useful, and yes (I hope...) , for example you can take numbers, then print them out in the console, added or not. 

 

What exactly do I need to put where? Currently I am trying to find something similar to this in other peoples source, and right now am having no luck.

Gregtech FOR THE WIN! (I miss GT from 1.4)

Link to comment
Share on other sites

Ok, I just used this... I was unsure of the itemstacks, Like return Moditems.x wasn't working. 

 

public Item getItemDropped(IBlockState state, Random rand, int fortune) {
          return YourItemClassName.ItemYouWantToDrop;
         }
    
    public int quantityDropped(IBlockState state, int fortune, Random random) {
          return random.nextInt(2) + 1;               // <--- This will drop 1 to 2 items, and the +1 is so its not from 0 to 2. 
         }

 

Gregtech FOR THE WIN! (I miss GT from 1.4)

Link to comment
Share on other sites

  • 8 months later...
On 3/23/2018 at 7:25 PM, 34486 said:

Ok, I just used this... I was unsure of the itemstacks, Like return Moditems.x wasn't working. 

 

public Item getItemDropped(IBlockState state, Random rand, int fortune) {
          return YourItemClassName.ItemYouWantToDrop;
         }
    
    public int quantityDropped(IBlockState state, int fortune, Random random) {
          return random.nextInt(2) + 1;               // <--- This will drop 1 to 2 items, and the +1 is so its not from 0 to 2. 
         }

 

Man you're actually the best person ever. I'm super new to this yet your code is super understandable and made getting multiple drops form one piece of ore really easy. Thanks man. 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.