"Configurable" event priority - is this OK?

[CosmicDan 5]

Howdy,

 

Is this alright or is there a better way?

 

@SubscribeEvent(priority = EventPriority.LOWEST)
public void onSomeEventWithResultLate(SomeEventWithResult event) {
  if (ModConfig.COMPATIBILITY.runLatest) {
    // do stuff as late as possible so hopefully our result is the one that counts
  }
}

@SubscribeEvent(priority = EventPriority.HIGHEST)
public void onSomeEventWithResultEarly(SomeEventWithResult event) {
  if (!ModConfig.COMPATIBILITY.runLatest) {
    // do stuff as soon as possible to let other mod events override it if they want
  }
}

 

Obviously the idea is to let the user decide whether they want this aspect of a mod to be more important to less important than other mods.

 

I may also have logic in the LOWEST priority to react differently depending on an existing result, if any, but that's neither here nor there.

Edited April 1, 2018 by CosmicDan
Method names

[jabelar 593]

Yeah, I think that should work except that if other mods set their priority to highest then you you're not guaranteed to have yours go before theirs (I assume the order is based on mod loading or modID alphabetical) and if other mods set their priority to lowest then you're not guaranteed to have yours go after thiers. In fact, one or the other will not fully work because if you're first in order for the highest then you'll be first in order for the lowest, and vice versa. But at least you can say you tried. And it should work for mods where they leave the priority at default (normal).

Edited April 3, 2018 by jabelar