Jump to content

[1.12.2] Trying to make a entity produce an area of effect that damages and stuns all EntityMobs


NovaViper

Recommended Posts

I'm trying to create a talent for DoggyTalents that has the dog produce a roar that has a certain AoE (Area of Effect) range and causes all entities that are extended from EntityMob to be stunned and take damage depending on how much the level of the talent itself. So far I have something like this but there are a few issues with it however:

  1. It only effects one mob at a time, instead of all of them at once
  2. The section that is uncommented now doesn't cause damage but produces the particles

Main Developer and Owner of Zero Quest

Visit the Wiki for more information

If I helped anyone, please give me a applaud and a thank you!

Link to comment
Share on other sites

(read: move the contents of line 53 outside the loop)

  • Like 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

I blanked out the cooldown and it worked perfectly, but kept firing constantly. I did something like this but now it doesn't seem to run at all

 

				cooldown2 = level == 5 ? 20 : 50;
				
				if (dog.getEntityWorld().isRemote) {
					if (this.cooldown2 > 0) {
						this.cooldown2--;
						// System.out.println(this.cooldown2);
					}
				}
				List<EntityMob> list = dog.world.<EntityMob>getEntitiesWithinAABB(EntityMob.class, dog.getEntityBoundingBox().grow(level * 4, 4D, level * 4).expand(0.0D, (double)dog.world.getHeight(), 0.0D));
				//List list = dog.world.getEntitiesWithinAABB(EntityMob.class, dog.getEntityBoundingBox().grow(level * 3, 4D, level * 3));
	            //Iterator iterator = list.iterator();
	            if(!list.isEmpty()) {
	            	for(EntityMob mob : list) {
	            		if (cooldown2 == 0) {
							dog.playSound(SoundEvents.ENTITY_WOLF_GROWL, 1f, 1f);
							mob.spawnExplosionParticle();
							int knockback = (level == 5 ? 3 : 1);
							mob.attackEntityFrom(DamageSource.GENERIC, damage);
							//mob.addPotionEffect(MobEffects.SLOWNESS);
							//mob.addVelocity(-MathHelper.sin(mob.rotationYaw * (float) Math.PI / 180.0F) * knockback * 0.5F, 0.1D, MathHelper.cos(mob.rotationYaw * (float) Math.PI / 180.0F) * knockback * 0.5F);
						}
	            	}
	            }

 

Main Developer and Owner of Zero Quest

Visit the Wiki for more information

If I helped anyone, please give me a applaud and a thank you!

Link to comment
Share on other sites

You need to post the whole class code. Hard to tell what is going on with just a bit of it.

 

Is this your code? The general code is quite complex and shows a fairly high degree of coding ability, but your questions show very little understanding of how to code. So it seems that you've copied code from somewhere else and are trying to modify it a bit. It is okay if you are doing that, but we need to know because otherwise we don't know how to help you -- do you need quick tips or do you need detailed step-by-step help?

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Link to comment
Share on other sites

Just now, jabelar said:

You need to post the whole class code. Hard to tell what is going on with just a bit of it.

 

Is this your code? The general code is quite complex and shows a fairly high degree of coding ability, but your questions show very little understanding of how to code. So it seems that you've copied code from somewhere else and are trying to modify it a bit. It is okay if you are doing that, but we need to know because otherwise we don't know how to help you -- do you need quick tips or do you need detailed step-by-step help?

The original code came from another talent called Pest Fighter (No it's not mine basically). I've gotten a bit rusty when it comes to coding this year because of school taking away much of my free time to code in general. I did do a few more changes to the talent.

Main Developer and Owner of Zero Quest

Visit the Wiki for more information

If I helped anyone, please give me a applaud and a thank you!

Link to comment
Share on other sites

Okay, that makes sense. It is okay to modify other people's code but you need to understand what it is doing, so you should think carefully about how the logic works.

 

Your new edits are changing it the wrong way. Your original way was close, you checked for the cooldown okay before the problem was you were also setting it in the loop. All you needed to do was to move the cooldown setting line to the outside of the loop -- but after the loop not before it.

 

They way you're doing it now has lots of problems -- you're reducing the cooldown in a loop all within a single tick, and also attacking the same entity over and over again in that same tick. Please think through the logic very carefully. Remember this loop will be run through the whole loop in a single tick. So if you want something like a cooldown that works over multiple ticks you need to only reduce the cooldown by one each time the code executes. So the loop should be going through the list of entities like it was before, not going through all the possible cooldown values. 

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Link to comment
Share on other sites

1 hour ago, Draco18s said:

(read: move the contents of line 53 outside the loop)

 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Alright.. I must be really sleepy right now or I'm just that rusty... but I still can't get that cooldown working, but at least I got it where it runs once. https://hastebin.com/coqipakusi.swift

Edited by NovaViper

Main Developer and Owner of Zero Quest

Visit the Wiki for more information

If I helped anyone, please give me a applaud and a thank you!

Link to comment
Share on other sites

I'll try to break this down for you:
First off, this shouldn't be handled on the client, so:

if(dog.world.isRemote)
    return;

Secondly there are the conditions for the dog to have this ability, you can add them to the same if statement:
Since we reverse the conditions, we use "OR" instead of "AND", and we reverse each statement.

if(dog.world.isRemote || masterOrder != 4 || dog.getHealth() <= Constants.lowHealthLevel || dog.isChild() || level < 1)
    return;

 

Now, it's time to check the cooldown.

First we check if the cooldown is more than 0, meaning it's still on cooldown. If it is we will return. We then reduce it by one, so that it will eventually be 0.

if(cooldown > 0){
    cooldown--;
    return;
}
cooldown = level == 5 ? 5 : 20; //5 will happen 4 times in a second and 20 will happen once in a second - are these really the values, you want?

 

Then there's the damage, remember there was no reason to do this stuff, before you had even checked the cooldown:

byte damage = (byte) (level == 5 ? 10 : level);
//Or if 5 isn't the max level, maybe this is what you want:
byte damage = (byte) (level > 4 ? level+5 : level);


I don't know, if you know that operator (a ? b : c), but basically, it's like this:

byte damage;
if(level == 5)
    byte = (byte) 10;
else
    byte = level;

 

Now, it's time to do the action:

for(EntityMob mob : list) {//There's no reason to check if the list is empty, the for loop won't be entered, if there are no elements in it
	//I believe all of these will run on the client as well, if called on the server
    dog.playSound(SoundEvents.ENTITY_WOLF_GROWL, 1f, 1f);
    mob.spawnExplosionParticle();
    mob.attackEntityFrom(DamageSource.GENERIC, damage);
}

 

Then, that should work. I won't be posting the full code, as I want you to read all of it, and put it together yourself. It also might have some typos.

One thing I am concerned about, though is the cooldown simply being a variable. I would probably store it in NBT or dataManager.

You should also initialize the value.
 

Edited by Ruukas
  • Like 2
Link to comment
Share on other sites

3 hours ago, Ruukas said:

Then, that should work. I won't be posting the full code, as I want you to read all of it, and put it together yourself. It also might have some typos.

One thing I am concerned about, though is the cooldown simply being a variable. I would probably store it in NBT or dataManager.

You should also initialize the value.
 

I'm working on adding in NBT but. like I said, I'm a bit rusty with this. I'm not sure if I'm doing the NBT storing and retrieving correctly. https://hastebin.com/kicahibage.java

Edited by NovaViper
Just figured out the mob effects

Main Developer and Owner of Zero Quest

Visit the Wiki for more information

If I helped anyone, please give me a applaud and a thank you!

Link to comment
Share on other sites

On 4/2/2018 at 3:06 PM, Ruukas said:

Remove "int cooldown" and instead use a getCooldown() and setCooldown(), which reads or updates the NBT.

I can't get the methods to work since the talent class doesn't have, the IDE keeps saying the class is undefined in IDataWatcher type. https://hastebin.com/opomumuvoq.java

 

Nvm, I figured it out. I got it all working now. Thanks for the advice

Edited by NovaViper
Fixed the error

Main Developer and Owner of Zero Quest

Visit the Wiki for more information

If I helped anyone, please give me a applaud and a thank you!

Link to comment
Share on other sites

  • 7 months later...
On 4/2/2018 at 10:31 PM, Ruukas said:

that operator (a ? b : c)

The Tennerary operator

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
    • It is an issue with quark - update it to this build: https://www.curseforge.com/minecraft/mc-mods/quark/files/3642325
    • Remove Instant Massive Structures Mod from your server     Add new crash-reports with sites like https://paste.ee/  
    • Update your drivers: https://www.amd.com/en/support/graphics/amd-radeon-r9-series/amd-radeon-r9-200-series/amd-radeon-r9-280x
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.