Jump to content

Having trouble getting item textures to work


Xeraster

Recommended Posts

I'm having a lot of trouble getting item textures to work. I'm on McForge for 1.12.2. It's for a record, the kind that goes in a jukebox, to be exact. I am able to use console logging to see that my unlocalized name is "item.record.starrecord" and registry name is "supertnt:record.starrecord". The problem is that it shows the purple and black "untextured" texture instead of what I'm trying to display.

 

I thought it was a json problem at first but after trying a lot of stuff, it might be a code problem. It would be easier to narrow it down if I knew the correct json file arrangement for 1.12.2 for items but here is what I have right now:

record.starrecord.json located in supertnt/models/item

{
    "parent": "item/generated",
    "textures": {
        "layer0": "supertnt:items/record.starrecord"
    }
}

Here is the file located in supertnt/blockstates/record.starrecord.json. Note that I have tried it both with and without this file present and niether of them work.

{
	"forge_marker": 1,
	"defaults": {
		"model": "supertnt:item/record.starrecord"
	},
	"variants": {
		"normal": [ { } ],
		"inventory": [
			{
				"transform": "supertnt:item/record.starrecord"
			}
		]
	}
}

 

Here is my item initialization code:

 

Here is where I initialize the model resource location for my item

@SideOnly(Side.CLIENT)
	@SubscribeEvent
	public static void onRegisterModels(ModelRegistryEvent event) {	
		ModelLoader.setCustomModelResourceLocation(Items.STARRECORD, 0, new ModelResourceLocation("starrecord", "inventory"));
		System.out.println("record registry name is = " + Items.STARRECORD.getRegistryName());
		System.out.println("record unlocalized name is = " + Items.STARRECORD.getUnlocalizedName());
}

 

Here is where I set up the item:

@ObjectHolder(SuperTNTMod.MODID)
public class Items {
	
	public static final StarRecord STARRECORD = new StarRecord("starrecord", SoundHandler.ACROSSTHESTARS2);


	@Mod.EventBusSubscriber(modid = SuperTNTMod.MODID)
	public static class RegistrationHandler {
		public static final StarRecord STARRECORD = new StarRecord("starrecord", SoundHandler.ACROSSTHESTARS2);
		public static final Set<Item> ITEMS = new HashSet<>();

		/**
		 * Register this mod's {@link Item}s.
		 *
		 * @param event The event
		 */
		
		@SubscribeEvent
		public static void registerItems(final RegistryEvent.Register<Item> event) {


			final IForgeRegistry<Item> registry = event.getRegistry();
			final Item[] items = {STARRECORD};
			registry.registerAll(items);

		}
	}
	@SideOnly(Side.CLIENT)
	@SubscribeEvent
	public static void onRegisterModels(ModelRegistryEvent event) {
		ModelLoader.setCustomModelResourceLocation(STARRECORD, 0, new ModelResourceLocation("starrecord", "inventory"));
		System.out.println("record registry name is = " + STARRECORD.getRegistryName());
		System.out.println("record unlocalized name is = " + STARRECORD.getUnlocalizedName());
}
}

And then here is the class file for my item just in case:

ublic class StarRecord extends ItemRecord
{
    private static final Map<SoundEvent, ItemRecord> RECORDS = Maps.<SoundEvent, ItemRecord>newHashMap();
    private final SoundEvent sound;
    private final String displayName;

    public StarRecord(String p_i46742_1_, SoundEvent soundIn)
    {
    	super(p_i46742_1_, soundIn);
        this.displayName = "record." + p_i46742_1_;
        this.setRegistryName(displayName);
        this.setUnlocalizedName(displayName);
        this.sound = soundIn;
        this.maxStackSize = 1;
        this.setCreativeTab(CreativeTabs.MISC);
        RECORDS.put(this.sound, this);
    }

    /**
     * Called when a Block is right-clicked with this Item
     */
    public EnumActionResult onItemUse(EntityPlayer player, World worldIn, BlockPos pos, EnumHand hand, EnumFacing facing, float hitX, float hitY, float hitZ)
    {
        IBlockState iblockstate = worldIn.getBlockState(pos);

        if (iblockstate.getBlock() == Blocks.JUKEBOX && !((Boolean)iblockstate.getValue(BlockJukebox.HAS_RECORD)).booleanValue())
        {
            if (!worldIn.isRemote)
            {
                ItemStack itemstack = player.getHeldItem(hand);
                ((BlockJukebox)Blocks.JUKEBOX).insertRecord(worldIn, pos, iblockstate, itemstack);
                worldIn.playEvent((EntityPlayer)null, 1010, pos, Item.getIdFromItem(this));
                itemstack.shrink(1);
                player.addStat(StatList.RECORD_PLAYED);
            }

            return EnumActionResult.SUCCESS;
        }
        else
        {
            return EnumActionResult.PASS;
        }
    }

    /**
     * allows items to add custom lines of information to the mouseover description
     */
    @SideOnly(Side.CLIENT)
    public void addInformation(ItemStack stack, @Nullable World worldIn, List<String> tooltip, ITooltipFlag flagIn)
    {
        tooltip.add(this.getRecordNameLocal());
    }

    @SideOnly(Side.CLIENT)
    public String getRecordNameLocal()
    {
        return I18n.translateToLocal(this.displayName);
    }

    /**
     * Return an item rarity from EnumRarity
     */
    public EnumRarity getRarity(ItemStack stack)
    {
        return EnumRarity.RARE;
    }

    @Nullable
    @SideOnly(Side.CLIENT)
    public static ItemRecord getBySound(SoundEvent soundIn)
    {
        return RECORDS.get(soundIn);
    }

    @SideOnly(Side.CLIENT)
    public SoundEvent getSound()
    {
        return this.sound;
    }
}

If someone can find the problem and point it out and how to fix it, I would greatly appreciate the help.

Thanks in advance.

Link to comment
Share on other sites

Haven't made items in a while but I think your issue is you should be using "supertnt:starrecord" rather than just "starrecord", if I'm wrong someone else please correct me.

Edit: I recommend using hardcoded values as little as possible getRegistryName() is preferable.

Edit 2: I can't test at the moment but the tip from my first edit may require use of the @ObjectHolder annotation

Edited by DaemonUmbra

This is my Forum Signature, I am currently attempting to transform it into a small guide for fixing easier issues using spoiler blocks to keep things tidy.

 

As the most common issue I feel I should put this outside the main bulk:

The only official source for Forge is https://files.minecraftforge.net, and the only site I trust for getting mods is CurseForge.

If you use any site other than these, please take a look at the StopModReposts project and install their browser extension, I would also advise running a virus scan.

 

For players asking for assistance with Forge please expand the spoiler below and read the appropriate section(s) in its/their entirety.

Spoiler

Logs (Most issues require logs to diagnose):

Spoiler

Please post logs using one of the following sites (Thank you Lumber Wizard for the list):

https://gist.github.com/100MB Requires member (Free)

https://pastebin.com/: 512KB as guest, 10MB as Pro ($$$)

https://hastebin.com/: 400KB

Do NOT use sites like Mediafire, Dropbox, OneDrive, Google Drive, or a site that has a countdown before offering downloads.

 

What to provide:

...for Crashes and Runtime issues:

Minecraft 1.14.4 and newer:

Post debug.log

Older versions:

Please update...

 

...for Installer Issues:

Post your installer log, found in the same place you ran the installer

This log will be called either installer.log or named the same as the installer but with .log on the end

Note for Windows users:

Windows hides file extensions by default so the installer may appear without the .jar extension then when the .log is added the log will appear with the .jar extension

 

Where to get it:

Mojang Launcher: When using the Mojang launcher debug.log is found in .minecraft\logs.

 

Curse/Overwolf: If you are using the Curse Launcher, their configurations break Forge's log settings, fortunately there is an easier workaround than I originally thought, this works even with Curse's installation of the Minecraft launcher as long as it is not launched THROUGH Twitch:

Spoiler
  1. Make sure you have the correct version of Forge installed (some packs are heavily dependent on one specific build of Forge)
  2. Make a launcher profile targeting this version of Forge.
  3. Set the launcher profile's GameDir property to the pack's instance folder (not the instances folder, the folder that has the pack's name on it).
  4. Now launch the pack through that profile and follow the "Mojang Launcher" instructions above.

Video:

Spoiler

 

 

 

or alternately, 

 

Fallback ("No logs are generated"):

If you don't see logs generated in the usual place, provide the launcher_log.txt from .minecraft

 

Server Not Starting:

Spoiler

If your server does not start or a command window appears and immediately goes away, run the jar manually and provide the output.

 

Reporting Illegal/Inappropriate Adfocus Ads:

Spoiler

Get a screenshot of the URL bar or copy/paste the whole URL into a thread on the General Discussion board with a description of the Ad.

Lex will need the Ad ID contained in that URL to report it to Adfocus' support team.

 

Posting your mod as a GitHub Repo:

Spoiler

When you have an issue with your mod the most helpful thing you can do when asking for help is to provide your code to those helping you. The most convenient way to do this is via GitHub or another source control hub.

When setting up a GitHub Repo it might seem easy to just upload everything, however this method has the potential for mistakes that could lead to trouble later on, it is recommended to use a Git client or to get comfortable with the Git command line. The following instructions will use the Git Command Line and as such they assume you already have it installed and that you have created a repository.

 

  1. Open a command prompt (CMD, Powershell, Terminal, etc).
  2. Navigate to the folder you extracted Forge’s MDK to (the one that had all the licenses in).
  3. Run the following commands:
    1. git init
    2. git remote add origin [Your Repository's URL]
      • In the case of GitHub it should look like: https://GitHub.com/[Your Username]/[Repo Name].git
    3. git fetch
    4. git checkout --track origin/master
    5. git stage *
    6. git commit -m "[Your commit message]"
    7. git push
  4. Navigate to GitHub and you should now see most of the files.
    • note that it is intentional that some are not synced with GitHub and this is done with the (hidden) .gitignore file that Forge’s MDK has provided (hence the strictness on which folder git init is run from)
  5. Now you can share your GitHub link with those who you are asking for help.

[Workaround line, please ignore]

 

Link to comment
Share on other sites

@SideOnly(Side.CLIENT)
	@SubscribeEvent
	public static void onRegisterModels(ModelRegistryEvent event) {	
		ModelLoader.setCustomModelResourceLocation(Items.STARRECORD, 0, new ModelResourceLocation("starrecord", "inventory"));
		System.out.println("record registry name is = " + Items.STARRECORD.getRegistryName());
		System.out.println("record unlocalized name is = " + Items.STARRECORD.getUnlocalizedName());
}

This needs to be new ModelResourceLocation("record.starrecord", "inventory").

Edited by hiotewdew
Link to comment
Share on other sites

Also, I would heavily suggest embedding an InitModel function within your block classes.

@SideOnly(Side.CLIENT)
	public void initModel() {
		ModelLoader.setCustomModelResourceLocation(Item.getItemFromBlock(this), 0, new ModelResourceLocation(getRegistryName(), "inventory"));
	}

That way when you run onRegsiterModels, you can just call

Items.STARRECORD.initModel();

 

 

Also, blockstates aren't used for items! Only models are nessecary. Don't worry about a blockstate json.

Link to comment
Share on other sites

On 4/4/2018 at 12:04 AM, DaemonUmbra said:

Haven't made items in a while but I think your issue is you should be using "supertnt:starrecord" rather than just "starrecord", if I'm wrong someone else please correct me.

Edit: I recommend using hardcoded values as little as possible getRegistryName() is preferable.

Edit 2: I can't test at the moment but the tip from my first edit may require use of the @ObjectHolder annotation

You are right. It was a typo and I needed to change my item registration to:

ModelLoader.setCustomModelResourceLocation(STARWARSRECORD, 0, new ModelResourceLocation("supertnt:record.starrecord", "inventory"));

rather than

ModelLoader.setCustomModelResourceLocation(STARWARSRECORD, 0, new ModelResourceLocation("record.starrecord", "inventory"));

 

And thanks for pointing out the stuff about @SideOnly and @SidedProxy. I'll look into changing that when I get a chance to.

Edited by Xeraster
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.