Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

If Statement Getting Ignored


tuunaa
 Share

Recommended Posts

https://pastebin.com/cbq10K42

Here's my class.

 

The issue I'm having is that the if statement 

if (neighborPos != oppPos || neighborPos != facingPos)

in the posCompare method seems to be getting ignored.  Here's an example of what the output would be for the System.out.printlns you see in the posCompare method if I was facing north:

Spoiler

[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=198, y=66, z=206}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=197, y=66, z=205}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=198, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=199, y=66, z=205}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=198, y=66, z=205}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=203}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=197, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=203}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=198, y=66, z=203}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=203}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=199, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=203}

As you can see, if the if statement in posCompare was followed correctly, the blocks at neighbor positions

Spoiler

[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=198, y=66, z=203}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=203}

and

Spoiler

[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=198, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=204}

shouldn't be broken, but when I right click a crop in game it still does.

 

I also have another issue, being the beetroots won't break properly with this code.  This is because when I right click them, even though I'm using

((BlockCrops)block).getMaxAge())

it still wants to check for a max age of 7.  I've tried checking for whether it's trying to destroy beetroots specifically and using 3 instead of getting the max age but it still wants to check for 7.  Here's the error log:

Spoiler

[13:07:12] [Server thread/FATAL]: Error executing task
java.util.concurrent.ExecutionException: java.lang.IllegalArgumentException: Cannot get property PropertyInteger{name=age, clazz=class java.lang.Integer, values=[0, 1, 2, 3, 4, 5, 6, 7]} as it does not exist in BlockStateContainer{block=minecraft:beetroots, properties=[age]}
    at java.util.concurrent.FutureTask.report(Unknown Source) ~[?:1.8.0_171]
    at java.util.concurrent.FutureTask.get(Unknown Source) ~[?:1.8.0_171]
    at net.minecraft.util.Util.runTask(Util.java:54) [Util.class:?]
    at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:795) [MinecraftServer.class:?]
    at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:740) [MinecraftServer.class:?]
    at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:192) [IntegratedServer.class:?]
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:589) [MinecraftServer.class:?]
    at java.lang.Thread.run(Unknown Source) [?:1.8.0_171]
Caused by: java.lang.IllegalArgumentException: Cannot get property PropertyInteger{name=age, clazz=class java.lang.Integer, values=[0, 1, 2, 3, 4, 5, 6, 7]} as it does not exist in BlockStateContainer{block=minecraft:beetroots, properties=[age]}
    at net.minecraft.block.state.BlockStateContainer$StateImplementation.getValue(BlockStateContainer.java:204) ~[BlockStateContainer$StateImplementation.class:?]
    at tuunaa.stardew.items.ItemScythe.posCompare(ItemScythe.java:52) ~[ItemScythe.class:?]
    at tuunaa.stardew.items.ItemScythe.onItemUse(ItemScythe.java:72) ~[ItemScythe.class:?]
    at net.minecraftforge.common.ForgeHooks.onPlaceItemIntoWorld(ForgeHooks.java:836) ~[ForgeHooks.class:?]
    at net.minecraft.item.ItemStack.onItemUse(ItemStack.java:200) ~[ItemStack.class:?]
    at net.minecraft.server.management.PlayerInteractionManager.processRightClickBlock(PlayerInteractionManager.java:504) ~[PlayerInteractionManager.class:?]
    at net.minecraft.network.NetHandlerPlayServer.processTryUseItemOnBlock(NetHandlerPlayServer.java:757) ~[NetHandlerPlayServer.class:?]
    at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.processPacket(CPacketPlayerTryUseItemOnBlock.java:68) ~[CPacketPlayerTryUseItemOnBlock.class:?]
    at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.processPacket(CPacketPlayerTryUseItemOnBlock.java:13) ~[CPacketPlayerTryUseItemOnBlock.class:?]
    at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:21) ~[PacketThreadUtil$1.class:?]
    at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) ~[?:1.8.0_171]
    at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:1.8.0_171]
    at net.minecraft.util.Util.runTask(Util.java:53) ~[Util.class:?]
    ... 5 more

 

Edited by tuunaa
Link to comment
Share on other sites

  • 2 weeks later...
On 07/05/2018 at 6:11 AM, tuunaa said:

https://pastebin.com/cbq10K42

Here's my class.

 

The issue I'm having is that the if statement 


if (neighborPos != oppPos || neighborPos != facingPos)

in the posCompare method seems to be getting ignored.  Here's an example of what the output would be for the System.out.printlns you see in the posCompare method if I was facing north:

  Reveal hidden contents

[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=198, y=66, z=206}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=197, y=66, z=205}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=198, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=199, y=66, z=205}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=198, y=66, z=205}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=203}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=197, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=203}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=198, y=66, z=203}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=203}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=199, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=203}

As you can see, if the if statement in posCompare was followed correctly, the blocks at neighbor positions

  Reveal hidden contents

[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=198, y=66, z=203}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=203}

and

  Reveal hidden contents

[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:46]: opposite direction north
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:47]: neighborPos BlockPos{x=198, y=66, z=204}
[12:35:13] [Server thread/INFO] [STDOUT]: [tuunaa.stardew.items.ItemScythe:posCompare:48]: oppPos BlockPos{x=198, y=66, z=204}

shouldn't be broken, but when I right click a crop in game it still does.

 

I also have another issue, being the beetroots won't break properly with this code.  This is because when I right click them, even though I'm using


((BlockCrops)block).getMaxAge())

it still wants to check for a max age of 7.  I've tried checking for whether it's trying to destroy beetroots specifically and using 3 instead of getting the max age but it still wants to check for 7.  Here's the error log:

  Reveal hidden contents

[13:07:12] [Server thread/FATAL]: Error executing task
java.util.concurrent.ExecutionException: java.lang.IllegalArgumentException: Cannot get property PropertyInteger{name=age, clazz=class java.lang.Integer, values=[0, 1, 2, 3, 4, 5, 6, 7]} as it does not exist in BlockStateContainer{block=minecraft:beetroots, properties=[age]}
    at java.util.concurrent.FutureTask.report(Unknown Source) ~[?:1.8.0_171]
    at java.util.concurrent.FutureTask.get(Unknown Source) ~[?:1.8.0_171]
    at net.minecraft.util.Util.runTask(Util.java:54) [Util.class:?]
    at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:795) [MinecraftServer.class:?]
    at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:740) [MinecraftServer.class:?]
    at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:192) [IntegratedServer.class:?]
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:589) [MinecraftServer.class:?]
    at java.lang.Thread.run(Unknown Source) [?:1.8.0_171]
Caused by: java.lang.IllegalArgumentException: Cannot get property PropertyInteger{name=age, clazz=class java.lang.Integer, values=[0, 1, 2, 3, 4, 5, 6, 7]} as it does not exist in BlockStateContainer{block=minecraft:beetroots, properties=[age]}
    at net.minecraft.block.state.BlockStateContainer$StateImplementation.getValue(BlockStateContainer.java:204) ~[BlockStateContainer$StateImplementation.class:?]
    at tuunaa.stardew.items.ItemScythe.posCompare(ItemScythe.java:52) ~[ItemScythe.class:?]
    at tuunaa.stardew.items.ItemScythe.onItemUse(ItemScythe.java:72) ~[ItemScythe.class:?]
    at net.minecraftforge.common.ForgeHooks.onPlaceItemIntoWorld(ForgeHooks.java:836) ~[ForgeHooks.class:?]
    at net.minecraft.item.ItemStack.onItemUse(ItemStack.java:200) ~[ItemStack.class:?]
    at net.minecraft.server.management.PlayerInteractionManager.processRightClickBlock(PlayerInteractionManager.java:504) ~[PlayerInteractionManager.class:?]
    at net.minecraft.network.NetHandlerPlayServer.processTryUseItemOnBlock(NetHandlerPlayServer.java:757) ~[NetHandlerPlayServer.class:?]
    at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.processPacket(CPacketPlayerTryUseItemOnBlock.java:68) ~[CPacketPlayerTryUseItemOnBlock.class:?]
    at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.processPacket(CPacketPlayerTryUseItemOnBlock.java:13) ~[CPacketPlayerTryUseItemOnBlock.class:?]
    at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:21) ~[PacketThreadUtil$1.class:?]
    at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) ~[?:1.8.0_171]
    at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:1.8.0_171]
    at net.minecraft.util.Util.runTask(Util.java:53) ~[Util.class:?]
    ... 5 more

 

== and != perform INSTANCE comparisons, use someobject.equals(otherobject) instead

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Guest
This topic is now closed to further replies.
 Share



×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.