Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

Making an item


Big_Bad_E
 Share

Recommended Posts

Yes this is probably asked a ton.

I always forget how to do the whole item creation 1.12 system.

My item isn't appearing, and the lang file doesn't seem to work at all.

I made a tab though!

 

I think I've messed up in the asset path, and somewhere with making the item. 

 

Lang path:

src/main/resources/assets/cfd/lang

Item image path:

src/main/resources/assets/cfd/textures/items/testitem.png

Item class:

public class TestItem extends Item {
	public TestItem() {
		setRegistryName("testitem");
		setUnlocalizedName("testitem");
		setCreativeTab(CookingForDummies.cfdTab);
	}
	
}

Registry:

public class Registery {
	
	private static TestItem testItem = new TestItem();
	
	@SubscribeEvent
	public void registerItems(RegistryEvent.Register<Item> event) {
		event.getRegistry().register(testItem);
	}
}

Common Proxy:

public class CommonProxy {
	public void preInit(FMLPreInitializationEvent event) {
		MinecraftForge.EVENT_BUS.register(new Registery());
	}
	
	public void init(FMLInitializationEvent event) {
		
	}
	
	public void postInit(FMLPostInitializationEvent event) {
		
	}
}

Main Class:

@Mod(modid = "cfb", name = "Cooking For Blockheads", version = "v1.0.0")
public class CookingForDummies {
	@SidedProxy(clientSide="com.bigbade.cookingfordummies.proxies.ClientProxy", serverSide="com.bigbade.cookingfordummies.proxies.ServerProxy")
	public static CommonProxy proxy;
	public static CreativeTabs cfdTab = new CFDTab(CreativeTabs.getNextID(),"Cooking For Dummies");
	public void preInit(FMLPreInitializationEvent event) {
		proxy.preInit(event);
	}
	
	public void init(FMLInitializationEvent event) {
		proxy.init(event);
	}

	public void postInit(FMLPostInitializationEvent event) {
		proxy.postInit(event);
	}
}

 

Yes I know there is something with JSON files for textures and stuff but i'm not gonna work on that until the item is in the creative tab.

Link to comment
Share on other sites

5 hours ago, Big_Bad_E said:

public class Registery {

You can tag this class as @Mod.EventBusSubscriber and not worry about calling the event bus registry in your proxy

 

5 hours ago, Big_Bad_E said:

@SubscribeEvent public void registerItems(RegistryEvent.Register<Item> event) {

But this has to be static for that to happen

 

5 hours ago, Big_Bad_E said:

@Mod(modid = "cfb", name = "Cooking For Blockheads", version = "v1.0.0")

But, what's going on here? You do know 'Cooking for Dummies' is close, but using 'Cooking For Blockheads' is literally just using the name of another mod?

Developing the Spiral Power Mod .

こんにちは!お元気ですか?

Link to comment
Share on other sites

The first thing to do is confirm that all your code is being executed. Like add console print statements (or use breakpoints and debug mode if you prefer) at each of the methods and key points in the code, and you can also print off key values. For example, you should confirm that the registry event is actually firing.

 

Some things like whether the proxy classes are in the right asset location are hard to tell from a forum posting, but again tracing the code execution might help you identify the problem.

 

I would probably try to put the item on a vanilla tab before trying it on your custom tab, just to make things even simpler.

 

Also, I imagine your console is already spewing some errors related to the missing models, but perhaps there are other relevant errors being printed. You should go through the whole thing carefully.

 

 

Edited by jabelar

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Link to comment
Share on other sites

10 hours ago, Rohzek said:

You can tag this class as @Mod.EventBusSubscriber and not worry about calling the event bus registry in your proxy

 

But this has to be static for that to happen

 

But, what's going on here? You do know 'Cooking for Dummies' is close, but using 'Cooking For Blockheads' is literally just using the name of another mod?

I know Cooking for Blockheads mod, I accidentally keep on typing CFB or Cooking For Blockheads idk why, and Cooking For Dummies is just a placeholder name for now :P I'm not that creative, will hopefully think of something decent later.

 

I made the registry method static, I didn't see that in the documentation and was being dumb.

 

10 hours ago, jabelar said:

The first thing to do is confirm that all your code is being executed. Like add console print statements (or use breakpoints and debug mode if you prefer) at each of the methods and key points in the code, and you can also print off key values. For example, you should confirm that the registry event is actually firing.

 

Some things like whether the proxy classes are in the right asset location are hard to tell from a forum posting, but again tracing the code execution might help you identify the problem.

 

I would probably try to put the item on a vanilla tab before trying it on your custom tab, just to make things even simpler.

 

Also, I imagine your console is already spewing some errors related to the missing models, but perhaps there are other relevant errors being printed. You should go through the whole thing carefully.

 

 

Nope, I should of said no errors, but the problem is still going on, error debugging right now, will be debugging.

 

I will be working on this myself, but if anyone has an idea why my code isn't working please reply. 

 

Yeah the registry event isn't running, even with the EventBusSubscriber tag.

Edited by Big_Bad_E
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • These are my particle effect classes, they are all copied from a tutorial.   public class Juan1ParticalType extends ParticleType { public Juan1ParticalType() { super(false, Juan1ParticalData.DESERIALIZER); } @Override public Codec<Juan1ParticalData> func_230522_e_() { return Codec.unit(new Juan1ParticalData(new Vector3d(0, 0, 0), new Color(0xF63900), 0)); } }   public class Juan1ParticalData implements IParticleData { private final Vector3d speed; private final Color color; private final float diameter; public static final IDeserializer<Juan1ParticalData> DESERIALIZER = new IDeserializer<Juan1ParticalData>() { @Override public Juan1ParticalData deserialize(ParticleType<Juan1ParticalData> particleTypeIn, StringReader reader) throws CommandSyntaxException { final int MIN_COLOUR = 0; final int MAX_COLOUR = 255;reader.expect(' '); double speedX = reader.readDouble(); reader.expect(' '); double speedY = reader.readDouble(); reader.expect(' '); double speedZ = reader.readDouble(); reader.expect(' '); int red = MathHelper.clamp(reader.readInt(), MIN_COLOUR, MAX_COLOUR); reader.expect(' '); int green = MathHelper.clamp(reader.readInt(), MIN_COLOUR, MAX_COLOUR); reader.expect(' '); int blue = MathHelper.clamp(reader.readInt(), MIN_COLOUR, MAX_COLOUR);reader.expect(' ');  int alpha = MathHelper.clamp(reader.readInt(), 1, MAX_COLOUR);reader.expect(' '); float diameter = reader.readFloat();  return new Juan1ParticalData(new Vector3d(speedX, speedY, speedZ), new Color(red, green, blue, alpha), diameter); } @Override public Juan1ParticalData read(ParticleType<Juan1ParticalData> particleTypeIn, PacketBuffer buffer) { final int MIN_COLOUR = 0; final int MAX_COLOUR = 255; double speedX = buffer.readDouble(); double speedY = buffer.readDouble(); double speedZ = buffer.readDouble(); int red = MathHelper.clamp(buffer.readInt(), MIN_COLOUR, MAX_COLOUR); int green = MathHelper.clamp(buffer.readInt(), MIN_COLOUR, MAX_COLOUR); int blue = MathHelper.clamp(buffer.readInt(), MIN_COLOUR, MAX_COLOUR); int alpha = MathHelper.clamp(buffer.readInt(), 1, MAX_COLOUR); float diameter = buffer.readFloat(); return new Juan1ParticalData(new Vector3d(speedX, speedY, speedZ), new Color(red, green, blue, alpha), diameter); } }; public Juan1ParticalData(Vector3d speed, Color color, float diameter) { this.speed = speed; this.color = color; this.diameter = diameter; } @Override public ParticleType<?> getType() { return Utils.ParticleRegistry.JUAN_1_PARTICLE.get(); } @Override public void write(PacketBuffer buffer) { buffer.writeDouble(this.speed.x); buffer.writeDouble(this.speed.y); buffer.writeDouble(this.speed.z); buffer.writeInt(this.color.getRed()); buffer.writeInt(this.color.getGreen()); buffer.writeInt(this.color.getBlue()); buffer.writeInt(this.color.getAlpha()); buffer.writeFloat(this.diameter); } @Override public String getParameters() { return String.format(Locale.ROOT, "%s %.2f %i %i %i %i %.2d %.2d %.2d", this.getType().getRegistryName(), diameter, color.getRed(), color.getGreen(), color.getBlue(), color.getAlpha(), speed.getX(), speed.getY(), speed.getZ()); } public Vector3d getSpeed() { return speed; } public Color getColor() { return color; } public float getDiameter() { return diameter; } }   public class Juan1Particle extends SpriteTexturedParticle { public Juan1Particle(ClientWorld world, double x, double y, double z, Vector3d speed, Color color, float diameter) { super(world, x, y, z, speed.x, speed.y, speed.z); maxAge = 100; setColor(color.getRed() / 255F,color.getGreen() / 255F,color.getBlue() / 255); this.setAlphaF(color.getAlpha()); final float PARTICLE_SCALE_FOR_ONE_METER = 0.1F; particleScale = PARTICLE_SCALE_FOR_ONE_METER * diameter; this.canCollide = true; } @Override public IParticleRenderType getRenderType(){ return IParticleRenderType.PARTICLE_SHEET_TRANSLUCENT; } }   public class Juan1ParticleFactory implements IParticleFactory<Juan1ParticalData> { private final IAnimatedSprite sprites; public Juan1ParticleFactory(IAnimatedSprite sprite) { this.sprites = sprite; } @Override public Particle makeParticle(Juan1ParticalData typeIn, ClientWorld worldIn, double x, double y, double z, double xSpeed, double ySpeed, double zSpeed) { Juan1Particle particle = new Juan1Particle(worldIn, x, y, z, typeIn.getSpeed(), typeIn.getColor(), typeIn.getDiameter()); particle.selectSpriteWithAge(sprites); return particle; } }
    • This is where I want to call the addParticle() method, it is in the livingTick() in an entity. But it shows no particle effect. @Override public void livingTick() { double x = rand.nextGaussian() * 0.02D; double y = rand.nextGaussian() * 0.02D; double z = rand.nextGaussian() * 0.02D; double px = this.getPosX() + 4.0D * rand.nextDouble() - 2.0D; double py = this.getPosY() + rand.nextDouble() - 0.5D; double pz = this.getPosZ() + 4.0D * rand.nextDouble() - 2.0D; world.addParticle(new Juan1ParticalData(new Vector3d(x, y, z), new Color(0xae6be2), 0), px, py, pz, x, y, z);  } When I change "new Juan1ParticalData(new Vector3d(x, y, z), new Color(0xae6be2), 0)" to "ParticleTypes.DRAGON_BREATH" , the particle effects appeared.
    • can you get any useful info from your crash reports?
    • I made a particle effect of my own, and I can only display the particle effect in the game through the command : /particle mymod:juan1particle 0 0 0 0 0 255 100 3.   When I want add the particle through World.addParticle(IParticleData particleData, double x, double y, double z, double xSpeed, double ySpeed, double zSpeed), it does not show at all.   But when I change the particleData Parameter from my particledata's instance to those in the ParticleTypes in the vanilla, It works without problem. So it seems that only my particle effect can't be added into the game, but those in the vanilla can be added.
    • Ok, so, that's really helpful. I guess i need to learn how to make a custom sound instance for my sound.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.