Jump to content

[Solved] [1.12.2] Generating blocks on soul sand in the nether


robmart

Recommended Posts

I need to generate my block (a flower) on soul sand in the nether. The actual generation I have no problem with. What I need help with is actually doing it *on* the soul sand.

This is my current code:

 

@SubscribeEvent(priority = EventPriority.LOWEST)
    public static void onWorldDecoration(DecorateBiomeEvent.Decorate event){
        if((event.getResult() == Event.Result.ALLOW || event.getResult() == Event.Result.DEFAULT)  && event.getType() == DecorateBiomeEvent.Decorate.EventType.SHROOM) {
            if (event.getWorld().provider.isNether()){
                int dist = Math.min(8, Math.max(1, 4));
                for(int i = 0; i < 1; i++) {
                    if(event.getRand().nextInt(8) == 0) {
                        int x = event.getPos().getX() + event.getRand().nextInt(16) + 8;
                        int z = event.getPos().getZ() + event.getRand().nextInt(16) + 8;
                        int y = event.getWorld().getTopSolidOrLiquidBlock(event.getPos()).getY();

                        for (int j = 0; j < 1 * 8; j++) {
                            int x1 = x + event.getRand().nextInt(dist * 2) - dist;
                            int y1 = y + event.getRand().nextInt(4) - event.getRand().nextInt(4);
                            int z1 = z + event.getRand().nextInt(dist * 2) - dist;
                            BlockPos pos2 = new BlockPos(x1, y1, z1);
                            if (event.getWorld().isAirBlock(pos2) && InitBlocks.HELL_FLOWER.canPlaceBlockAt(event.getWorld(), pos2)) {
                                event.getWorld().setBlockState(pos2, InitBlocks.HELL_FLOWER.getDefaultState());
                                System.out.println("Placed flower " + pos2);
                            }
                        }
                    }
                }
            }
        }
    }

I obviously cannot use EventType.FLOWERS since that doesn't trigger in the nether, and I can't keep using EventType.SHROOM either since that doesn't accomplish what I want.

Oh and I need a replacement for getWorld().getTopSolidOrLiquidBlock since that'll give me the bedrock.

 

Any help?

Edited by robmart
Link to comment
Share on other sites

52 minutes ago, robmart said:

Oh and I need a replacement for getWorld().getTopSolidOrLiquidBlock since that'll give me the bedrock.

Write a method that starts one block below the bedrock and checks blocks going down.

 

On the other hand, what you could do is iterate through the BiomeDictionary with the type NETHER as the category. Then replace the BiomeDecorator with a wrapper over the current one and add your flower generation there similarly if not exactly how you do so for a biome normally.

  • Thanks 1

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

6 minutes ago, Animefan8888 said:

Write a method that starts one block below the bedrock and checks blocks going down.

 

On the other hand, what you could do is iterate through the BiomeDictionary with the type NETHER as the category. Then replace the BiomeDecorator with a wrapper over the current one and add your flower generation there similarly if not exactly how you do so for a biome normally.

I pretty sure I understand, but where would I do the iterating and replacing? In the event?

Link to comment
Share on other sites

Just now, robmart said:

I pretty sure I understand, but where would I do the iterating and replacing? In the event?

I would say in any of the init events.

  • Thanks 1

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

Just now, robmart said:

Would me replacing the decorator on all biomes with the type nether not potentially fuck up other mods' generation though?

That is why I said put it in with a wrapper. A wrapper is a class that inherits a type and takes an instance of that type in through its constructor. This way you can call all the methods and hopefully not cause any other errors with mods.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

Just now, Animefan8888 said:

That is why I said put it in with a wrapper. A wrapper is a class that inherits a type and takes an instance of that type in through its constructor. This way you can call all the methods and hopefully not cause any other errors with mods.

Yup I just somehow missed that. Thanks for the help!

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.