[1.12.2] Give Player an Item

[vin0m 0]

I am trying to give an item to a player and for some reason this code that was working in 1.10.2 will not work in 1.12.2.  I can't figure out what I need to do differently.  Code:

 

ItemStack stack = new ItemStack(ModItems.goldSatchel);
Item item = stack.getItem();
int newItemValue = maxItemDamage - value;
item.setDamage(stack, newItemValue);
player.inventory.addItemStackToInventory(stack);

 

The new item is not placed in the players inventory.  Did something change in 1.12?

[cubicoder 2]

Where are you running this code?

[aw_wolfe 14]

you can set the damage directly to the stack

 

stack.setItemDamage();

 

Are you getting an item in inventory, or just not a damaged item?

[vin0m 0]

4 minutes ago, cubicoder said:

Where are you running this code?

I am running it in my class "CommandGoldCoins implements ICommand {" in the section "public void execute(MinecraftServer server, ICommandSender sender, String[] input) throws CommandException".

 

5 minutes ago, aw_wolfe said:

you can set the damage directly to the stack

 

stack.setItemDamage();

 

Are you getting an item in inventory, or just not a damaged item?

A part of this command modifies the current item damage.  That works fine. It is also supposed to make a new item (code above) with a set damage amount.  The new item does not appear in the inventory.  It worked fine in 1.10.2 so I'm confused on what has changed.

[cubicoder 2]

Looking at the code for the /give command, it looks like you have to have the player drop the item stack using player.dropItem(itemstack, false). Then make the resulting EntityItem have no pickup delay and set the owner to the player (entityitem.setNoPickupDelay() and entityitem.setOwner(entityplayer.getName()), respectively). I've never messed with commands before, though, so I may be wrong.

Edited July 10, 2018 by cubicoder

[vin0m 0]

Apparently you can only set the item damage up to 4 digits.  Anything over that and it fails to create the item.  That was the issue.  

[Animefan8888 741]

22 hours ago, vin0m said:

Apparently you can only set the item damage up to 4 digits.  Anything over that and it fails to create the item.  That was the issue.  

ItemStack#itemDamage is truncated to a short value aka the max is 32767(thank you Draco18s). ItemStacks are considered empty if their itemDamage is greater than 65535 or less than -32767.

Edited July 11, 2018 by Animefan8888
Error

[diesieben07 7582]

8 hours ago, vin0m said:

CommandGoldCoins implements ICommand

Do not implement ICommand directly. I have never seen anyone doing that do it correctly. Extend CommandBase instead (and make sure to only implement the necessary methods).

[Draco18s 2401]

12 hours ago, Animefan8888 said:

ItemStack#itemDamage is truncated to a short value aka the max is 65535.

*cough*

32766.

32767 is the Wildcard Value ("match any").