Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.12.2] Two questions about modding


H_SerhatY
 Share

Recommended Posts

3 hours ago, H_SerhatY said:

First one is for 1.11.2 and second one is not for 1.12.2

The first one should still be the same, however for creating crafting recipes that already have enchantments you should create a custom implementation of IRecipeFactory and handle the json data accordingly.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

14 hours ago, Animefan8888 said:

The first one should still be the same, however for creating crafting recipes that already have enchantments you should create a custom implementation of IRecipeFactory and handle the json data accordingly.

@H_SerhatY here’s a solution

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Just now, H_SerhatY said:

Good idea. If you are know what are you making. You can understand me?

I don’t think so, I’ve never done anything with stuff like this. I think someone said you should add the enchantment when your item gets crafted - something like onCraftItem in your items class (If this works it shouldn’t be too hard). Or do what AnimeFan said and make an IRecipe Handler (once again, I haven’t done anything like this before, and I think that only a few people have). If you want your item to have both the unenchanted item and the enchanted item visible in creative tabs I believe you will have to override the getSubItems method in your items class. I tried to stuff similar to this do this once when I first started modding and failed miserably, however I know that many people successfully display multiple sub items in creative tabs & vanilla has its own examples. You could leave the enchanted item until later when your more experienced in modding? Doing stuff with IRecipes is pretty advanced and can be quite complicated. I hope some of this helped!

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

https://github.com/HSerhatY/MoreStrenghtenedToolsMod/tree/master/com/H_SerhatY/MoreStrenghtenedToolsMod

It's only thing I have in 2 days.

7 minutes ago, Cadiboo said:

I don’t think so, I’ve never done anything with stuff like this. I think someone said you should add the enchantment when your item gets crafted - something like onCraftItem in your items class (If this works it shouldn’t be too hard). Or do what AnimeFan said and make an IRecipe Handler (once again, I haven’t done anything like this before, and I think that only a few people have). If you want your item to have both the unenchanted item and the enchanted item visible in creative tabs I believe you will have to override the getSubItems method in your items class. I tried to stuff similar to this do this once when I first started modding and failed miserably, however I know that many people successfully display multiple sub items in creative tabs & vanilla has its own examples. You could leave the enchanted item until later when your more experienced in modding? Doing stuff with IRecipes is pretty advanced and can be quite complicated. I hope some of this helped!

Edited by H_SerhatY

My Mods:

More Strenghtened Tools Mod:

https://www.curseforge.com/minecraft/mc-mods/mstm

Link to comment
Share on other sites

1 minute ago, H_SerhatY said:

What do you mean? You’ve been working on this problem for 2 days? Work on something else for a while (new items or blocks or entities or tile entities or something?).

 

Or keep working on this. If you do continue attacking this problem, 

 

look at onItemCrafted() (or whatever it’s called)

look at a custom IRecipe thing 

look at getSubItems()

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

5 minutes ago, Cadiboo said:

What do you mean? You’ve been working on this problem for 2 days? Work on something else for a while (new items or blocks or entities or tile entities or something?).

 

Or keep working on this. If you do continue attacking this problem, 

 

look at onItemCrafted() (or whatever it’s called)

look at a custom IRecipe thing 

look at getSubItems()

I don't work on that for 2 days. I make all of that in 2 days. And I have NO errors.

Edited by H_SerhatY

My Mods:

More Strenghtened Tools Mod:

https://www.curseforge.com/minecraft/mc-mods/mstm

Link to comment
Share on other sites

Just now, H_SerhatY said:

I don't work on that for 2 days. I make all of that in 2 days.

Well done

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

2 minutes ago, H_SerhatY said:

I have an idea. If I make an random item in MCreator with enchantment, and I look at this item's code, can I apply these codes to Eclipse?

Don't use MCreator.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

The easiest way is not always the best way, if you want to mod, please learn to do it the right way.

  • Like 1

This is my Forum Signature, I am currently attempting to transform it into a small guide for fixing easier issues using spoiler blocks to keep things tidy.

 

As the most common issue I feel I should put this outside the main bulk:

The only official source for Forge is https://files.minecraftforge.net, and the only site I trust for getting mods is CurseForge.

If you use any site other than these, please take a look at the StopModReposts project and install their browser extension, I would also advise running a virus scan.

 

For players asking for assistance with Forge please expand the spoiler below and read the appropriate section(s) in its/their entirety.

Spoiler

Logs (Most issues require logs to diagnose):

Spoiler

Please post logs using one of the following sites (Thank you Lumber Wizard for the list):

https://gist.github.com/100MB Requires member (Free)

https://pastebin.com/: 512KB as guest, 10MB as Pro ($$$)

https://hastebin.com/: 400KB

Do NOT use sites like Mediafire, Dropbox, OneDrive, Google Drive, or a site that has a countdown before offering downloads.

 

What to provide:

...for Crashes and Runtime issues:

Minecraft 1.14.4 and newer:

Post debug.log

Older versions:

Please update...

 

...for Installer Issues:

Post your installer log, found in the same place you ran the installer

This log will be called either installer.log or named the same as the installer but with .log on the end

Note for Windows users:

Windows hides file extensions by default so the installer may appear without the .jar extension then when the .log is added the log will appear with the .jar extension

 

Where to get it:

Mojang Launcher: When using the Mojang launcher debug.log is found in .minecraft\logs.

 

Curse/Overwolf: If you are using the Curse Launcher, their configurations break Forge's log settings, fortunately there is an easier workaround than I originally thought, this works even with Curse's installation of the Minecraft launcher as long as it is not launched THROUGH Twitch:

Spoiler
  1. Make sure you have the correct version of Forge installed (some packs are heavily dependent on one specific build of Forge)
  2. Make a launcher profile targeting this version of Forge.
  3. Set the launcher profile's GameDir property to the pack's instance folder (not the instances folder, the folder that has the pack's name on it).
  4. Now launch the pack through that profile and follow the "Mojang Launcher" instructions above.

Video:

Spoiler

 

 

 

or alternately, 

 

Fallback ("No logs are generated"):

If you don't see logs generated in the usual place, provide the launcher_log.txt from .minecraft

 

Server Not Starting:

Spoiler

If your server does not start or a command window appears and immediately goes away, run the jar manually and provide the output.

 

Reporting Illegal/Inappropriate Adfocus Ads:

Spoiler

Get a screenshot of the URL bar or copy/paste the whole URL into a thread on the General Discussion board with a description of the Ad.

Lex will need the Ad ID contained in that URL to report it to Adfocus' support team.

 

Posting your mod as a GitHub Repo:

Spoiler

When you have an issue with your mod the most helpful thing you can do when asking for help is to provide your code to those helping you. The most convenient way to do this is via GitHub or another source control hub.

When setting up a GitHub Repo it might seem easy to just upload everything, however this method has the potential for mistakes that could lead to trouble later on, it is recommended to use a Git client or to get comfortable with the Git command line. The following instructions will use the Git Command Line and as such they assume you already have it installed and that you have created a repository.

 

  1. Open a command prompt (CMD, Powershell, Terminal, etc).
  2. Navigate to the folder you extracted Forge’s MDK to (the one that had all the licenses in).
  3. Run the following commands:
    1. git init
    2. git remote add origin [Your Repository's URL]
      • In the case of GitHub it should look like: https://GitHub.com/[Your Username]/[Repo Name].git
    3. git fetch
    4. git checkout --track origin/master
    5. git stage *
    6. git commit -m "[Your commit message]"
    7. git push
  4. Navigate to GitHub and you should now see most of the files.
    • note that it is intentional that some are not synced with GitHub and this is done with the (hidden) .gitignore file that Forge’s MDK has provided (hence the strictness on which folder git init is run from)
  5. Now you can share your GitHub link with those who you are asking for help.

[Workaround line, please ignore]

 

Link to comment
Share on other sites

@H_SerhatY What I suggested may be something you currently don't understand, but it isn't hard to learn. And once you do it you can reapply it later.

 

First in your Items class in the constructor call setHasSubtypes(true) this allows getSubItems to be called in your Items Class Which is the next this to do.

 

So Override getSubItems(CreativeTab NonNullList<ItemStack) and create a new ItemStack of your Item and call addEnchantment(Enchantment, int) on the ItemStack that you created. Finally check if the first parameter is the CreativeTab you wish to add it to, then add your ItemStack to the second parameter.

 

This is the more complicated part, but still not that complicated. You need a new class that implements IRecipeFactory. This will provide you one method. This wants you to return an IRecipe and gives you a JsonContext and a JsonObject. These parameters come from a json file, which is the new way to add recipes to the game. This means you can create your own custom format for a recipe. For further understanding on how to read the data from the JsonObject search for tutorials on GSon, though it is relatively similar to nbt.

 

Once you have your custom format which can derive from the already existing formats, you can create a new ShapedRecipe or a new ShapelessRecipe and that will be what you return in the method, but you will need to create a new ItemStack and add the Enchantment the same way you did earlier, and then pass it into the new ShapedRecipe or new ShapelessRecipe as the result.

  • Thanks 1

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

I don't understand, you are true. And I thinked that again, I don't need to make a mod. I don't need to be a developer. I don't need this technology. I don't need to use computer. I don't need internet. I only need to work for quiz. Okey. If you are happy, don't reply this. And if you are happy, don't reply this too. @Animefan8888

Edited by H_SerhatY

My Mods:

More Strenghtened Tools Mod:

https://www.curseforge.com/minecraft/mc-mods/mstm

Link to comment
Share on other sites

2 minutes ago, H_SerhatY said:

I don't understand, you are true. And I thinked that again, I don't need to make a mod. I don't need to be a developer. I don't need this technology. I don't need to use computer. I don't need internet. I only need to work for quiz. Okey. If you are happy, don't reply this. And if you are happy, don't reply this too. @Animefan8888

I'm not sure what you want, first you say you don't need to do any of the things and tell us not to reply, but then you tag me.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

2 hours ago, H_SerhatY said:

I don't want anything. I only want, you will be go out from my threads and don't reply to me. Because I'm going to be hate from modding.

We are trying our best to help you, but you don’t seem to be following our advice at all (or even reading it) or understanding stuff basic enough that we can’t teach it to you, like basic basic <s>java</s> programming knowledge.

  • Like 1

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.